[Engine-patches] Change in ovirt-engine[ovirt-engine-3.3]: userportal: error flow of RDP RdpPluginImpl broken

2013-11-10 Thread fkobzik
Frank Kobzik has posted comments on this change. Change subject: userportal: error flow of RDP RdpPluginImpl broken .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/21118 To unsubscribe, visit http://ger

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.3]: userportal: error flow of RDP RdpPluginImpl broken

2013-11-10 Thread tjelinek
Tomas Jelinek has uploaded a new change for review. Change subject: userportal: error flow of RDP RdpPluginImpl broken .. userportal: error flow of RDP RdpPluginImpl broken There were the following issues which caused the error

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.3]: userportal: error flow of RDP RdpPluginImpl broken

2013-11-10 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: userportal: error flow of RDP RdpPluginImpl broken .. Patch Set 1: * Tracker #1014710: OK * Set POST #1014710: OK, already on POST -- To view, visit htt

[Engine-patches] Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.0]: packaging: setup: configure bridge after vdsmd start

2013-11-10 Thread didi
Yedidyah Bar David has posted comments on this change. Change subject: packaging: setup: configure bridge after vdsmd start .. Patch Set 1: Verified+1 Based on verification on master. -- To view, visit http://gerrit.ovirt.org

[Engine-patches] Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.0]: packaging: setup: configure bridge after vdsmd start

2013-11-10 Thread sbonazzo
Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: configure bridge after vdsmd start .. packaging: setup: configure bridge after vdsmd start Bug-Url: https://bugzilla.redhat.com/102

[Engine-patches] Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.0]: packaging: setup: configure bridge after vdsmd start

2013-11-10 Thread sbonazzo
Sandro Bonazzola has posted comments on this change. Change subject: packaging: setup: configure bridge after vdsmd start .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/21117 To unsubscribe, visit http

[Engine-patches] Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.0]: packaging: setup: configure bridge after vdsmd start

2013-11-10 Thread didi
Yedidyah Bar David has uploaded a new change for review. Change subject: packaging: setup: configure bridge after vdsmd start .. packaging: setup: configure bridge after vdsmd start Bug-Url: https://bugzilla.redhat.com/1028752 C

[Engine-patches] Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.0]: packaging: setup: configure bridge after vdsmd start

2013-11-10 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: packaging: setup: configure bridge after vdsmd start .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt-hosted-engine-setup_gerrit/1

[Engine-patches] [oVirt Jenkins] ovirt-engine_master_create_rpms_quick - Build # 956 - Failure!

2013-11-10 Thread Jenkins ci oVirt Server
Project: http://jenkins.ovirt.org/job/ovirt-engine_master_create_rpms_quick/ Build: http://jenkins.ovirt.org/job/ovirt-engine_master_create_rpms_quick/956/ Build Number: 956 Build Status: Failure Triggered By: Started by an SCM change - Changes Since Last Succ

[Engine-patches] Change in ovirt-hosted-engine-setup[master]: packaging: setup: configure bridge after vdsmd start

2013-11-10 Thread sbonazzo
Sandro Bonazzola has posted comments on this change. Change subject: packaging: setup: configure bridge after vdsmd start .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/21116 To unsubscribe, visit http

[Engine-patches] Change in ovirt-hosted-engine-setup[master]: packaging: setup: configure bridge after vdsmd start

2013-11-10 Thread sbonazzo
Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: configure bridge after vdsmd start .. packaging: setup: configure bridge after vdsmd start Bug-Url: https://bugzilla.redhat.com/102

[Engine-patches] Change in ovirt-hosted-engine-setup[master]: packaging: setup: configure bridge after vdsmd start

2013-11-10 Thread didi
Yedidyah Bar David has posted comments on this change. Change subject: packaging: setup: configure bridge after vdsmd start .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/21116 To unsubscribe, visit http:

[Engine-patches] Change in ovirt-hosted-engine-setup[master]: packaging: setup: configure bridge after vdsmd start

2013-11-10 Thread didi
Yedidyah Bar David has uploaded a new change for review. Change subject: packaging: setup: configure bridge after vdsmd start .. packaging: setup: configure bridge after vdsmd start Bug-Url: https://bugzilla.redhat.com/1028752 C

[Engine-patches] Change in ovirt-hosted-engine-setup[master]: packaging: setup: configure bridge after vdsmd start

2013-11-10 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: packaging: setup: configure bridge after vdsmd start .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt-hosted-engine-setup_gerrit/1

[Engine-patches] [oVirt Jenkins] ovirt-engine_master_create_rpms_quick » fedora18 - Build # 956 - Failure!

2013-11-10 Thread Jenkins ci oVirt Server
Project: http://jenkins.ovirt.org/job/ovirt-engine_master_create_rpms_quick/./label=fedora18/ Build: http://jenkins.ovirt.org/job/ovirt-engine_master_create_rpms_quick/./label=fedora18/956/ Build Number: 956 Build Status: Failure Triggered By: Started by upstream project "ovirt-engine_master_

[Engine-patches] Change in ovirt-engine[master]: userportal: error flow of RDP RdpPluginImpl broken

2013-11-10 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: userportal: error flow of RDP RdpPluginImpl broken .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_3.3_update_db_to_master

[Engine-patches] Change in ovirt-engine[master]: userportal: error flow of RDP RdpPluginImpl broken

2013-11-10 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: userportal: error flow of RDP RdpPluginImpl broken .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checksty

[Engine-patches] Change in ovirt-engine[master]: userportal: error flow of RDP RdpPluginImpl broken

2013-11-10 Thread tjelinek
Tomas Jelinek has submitted this change and it was merged. Change subject: userportal: error flow of RDP RdpPluginImpl broken .. userportal: error flow of RDP RdpPluginImpl broken There were the following issues which caused th

[Engine-patches] Change in ovirt-engine[master]: userportal: error flow of RDP RdpPluginImpl broken

2013-11-10 Thread tjelinek
Tomas Jelinek has posted comments on this change. Change subject: userportal: error flow of RDP RdpPluginImpl broken .. Patch Set 2: Verified+1 Code-Review+2 -- To view, visit http://gerrit.ovirt.org/20952 To unsubscribe, visi

[Engine-patches] Change in ovirt-engine[master]: webadmin: send ssh keys in cloud init

2013-11-10 Thread tjelinek
Tomas Jelinek has posted comments on this change. Change subject: webadmin: send ssh keys in cloud init .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/21048 To unsubscribe, visit http://gerrit.ovirt.or

[Engine-patches] Change in ovirt-engine[master]: gluster: add gluster host uuid along with host name/ip for r...

2013-11-10 Thread shtripat
Shubhendu Tripathi has posted comments on this change. Change subject: gluster: add gluster host uuid along with host name/ip for remove host .. Patch Set 3: (1 comment) Fi

[Engine-patches] Change in ovirt-engine[master]: gluster: event message for rebalance and remove brick complete

2013-11-10 Thread shtripat
Shubhendu Tripathi has posted comments on this change. Change subject: gluster: event message for rebalance and remove brick complete .. Patch Set 3: (2 comments) File back

[Engine-patches] Change in ovirt-engine[master]: core: Adds missing 3rd party dependencies as modules

2013-11-10 Thread mperina
Martin Peřina has posted comments on this change. Change subject: core: Adds missing 3rd party dependencies as modules .. Patch Set 6: Verified+1 -- To view, visit http://gerrit.ovirt.org/20048 To unsubscribe, visit http://ger

[Engine-patches] Change in ovirt-engine[master]: core: Adds missing 3rd party dependencies as modules

2013-11-10 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: Adds missing 3rd party dependencies as modules .. Patch Set 6: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_3.3_update_db_to_mast

[Engine-patches] Change in ovirt-engine[master]: core: prevent split brain caused by fence commands

2013-11-10 Thread mperina
Martin Peřina has posted comments on this change. Change subject: core: prevent split brain caused by fence commands .. Patch Set 4: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/21049 To unsubscribe, visit http://ge

[Engine-patches] Change in ovirt-engine[master]: webadmin: Renamed the Close button with Cancel

2013-11-10 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: webadmin: Renamed the Close button with Cancel .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_3.3_update_db_to_master_ger

[Engine-patches] Change in ovirt-engine[master]: webadmin: Renamed the Close button with Cancel

2013-11-10 Thread shtripat
Shubhendu Tripathi has posted comments on this change. Change subject: webadmin: Renamed the Close button with Cancel .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.ovirt.org/21088 To unsubscribe, visit http://gerr

[Engine-patches] Change in ovirt-engine[master]: webadmin: Renamed the Close button with Cancel

2013-11-10 Thread kmayilsa
Kanagaraj M has posted comments on this change. Change subject: webadmin: Renamed the Close button with Cancel .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/21088 To unsubscribe, visit http://gerrit.o

[Engine-patches] Change in ovirt-engine[master]: webadmin: Renamed the Close button with Cancel

2013-11-10 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: webadmin: Renamed the Close button with Cancel .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_g

[Engine-patches] Change in ovirt-engine[master]: webadmin: Renamed the Close button with Cancel

2013-11-10 Thread kmayilsa
Kanagaraj M has submitted this change and it was merged. Change subject: webadmin: Renamed the Close button with Cancel .. webadmin: Renamed the Close button with Cancel Renamed the Close button with Cancel in the commit remove

[Engine-patches] Change in ovirt-engine[master]: webadmin: Dont replace . with _ if error not in resources

2013-11-10 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: webadmin: Dont replace . with _ if error not in resources .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_master_compile_c

[Engine-patches] Change in ovirt-engine[master]: webadmin: Renamed the Close button with Cancel

2013-11-10 Thread shtripat
Shubhendu Tripathi has posted comments on this change. Change subject: webadmin: Renamed the Close button with Cancel .. Patch Set 2: Rebased on top of master -- To view, visit http://gerrit.ovirt.org/21088 To unsubscribe, vi

[Engine-patches] Change in ovirt-engine[master]: webadmin: Dont replace . with _ if error not in resources

2013-11-10 Thread shtripat
Shubhendu Tripathi has posted comments on this change. Change subject: webadmin: Dont replace . with _ if error not in resources .. Patch Set 2: Corrected the commit message -- To view, visit http://gerrit.ovirt.org/21083 To

[Engine-patches] Change in ovirt-engine[master]: gluster: Refactored GlusterTaskSyncJob

2013-11-10 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: Refactored GlusterTaskSyncJob .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/10

[Engine-patches] Change in ovirt-engine[master]: gluster: Refactored GlusterTaskSyncJob

2013-11-10 Thread shtripat
Shubhendu Tripathi has posted comments on this change. Change subject: gluster: Refactored GlusterTaskSyncJob .. Patch Set 4: All the comments incorporated/answered -- To view, visit http://gerrit.ovirt.org/21063 To unsubscri

[Engine-patches] Change in ovirt-engine[master]: gluster: During import check host existence by UUID

2013-11-10 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: During import check host existence by UUID .. Patch Set 6: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkst

[Engine-patches] Change in ovirt-engine[master]: gluster: During import check host existence by UUID

2013-11-10 Thread shtripat
Shubhendu Tripathi has posted comments on this change. Change subject: gluster: During import check host existence by UUID .. Patch Set 5: (1 comment) File backend/manager/

[Engine-patches] Change in ovirt-engine[master]: gluster: Modified to fail remove host if already removed fro...

2013-11-10 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: Modified to fail remove host if already removed from CLI .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_master_

[Engine-patches] Change in ovirt-engine[master]: webadmin: fix feedback image visiblity issue

2013-11-10 Thread anbabu
anmolbabu has posted comments on this change. Change subject: webadmin: fix feedback image visiblity issue .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/21084 To unsubscribe, visit http://gerrit.ovirt

[Engine-patches] Change in ovirt-engine[master]: gluster: Modified to fail remove host if already removed fro...

2013-11-10 Thread shtripat
Shubhendu Tripathi has posted comments on this change. Change subject: gluster: Modified to fail remove host if already removed from CLI .. Patch Set 1: (1 comment) File b

[Engine-patches] Change in mom[master]: Add mixed usage of single and multiple policy tests

2013-11-10 Thread liumbj
Mei Liu has abandoned this change. Change subject: Add mixed usage of single and multiple policy tests .. Abandoned -- To view, visit http://gerrit.ovirt.org/13789 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit

[Engine-patches] Change in ovirt-engine[master]: core: increase AutoStartVmsRunner job frequency

2013-11-10 Thread ahadas
Arik Hadas has posted comments on this change. Change subject: core: increase AutoStartVmsRunner job frequency .. Patch Set 11: (1 comment) File backend/manager/modules/bll

[Engine-patches] Change in ovirt-engine[master]: db: sp name should start with upper case letter

2013-11-10 Thread emesika
Eli Mesika has posted comments on this change. Change subject: db: sp name should start with upper case letter .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/21097 To unsubscribe, visit http://gerrit.o

[Engine-patches] Change in ovirt-engine[master]: core: prevent split brain caused by fence commands

2013-11-10 Thread emesika
Eli Mesika has posted comments on this change. Change subject: core: prevent split brain caused by fence commands .. Patch Set 4: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/21049 To unsubscribe, visit http://gerri

[Engine-patches] Change in ovirt-engine[master]: userportal: add 3 exclude to findbugs filter.

2013-11-10 Thread derez
Daniel Erez has posted comments on this change. Change subject: userportal: add 3 exclude to findbugs filter. .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/21115 To unsubscribe, visit http://gerrit.ov

[Engine-patches] Change in ovirt-engine[master]: userportal: add 3 exclude to findbugs filter.

2013-11-10 Thread abonas
Alissa Bonas has posted comments on this change. Change subject: userportal: add 3 exclude to findbugs filter. .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/21115 To unsubscribe, visit http://gerrit.ovir

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.3]: engine: Move quota to Image_storage_domain_map

2013-11-10 Thread emesika
Eli Mesika has posted comments on this change. Change subject: engine: Move quota to Image_storage_domain_map .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/20971 To unsubscribe, visit http://gerrit.ov

[Engine-patches] Change in ovirt-engine[master]: userportal: add 3 exclude to findbugs filter.

2013-11-10 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: userportal: add 3 exclude to findbugs filter. .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_3.3_update_db_to_master_gerr

[Engine-patches] Change in ovirt-engine[master]: utils: SSHDialogTest: Inner class could be made static

2013-11-10 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: utils: SSHDialogTest: Inner class could be made static .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_3.3_update_db_to_ma

[Engine-patches] Change in ovirt-engine[master]: userportal: add 3 exclude to findbugs filter.

2013-11-10 Thread abonas
Alissa Bonas has uploaded a new change for review. Change subject: userportal: add 3 exclude to findbugs filter. .. userportal: add 3 exclude to findbugs filter. Similar to webadmin, the *Presenter classes have a redundant warni

[Engine-patches] Change in ovirt-engine[master]: utils: SSHDialogTest: Inner class could be made static

2013-11-10 Thread emesika
Eli Mesika has submitted this change and it was merged. Change subject: utils: SSHDialogTest: Inner class could be made static .. utils: SSHDialogTest: Inner class could be made static Change-Id: Id82a6181a0cae2b5a5ab7781fc8371

[Engine-patches] Change in ovirt-engine[master]: utils: SSHDialogTest: Inner class could be made static

2013-11-10 Thread emesika
Eli Mesika has posted comments on this change. Change subject: utils: SSHDialogTest: Inner class could be made static .. Patch Set 1: Verified+1 Code-Review+2 -- To view, visit http://gerrit.ovirt.org/21114 To unsubscribe, vis

[Engine-patches] Change in ovirt-engine[master]: core: Default DC & Cluster has fixed UUIDs

2013-11-10 Thread emesika
Eli Mesika has posted comments on this change. Change subject: core: Default DC & Cluster has fixed UUIDs .. Patch Set 2: (1 comment) File backend/manager/modules/common/sr

[Engine-patches] Change in ovirt-engine[master]: utils: SSHDialogTest: Inner class could be made static

2013-11-10 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: utils: SSHDialogTest: Inner class could be made static .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_master_compile_chec

[Engine-patches] Change in ovirt-engine[master]: utils: SSHDialogTest: Inner class could be made static

2013-11-10 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: utils: SSHDialogTest: Inner class could be made static .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/21114 To unsubscribe, visit http://ge

[Engine-patches] Change in ovirt-engine[master]: utils: SSHDialogTest: Inner class could be made static

2013-11-10 Thread Alon Bar-Lev
Alon Bar-Lev has uploaded a new change for review. Change subject: utils: SSHDialogTest: Inner class could be made static .. utils: SSHDialogTest: Inner class could be made static Change-Id: Id82a6181a0cae2b5a5ab7781fc8371eb61c3

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.3]: core: allow identical path for different local domains

2013-11-10 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: allow identical path for different local domains .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_3.3_update_db_to_3.

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.3]: core: allow identical path for different local domains

2013-11-10 Thread iheim
Itamar Heim has submitted this change and it was merged. Change subject: core: allow identical path for different local domains .. core: allow identical path for different local domains StorageServerConnectionCommandBase -> isC

[Engine-patches] Change in ovirt-engine[master]: core: Make commited_disk_size view column show total virtual...

2013-11-10 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: core: Make commited_disk_size view column show total virtual size .. Patch Set 1: (1 comment) General question: is this change was considered at the REST part.

[Engine-patches] Change in ovirt-engine[master]: core: avoid db deadlock and unneeded db updates for images

2013-11-10 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: avoid db deadlock and unneeded db updates for images .. Patch Set 2: Code-Review+2 (2 comments) Comm

[Engine-patches] Change in ovirt-engine[master]: core: Host shouldn't move to UP if it's already connected to...

2013-11-10 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: Host shouldn't move to UP if it's already connected to other pool .. Patch Set 2: Code-Review-1 (2 comments) ...

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.3]: core: export vm - perform space checks only for relevant disks

2013-11-10 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: export vm - perform space checks only for relevant disks .. Patch Set 1: Code-Review+1 Liron/Arik, please open a BZ for this backport. Thanks! -- To vie

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.3]: core: fix of export without tasks and snapshot collapse

2013-11-10 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: fix of export without tasks and snapshot collapse .. Patch Set 1: Code-Review+1 Liron/Arik, please open a BZ for this backport. Thanks! -- To view, visi

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.3]: core: rename method in ExportVmCommand

2013-11-10 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: rename method in ExportVmCommand .. Patch Set 1: why is this needed in ovirt-engine-3.3? -- To view, visit http://gerrit.ovirt.org/21110 To unsubscribe,

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.3]: core: export vm - removal of unneeded for loop

2013-11-10 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: export vm - removal of unneeded for loop .. Patch Set 1: Code-Review+1 Liron/Arik, please open a BZ for this backport. Thanks! -- To view, visit http://

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.3]: core: export memory snapshot volumes for diskless vms

2013-11-10 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: export memory snapshot volumes for diskless vms .. Patch Set 1: Code-Review+1 Liron/Arik, please open a BZ for this backport. Thanks! -- To view, visit

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.3]: core: Fix task polling when exporting vm command with memory...

2013-11-10 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: Fix task polling when exporting vm command with memory snapshots .. Patch Set 3: Code-Review+1 Liron/Arik, please open a BZ for this backport. Thanks! -

[Engine-patches] Change in ovirt-engine[master]: backend, restapi: Add read-only disk functionality

2013-11-10 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: backend, restapi: Add read-only disk functionality .. Patch Set 18: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/15409 To unsubscribe, visit http://ge

[Engine-patches] Change in ovirt-engine[master]: Fix exclusion of unused fields in findbugs

2013-11-10 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: Fix exclusion of unused fields in findbugs .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_3.3_update_db_to_master_gerrit/

[Engine-patches] Change in ovirt-engine[master]: Fix exclusion of unused fields in findbugs

2013-11-10 Thread amureini
Allon Mureinik has submitted this change and it was merged. Change subject: Fix exclusion of unused fields in findbugs .. Fix exclusion of unused fields in findbugs Fix exclusion filter in findbugs for several webadmin *Present

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.3]: engine: Move quota to Image_storage_domain_map

2013-11-10 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: engine: Move quota to Image_storage_domain_map .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/20971 To unsubscribe, visit http://gerri

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.3]: core: allow identical path for different local domains

2013-11-10 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: allow identical path for different local domains .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/21096 To unsubscribe, visit http

[Engine-patches] Change in ovirt-engine[master]: restapi: cloud-init - rest api for start vm

2013-11-10 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: restapi: cloud-init - rest api for start vm .. Patch Set 20: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_ger

[Engine-patches] Change in ovirt-engine[master]: restapi: cloud-init - rest api for start vm

2013-11-10 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: restapi: cloud-init - rest api for start vm .. Patch Set 20: sorry patchset 19 missed part of the fix, ignore it, fix is in 20 -- To view, visit http://gerrit.o

[Engine-patches] Change in ovirt-engine[master]: Fix exclusion of unused fields in findbugs

2013-11-10 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: Fix exclusion of unused fields in findbugs .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/21101 To unsubscribe, visit http://gerrit.ov

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.3]: core: export vm - perform space checks only for relevant disks

2013-11-10 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: export vm - perform space checks only for relevant disks .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_3.3_update_

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.3]: core: rename method in ExportVmCommand

2013-11-10 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: rename method in ExportVmCommand .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_3.3_update_db_to_3.3_latest_gerrit/

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.3]: core: fix of export without tasks and snapshot collapse

2013-11-10 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: fix of export without tasks and snapshot collapse .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_3.3_update_db_to_3

[Engine-patches] Change in ovirt-engine[master]: core: increase AutoStartVmsRunner job frequency

2013-11-10 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: core: increase AutoStartVmsRunner job frequency .. Patch Set 11: (1 comment) File backend/manager/modules/b

[Engine-patches] Change in ovirt-engine[master]: core: avoid db deadlock and unneeded db updates for images

2013-11-10 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: core: avoid db deadlock and unneeded db updates for images .. Patch Set 2: 1. The fix make the code more efficient, we can avoid to update the status if it was n

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.3]: core: export vm - removal of unneeded for loop

2013-11-10 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: export vm - removal of unneeded for loop .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_3.3_update_db_to_3.3_latest

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.3]: core: export memory snapshot volumes for diskless vms

2013-11-10 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: export memory snapshot volumes for diskless vms .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_3.3_update_db_to_3.3

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.3]: core: Fix task polling when exporting vm command with memory...

2013-11-10 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: Fix task polling when exporting vm command with memory snapshots .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_3.

[Engine-patches] Change in ovirt-engine[master]: restapi: cloud-init - rest api for start vm

2013-11-10 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: restapi: cloud-init - rest api for start vm .. Patch Set 14: (1 comment) rebased and fixed according to Ori's request ..

[Engine-patches] Change in ovirt-engine[master]: core: prevent split brain caused by fence commands

2013-11-10 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: prevent split brain caused by fence commands .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checksty

[Engine-patches] Change in ovirt-engine[master]: restapi: cloud-init - rest api for start vm

2013-11-10 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: restapi: cloud-init - rest api for start vm .. Patch Set 19: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_ger

[Engine-patches] Change in ovirt-engine[master]: core: prevent split brain caused by fence commands

2013-11-10 Thread rgolan
Roy Golan has posted comments on this change. Change subject: core: prevent split brain caused by fence commands .. Patch Set 3: (4 comments) File backend/manager/modules/b

[Engine-patches] Change in ovirt-engine[master]: core: prevent split brain caused by fence commands

2013-11-10 Thread rgolan
Roy Golan has posted comments on this change. Change subject: core: prevent split brain caused by fence commands .. Patch Set 4: Verified+1 -- To view, visit http://gerrit.ovirt.org/21049 To unsubscribe, visit http://gerrit.ov

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.3]: core: rename method in ExportVmCommand

2013-11-10 Thread laravot
Liron Ar has uploaded a new change for review. Change subject: core: rename method in ExportVmCommand .. core: rename method in ExportVmCommand Rename the method endDiskRelatedActions to be less obscure and reflect what it actua

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.3]: core: fix of export without tasks and snapshot collapse

2013-11-10 Thread laravot
Liron Ar has uploaded a new change for review. Change subject: core: fix of export without tasks and snapshot collapse .. core: fix of export without tasks and snapshot collapse The following patch handles the following issues:

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.3]: core: export memory snapshot volumes for diskless vms

2013-11-10 Thread laravot
Liron Ar has uploaded a new change for review. Change subject: core: export memory snapshot volumes for diskless vms .. core: export memory snapshot volumes for diskless vms When exporting a diskless vm, the command is ended rig

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.3]: core: export vm - removal of unneeded for loop

2013-11-10 Thread laravot
Liron Ar has uploaded a new change for review. Change subject: core: export vm - removal of unneeded for loop .. core: export vm - removal of unneeded for loop All the disks that are part of the export are already being iterated

[Engine-patches] Change in ovirt-engine[ovirt-engine-3.3]: core: export vm - perform space checks only for relevant disks

2013-11-10 Thread laravot
Liron Ar has uploaded a new change for review. Change subject: core: export vm - perform space checks only for relevant disks .. core: export vm - perform space checks only for relevant disks Currently the space check on export

[Engine-patches] Change in ovirt-engine[master]: webadmin: fix volume bricks tab refresh issue

2013-11-10 Thread kmayilsa
Kanagaraj M has posted comments on this change. Change subject: webadmin: fix volume bricks tab refresh issue .. Patch Set 2: (1 comment) File frontend/webadmin/modules/uic

[Engine-patches] Change in ovirt-engine[master]: utils: pki-resource: cleanup: levarage enum for constants

2013-11-10 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: utils: pki-resource: cleanup: levarage enum for constants .. Patch Set 8: Verified+1 This only proves that Java is primitive... I tried reflection, which turned

[Engine-patches] Change in ovirt-engine[master]: utils: pki-resource: cleanup: levarage enum for constants

2013-11-10 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: utils: pki-resource: cleanup: levarage enum for constants .. Patch Set 8: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_master_compile_c

[Engine-patches] Change in ovirt-engine[master]: core: avoid db deadlock and unneeded db updates for images

2013-11-10 Thread laravot
Liron Ar has posted comments on this change. Change subject: core: avoid db deadlock and unneeded db updates for images .. Patch Set 2: @Arik, I've meant to db lock. -- To view, visit http://gerrit.ovirt.org/21100 To unsubscr

[Engine-patches] Change in ovirt-engine[master]: engine: Allowed vNIC activation when VM status is ImageLocked

2013-11-10 Thread masayag
Moti Asayag has posted comments on this change. Change subject: engine: Allowed vNIC activation when VM status is ImageLocked .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/21102 To unsubscribe, visit

[Engine-patches] Change in ovirt-engine[master]: core: avoid db deadlock and unneeded db updates for images

2013-11-10 Thread ahadas
Arik Hadas has posted comments on this change. Change subject: core: avoid db deadlock and unneeded db updates for images .. Patch Set 2: Code-Review+1 The patch looks good. Regarding your comment in the commit message, on whic

[Engine-patches] Change in ovirt-engine[master]: engine: Allowed vNIC activation when VM status is ImageLocked

2013-11-10 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Allowed vNIC activation when VM status is ImageLocked .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_master_compi

  1   2   3   >