Tomas Jelinek has submitted this change and it was merged. Change subject: userportal: error flow of RDP RdpPluginImpl broken ......................................................................
userportal: error flow of RDP RdpPluginImpl broken There were the following issues which caused the error not to be propagated: - a regression caused by 625b7452d840793df5e72764193c98c5ba121cdf which did bring back the crashing of IE if the RDP connection is not successful (originally fixed by fa10641c3484ea10d0b1b33ef8e3d656b5e6dd35). - by the same commit (625b7452d840793df5e72764193c98c5ba121cdf) the new method setParentModel has been introduced but it was not called. It caused a NPE on RdpPluginImpl.rdpDisconnected:66. Fixed by calling this method on the relevant places. - after autologin the Frontend.getInstance().getLoginPassword() returns null which causes NPE on RdpPluginImpl:113 when setting this pass to ClearTextPassword. Fixed at AbstractRdp level because the null password for DbUser class can still be relevant - just needs to be handled differently on AbstractRdp level. Change-Id: I85fc3b32c4f544f23864db2aefa5ebcd4d896b75 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1014710 Signed-off-by: Tomas Jelinek <tjeli...@redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/AbstractRdp.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/RdpPluginImpl.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/RdpConsoleModel.java 3 files changed, 6 insertions(+), 3 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20952 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I85fc3b32c4f544f23864db2aefa5ebcd4d896b75 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Frank Kobzik <fkob...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
