Allon Mureinik has posted comments on this change. Change subject: core: avoid db deadlock and unneeded db updates for images ......................................................................
Patch Set 2: Code-Review+2 (2 comments) .................................................... Commit Message Line 5: CommitDate: 2013-11-10 09:32:22 -0500 Line 6: Line 7: core: avoid db deadlock and unneeded db updates for images Line 8: Line 9: When adding vm from template (as part of pool or not), "a VM from a template" Line 10: CreateSnapshotFromTemplateCommand is being executed and when the Line 11: operation ends its end method is being called for each of the disks. Line 12: Line 13: In the end method there's an attempt to unlock the template image which Line 14: causes to numerous issues: Line 15: 1. There are attempts to update the template disks statuses to ok, Line 16: as the updates aren't ordered and are executed for each added vm based Line 17: on that template - db deadlocks occur. Line 18: 2.Currently the template disks aren't being locked at all (which should be inspected regardless), so there's currently no point in unlocking them. please break this line to 70 chars lines Line 19: Line 20: The fix which is introduced is to not update the image status if it's Line 21: already in the desired status, which will reduce the updates count in Line 22: general and will prevent possible db deadlocks in the provided -- To view, visit http://gerrit.ovirt.org/21100 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I26a09ce674cfefd59819f3edf95accab31f0e80e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
