Liron Ar has uploaded a new change for review.

Change subject: core: export memory snapshot volumes for diskless vms
......................................................................

core: export memory snapshot volumes for diskless vms

When exporting a diskless vm, the command is ended right away if the vm
doesn't have any disks for export, as no tasks would be created.
The VM might have no disks, but have snapshots that contain memory
snapshots, those memory volumes need to be exported as well otherwise the
export data would be partial only.

Change-Id: Ie8afa364925dc8a8cdfc1f64939a6f28945fe043
Signed-off-by: Liron Aravot <lara...@redhat.com>
---
M 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportVmCommand.java
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/08/21108/1

diff --git 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportVmCommand.java
 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportVmCommand.java
index bae7210..78059be 100644
--- 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportVmCommand.java
+++ 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportVmCommand.java
@@ -212,7 +212,7 @@
 
         // Means that there are no asynchronous tasks to execute - so we can 
end the command
         // immediately after the execution of the previous steps
-        if (!hasSnappableDisks()) {
+        if (!hasSnappableDisks() && snapshotsWithMemory.isEmpty()) {
             endSuccessfullySynchronous();
         } else {
             TransactionSupport.executeInNewTransaction(new 
TransactionMethod<Void>() {


-- 
To view, visit http://gerrit.ovirt.org/21108
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie8afa364925dc8a8cdfc1f64939a6f28945fe043
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Liron Ar <lara...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to