Omer Frenkel has posted comments on this change.
Change subject: core: increase AutoStartVmsRunner job frequency
......................................................................
Patch Set 11:
(1 comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommandBase.java
Line 61: protected boolean _isRerun = false;
Line 62: protected VDS _destinationVds;
Line 63: private SnapshotsValidator snapshotsValidator=new
SnapshotsValidator();
Line 64: private final List<Guid> runVdsList = new ArrayList<Guid>();
Line 65: private EngineLock engineLock;
why not resue engine lock object that already exist in command base?
the problem now is that un-aware user in some inheriting command might use
getLock() to pass the lock, and it will not be the right lock.
hint, this already happens... did you try to run stateless vm?
Line 66:
Line 67: protected RunVmCommandBase(Guid commandId) {
Line 68: super(commandId);
Line 69: }
--
To view, visit http://gerrit.ovirt.org/19499
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0968cae554458f53a1f30643848bb8d88bd4de11
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <aha...@redhat.com>
Gerrit-Reviewer: Arik Hadas <aha...@redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
