Maor Lipchuk has posted comments on this change. Change subject: core: avoid db deadlock and unneeded db updates for images ......................................................................
Patch Set 2: 1. The fix make the code more efficient, we can avoid to update the status if it was not changed 2. I think that this fix is much too general, The template's images are not locked, therefore should not be unlocked. my suggestion is to override the method unLockImage() method at CreateSnapshotFromTemplateCommand and make it empty (do nothing) -- To view, visit http://gerrit.ovirt.org/21100 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I26a09ce674cfefd59819f3edf95accab31f0e80e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
