Shubhendu Tripathi has posted comments on this change.

Change subject: gluster: add gluster host uuid along with host name/ip for 
remove host
......................................................................


Patch Set 3:

(1 comment)

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVdsCommand.java
Line 196:     }
Line 197: 
Line 198:     private void glusterHostRemove() {
Line 199:         if (clusterHasMultipleHosts() && !hasVolumeBricksOnServer()) {
Line 200:             GlusterServer glusterServer = 
getGlusterServerDao().getByServerId(getVds().getId());
This piece of code can be reused in ChangeVDSClusterCommand as well. Try !
Line 201:             Guid glusterHostId =
Line 202:                 (glusterServer != null) ? 
glusterServer.getGlusterServerUuid() : null;
Line 203:             if (glusterHostId == null) {
Line 204:                 log.warnFormat("Could not find gluster host uuid for 
the node {0}",


-- 
To view, visit http://gerrit.ovirt.org/20731
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I799333a16dfffaa6125aa6d498e4292cbb97cf48
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Timothy Asir <tjeya...@redhat.com>
Gerrit-Reviewer: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeya...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to