Maor Lipchuk has posted comments on this change. Change subject: core: Make commited_disk_size view column show total virtual size ......................................................................
Patch Set 1: (1 comment) General question: is this change was considered at the REST part. (For example, if someone wrote a script that will give him all the storage domains which has more then 150GB free space/occupied space etc.), isn't that will be a change in the behaviour now? .................................................... File packaging/dbscripts/create_functions.sql Line 348: mult bigint; Line 349: Line 350: BEGIN Line 351: mult := ( SELECT Line 352: COALESCE(SUM(images_storage_domain_view.size),0) Though it is not related to the change in the patch, I think we can relinquish COALESCE in the future, since I doubt it that size could be null. Line 353: FROM images_storage_domain_view JOIN Line 354: disk_image_dynamic ON ( images_storage_domain_view.image_guid = disk_image_dynamic.image_id ) Line 355: WHERE Line 356: images_storage_domain_view.storage_id = v_storage_domain_id ); -- To view, visit http://gerrit.ovirt.org/20930 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic16b249779add146705a4e104dd93836923fbbd4 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgot...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
