[Engine-patches] Change in ovirt-engine[master]: core: failCanDoAction method with variable replacements

2013-08-28 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: failCanDoAction method with variable replacements .. Patch Set 6: Code-Review+1 (2 comments) Commit

[Engine-patches] Change in ovirt-engine[master]: gluster: Added app_mode field to roles table

2013-08-28 Thread shtripat
Shubhendu Tripathi has posted comments on this change. Change subject: gluster: Added app_mode field to roles table .. Patch Set 7: Thanks Itamar, valid point. Will do the REST changes in a separate patch. -- To view, visit h

[Engine-patches] Change in ovirt-engine[master]: gluster: Added app_mode field to roles table

2013-08-28 Thread kmayilsa
Kanagaraj M has posted comments on this change. Change subject: gluster: Added app_mode field to roles table .. Patch Set 7: (3 comments) File backend/manager/modules/commo

[Engine-patches] Change in ovirt-engine[master]: core, restapi: attach detach storage connections

2013-08-28 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core,restapi: attach detach storage connections .. Patch Set 21: Code-Review+2 (1 comment) Backend looks ok. Giving +2 to the entire patch based on Michael's +

[Engine-patches] Change in ovirt-engine[master]: core: failCanDoAction method with variable replacements

2013-08-28 Thread ahadas
Arik Hadas has posted comments on this change. Change subject: core: failCanDoAction method with variable replacements .. Patch Set 6: Verified+1 -- To view, visit http://gerrit.ovirt.org/18006 To unsubscribe, visit http://ger

[Engine-patches] Change in ovirt-engine[master]: core: sync luns info after ConnectStorageServer

2013-08-28 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: sync luns info after ConnectStorageServer .. Patch Set 8: @Daniel - please verify so this can be merged. -- To view, visit http://gerrit.ovirt.org/17919

[Engine-patches] Change in ovirt-engine[master]: core: failCanDoAction method with variable replacements

2013-08-28 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: failCanDoAction method with variable replacements .. Patch Set 6: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_che

[Engine-patches] Change in ovirt-engine[master]: webadmin: add status image column to bricks tab

2013-08-28 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: webadmin: add status image column to bricks tab .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_

[Engine-patches] Change in ovirt-engine[master]: webadmin: Attach ISO dialog - adjusted dimensions

2013-08-28 Thread tjelinek
Tomas Jelinek has posted comments on this change. Change subject: webadmin: Attach ISO dialog - adjusted dimensions .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/18666 To unsubscribe, visit http://ger

[Engine-patches] Change in ovirt-engine[master]: gluster: Added app_mode field to roles table

2013-08-28 Thread iheim
Itamar Heim has posted comments on this change. Change subject: gluster: Added app_mode field to roles table .. Patch Set 7: you should also cover filtering per app mode in the rest api? -- To view, visit http://gerrit.ovirt.

[Engine-patches] Change in ovirt-engine[master]: webadmin: add status image column to bricks tab

2013-08-28 Thread kmayilsa
Kanagaraj M has submitted this change and it was merged. Change subject: webadmin: add status image column to bricks tab .. webadmin: add status image column to bricks tab Added a status image colume to bricks subtab. Removed t

[Engine-patches] Change in ovirt-engine[master]: webadmin: add status image column to bricks tab

2013-08-28 Thread kmayilsa
Kanagaraj M has posted comments on this change. Change subject: webadmin: add status image column to bricks tab .. Patch Set 2: Verified+1 Code-Review+2 -- To view, visit http://gerrit.ovirt.org/18678 To unsubscribe, visit htt

[Engine-patches] Change in ovirt-engine[master]: gluster: Added app_mode field to roles table

2013-08-28 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: Added app_mode field to roles table .. Patch Set 7: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_ger

[Engine-patches] Change in ovirt-engine[master]: engine : Null Pointer Exception for action CreateAllSnapshot...

2013-08-28 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine : Null Pointer Exception for action CreateAllSnapshotsFromVm after failure in create snapshot .. Patch Set 9: Build Successful http://jenkins

[Engine-patches] Change in ovirt-engine[master]: engine : Null Pointer Exception for action CreateAllSnapshot...

2013-08-28 Thread amureini
Allon Mureinik has submitted this change and it was merged. Change subject: engine : Null Pointer Exception for action CreateAllSnapshotsFromVm after failure in create snapshot .. engine : Null Pointer Exception for action Crea

[Engine-patches] Change in ovirt-engine[master]: engine : Null Pointer Exception for action CreateAllSnapshot...

2013-08-28 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: engine : Null Pointer Exception for action CreateAllSnapshotsFromVm after failure in create snapshot .. Patch Set 9: Verified+1 Code-Review+2 Rebased, no code

[Engine-patches] Change in ovirt-engine[master]: packaging: setup: remove postgresql port from iptable template

2013-08-28 Thread Yedidyah Bar David
Yedidyah Bar David has posted comments on this change. Change subject: packaging: setup: remove postgresql port from iptable template .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/18679 To unsubscribe

[Engine-patches] [oVirt Jenkins] ovirt_engine_update_db_multiple_os - Build # 1951 - Fixed!

2013-08-28 Thread Jenkins ci oVirt Server
Project: http://jenkins.ovirt.org/job/ovirt_engine_update_db_multiple_os/ Build: http://jenkins.ovirt.org/job/ovirt_engine_update_db_multiple_os/1951/ Build Number: 1951 Build Status: Fixed Triggered By: Started by an SCM change - Changes Since Last Success: -

[Engine-patches] [oVirt Jenkins] ovirt_engine_update_db_multiple_os » fedora18 - Build # 1951 - Fixed!

2013-08-28 Thread Jenkins ci oVirt Server
Project: http://jenkins.ovirt.org/job/ovirt_engine_update_db_multiple_os/./label=fedora18/ Build: http://jenkins.ovirt.org/job/ovirt_engine_update_db_multiple_os/./label=fedora18/1951/ Build Number: 1951 Build Status: Fixed Triggered By: Started by upstream project "ovirt_engine_update_db_mult

[Engine-patches] Change in ovirt-engine[master]: packaging: setup: remove postgresql port from iptable template

2013-08-28 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: remove postgresql port from iptable template .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/18679 To unsubscribe, visit h

[Engine-patches] Change in ovirt-engine[master]: packaging: setup: remove postgresql port from iptable template

2013-08-28 Thread Alon Bar-Lev
Alon Bar-Lev has uploaded a new change for review. Change subject: packaging: setup: remove postgresql port from iptable template .. packaging: setup: remove postgresql port from iptable template the port is added using the fire

[Engine-patches] Change in ovirt-engine[master]: packaging: setup: Added default firewall rules for postgres

2013-08-28 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: Added default firewall rules for postgres .. Patch Set 4: > You are right! the legacy setup should have been modified to add the port to the cu

[Engine-patches] Change in ovirt-engine[master]: packaging: setup: Do not skip over fedora files

2013-08-28 Thread oschreib
Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: setup: Do not skip over fedora files .. packaging: setup: Do not skip over fedora files Now that http://gerrit.ovirt.org/17204 was merged, n

[Engine-patches] Change in ovirt-engine[master]: packaging: setup: Do not skip over fedora files

2013-08-28 Thread oschreib
Ofer Schreiber has posted comments on this change. Change subject: packaging: setup: Do not skip over fedora files .. Patch Set 2: Verified+1 Code-Review+2 -- To view, visit http://gerrit.ovirt.org/18062 To unsubscribe, visit

[Engine-patches] Change in ovirt-engine[master]: packaging: setup: Added default firewall rules for postgres

2013-08-28 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: Added default firewall rules for postgres .. Patch Set 4: > Am I wrong? If not, I think it should be removed from the template. You are right!

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: added favicon.ico to branding

2013-08-28 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: userportal, webadmin: added favicon.ico to branding .. Patch Set 3: (4 comments) Thanks! Notes for the new implementation.

[Engine-patches] Change in ovirt-engine[master]: webadmin: add status image column to bricks tab

2013-08-28 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: webadmin: add status image column to bricks tab .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_

[Engine-patches] Change in ovirt-engine[master]: packaging: setup: Added default firewall rules for postgres

2013-08-28 Thread Yedidyah Bar David
Yedidyah Bar David has posted comments on this change. Change subject: packaging: setup: Added default firewall rules for postgres .. Patch Set 4: Alex, this seems to me to add the port twice when iptables is chosen. Once in t

[Engine-patches] Change in ovirt-engine[master]: packaging: setup: process fw templates at validation

2013-08-28 Thread Yedidyah Bar David
Yedidyah Bar David has posted comments on this change. Change subject: packaging: setup: process fw templates at validation .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.ovirt.org/18660 To unsubscribe, visit http:

[Engine-patches] Change in ovirt-engine[master]: webadmin: add status image column to bricks tab

2013-08-28 Thread gchaplik
Gilad Chaplik has posted comments on this change. Change subject: webadmin: add status image column to bricks tab .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/18678 To unsubscribe, visit http://gerri

[Engine-patches] Change in ovirt-engine[master]: webadmin: add status image column to bricks tab

2013-08-28 Thread kmayilsa
Kanagaraj M has uploaded a new change for review. Change subject: webadmin: add status image column to bricks tab .. webadmin: add status image column to bricks tab Added a status image colume to bricks subtab. Removed the exist

[Engine-patches] Change in ovirt-engine[master]: gluster: Added app_mode field to roles table

2013-08-28 Thread shtripat
Shubhendu Tripathi has posted comments on this change. Change subject: gluster: Added app_mode field to roles table .. Patch Set 6: (2 comments) File packaging/dbscripts/mul

[Engine-patches] Change in ovirt-engine[master]: packaging: setup: append lines once to hb_hba.conf

2013-08-28 Thread Yedidyah Bar David
Yedidyah Bar David has posted comments on this change. Change subject: packaging: setup: append lines once to hb_hba.conf .. Patch Set 1: Code-Review+1 Nice! I also noted that, did not have time to investigate :-) -- To view,

[Engine-patches] Change in ovirt-engine[master]: packaging: setup: saving memcheck parameter to answer file

2013-08-28 Thread Yedidyah Bar David
Yedidyah Bar David has posted comments on this change. Change subject: packaging: setup: saving memcheck parameter to answer file .. Patch Set 3: Code-Review+1 IIRC I talked about this with Ofer a few weeks ago and he objected.

[Engine-patches] Change in ovirt-engine[master]: gluster: Added app_mode field to roles table

2013-08-28 Thread shtripat
Shubhendu Tripathi has posted comments on this change. Change subject: gluster: Added app_mode field to roles table .. Patch Set 6: (6 comments) File packaging/dbscripts/mul

[Engine-patches] Change in ovirt-engine[master]: core: keep locks for whole offline disk migration process

2013-08-28 Thread cheryntan
Cheryn Tan has posted comments on this change. Change subject: core: keep locks for whole offline disk migration process .. Patch Set 4: I would still suggest changing it to "Disk ${DiskName} is being moved or copied" instead

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: added favicon.ico to branding

2013-08-28 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: userportal, webadmin: added favicon.ico to branding .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkst

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: added favicon.ico to branding

2013-08-28 Thread gshereme
Greg Sheremeta has posted comments on this change. Change subject: userportal, webadmin: added favicon.ico to branding .. Patch Set 3: (1 comment) File backend/manager/modu

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: added favicon.ico to branding

2013-08-28 Thread gshereme
Greg Sheremeta has posted comments on this change. Change subject: userportal, webadmin: added favicon.ico to branding .. Patch Set 3: Verified+1 Per Alon's idea, this patch no longer serves the favicon from the root /favicon.

[Engine-patches] Change in ovirt-engine[master]: UI: expose CSS class defined in LoginPopupView.ui.xml

2013-08-28 Thread mobixsw
静 黎 has posted comments on this change. Change subject: UI: expose CSS class defined in LoginPopupView.ui.xml .. Patch Set 4: Conrad: Thanks for your reply.I think I understand your advice.I will expose brandable styles

[Engine-patches] [oVirt Jenkins] ovirt-engine_create_rpms_quick - Build # 416 - Still Failing!

2013-08-28 Thread Jenkins ci oVirt Server
Project: http://jenkins.ovirt.org/job/ovirt-engine_create_rpms_quick/ Build: http://jenkins.ovirt.org/job/ovirt-engine_create_rpms_quick/416/ Build Number: 416 Build Status: Still Failing Triggered By: Started by an SCM change - Changes Since Last Success: ---

[Engine-patches] [oVirt Jenkins] ovirt-engine_create_rpms_quick - Build # 415 - Still Failing!

2013-08-28 Thread Jenkins ci oVirt Server
Project: http://jenkins.ovirt.org/job/ovirt-engine_create_rpms_quick/ Build: http://jenkins.ovirt.org/job/ovirt-engine_create_rpms_quick/415/ Build Number: 415 Build Status: Still Failing Triggered By: Started by an SCM change - Changes Since Last Success: ---

[Engine-patches] Change in ovirt-engine[master]: core, restapi: Introducing support for attaching disk snapshot

2013-08-28 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: core, restapi: Introducing support for attaching disk snapshot .. Patch Set 13: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_com

[Engine-patches] Change in ovirt-engine[master]: packaging: setup: saving memcheck parameter to answer file

2013-08-28 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: saving memcheck parameter to answer file .. Patch Set 3: (2 comments) File packaging/setup

[Engine-patches] Change in ovirt-engine[master]: packaging: setup: saving memcheck parameter to answer file

2013-08-28 Thread alourie
Alex Lourie has posted comments on this change. Change subject: packaging: setup: saving memcheck parameter to answer file .. Patch Set 3: (2 comments) File packaging/setup/

[Engine-patches] Change in ovirt-engine[master]: packaging: setup: saving memcheck parameter to answer file

2013-08-28 Thread alourie
Alex Lourie has posted comments on this change. Change subject: packaging: setup: saving memcheck parameter to answer file .. Patch Set 3: Verified+1 verified creation of the answer file and the run with that answer file. --

[Engine-patches] Change in ovirt-engine[master]: packaging: setup: saving memcheck parameter to answer file

2013-08-28 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: saving memcheck parameter to answer file .. Patch Set 3: (2 comments) File packaging/setup

[Engine-patches] [oVirt Jenkins] ovirt-engine_create_rpms_quick - Build # 414 - Failure!

2013-08-28 Thread Jenkins ci oVirt Server
Project: http://jenkins.ovirt.org/job/ovirt-engine_create_rpms_quick/ Build: http://jenkins.ovirt.org/job/ovirt-engine_create_rpms_quick/414/ Build Number: 414 Build Status: Failure Triggered By: Started by an SCM change - Changes Since Last Success: -

[Engine-patches] Change in ovirt-engine[master]: core: add failCanDoAction method with variable replacements

2013-08-28 Thread sgotliv
Sergey Gotliv has posted comments on this change. Change subject: core: add failCanDoAction method with variable replacements .. Patch Set 5: Code-Review+1 :-) My bad. please, change commit message accordingly, according to it

[Engine-patches] Change in ovirt-engine[master]: packaging: setup: saving memcheck parameter to answer file

2013-08-28 Thread alourie
Alex Lourie has posted comments on this change. Change subject: packaging: setup: saving memcheck parameter to answer file .. Patch Set 2: (2 comments) File packaging/setup/

[Engine-patches] [oVirt Jenkins] ovirt_engine_update_db_multiple_os - Build # 1950 - Failure!

2013-08-28 Thread Jenkins ci oVirt Server
Project: http://jenkins.ovirt.org/job/ovirt_engine_update_db_multiple_os/ Build: http://jenkins.ovirt.org/job/ovirt_engine_update_db_multiple_os/1950/ Build Number: 1950 Build Status: Failure Triggered By: Started by an SCM change - Changes Since Last Success:

[Engine-patches] Change in ovirt-engine[master]: engine: VM Device Type for Display Type

2013-08-28 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: VM Device Type for Display Type .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_gerrit/7

[Engine-patches] [oVirt Jenkins] ovirt_engine_update_db_multiple_os » fedora18 - Build # 1950 - Failure!

2013-08-28 Thread Jenkins ci oVirt Server
Project: http://jenkins.ovirt.org/job/ovirt_engine_update_db_multiple_os/./label=fedora18/ Build: http://jenkins.ovirt.org/job/ovirt_engine_update_db_multiple_os/./label=fedora18/1950/ Build Number: 1950 Build Status: Failure Triggered By: Started by upstream project "ovirt_engine_update_db_mu

[Engine-patches] Change in ovirt-engine[master]: engine: Prevent implicit usage of port mirroring

2013-08-28 Thread masayag
Moti Asayag has submitted this change and it was merged. Change subject: engine: Prevent implicit usage of port mirroring .. engine: Prevent implicit usage of port mirroring The patch denies attempt of an imported vm to use a v

[Engine-patches] Change in ovirt-engine[master]: core: add failCanDoAction method with variable replacements

2013-08-28 Thread ahadas
Arik Hadas has posted comments on this change. Change subject: core: add failCanDoAction method with variable replacements .. Patch Set 5: Sergey, I'm not sure I understand the question - I changed the original failCanDoAction

[Engine-patches] Change in ovirt-engine[master]: engine: Prevent implicit usage of port mirroring

2013-08-28 Thread masayag
Moti Asayag has posted comments on this change. Change subject: engine: Prevent implicit usage of port mirroring .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/18547 To unsubscribe, visit http://gerrit

[Engine-patches] Change in ovirt-engine[master]: engine: Prevent implicit usage of port mirroring

2013-08-28 Thread masayag
Moti Asayag has posted comments on this change. Change subject: engine: Prevent implicit usage of port mirroring .. Patch Set 4: Verified+1 -- To view, visit http://gerrit.ovirt.org/18547 To unsubscribe, visit http://gerrit.ov

[Engine-patches] Change in ovirt-engine[master]: engine: Fix NPE when network qos is partially provided

2013-08-28 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Fix NPE when network qos is partially provided .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_chec

[Engine-patches] Change in ovirt-engine[master]: restapi: Allow untagging a network with vlan-id

2013-08-28 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: restapi: Allow untagging a network with vlan-id .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_

[Engine-patches] Change in ovirt-engine[master]: engine: Prevent implicit usage of port mirroring

2013-08-28 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: Prevent implicit usage of port mirroring .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle

[Engine-patches] Change in ovirt-engine[master]: engine: NetworkQoS should be sent to vdsm on nic hotplug

2013-08-28 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: NetworkQoS should be sent to vdsm on nic hotplug .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_ch

[Engine-patches] Change in ovirt-engine[master]: engine: VM Device Type for Display Type

2013-08-28 Thread Gustavo Frederico Temple Pedrosa
Gustavo Frederico Temple Pedrosa has uploaded a new change for review. Change subject: engine: VM Device Type for Display Type .. engine: VM Device Type for Display Type This change added VM Device Type for Display Type in prope

[Engine-patches] Change in ovirt-engine[master]: engine: VM Device Type for Display Type

2013-08-28 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: engine: VM Device Type for Display Type .. Patch Set 1: Verified-1 Build Failed http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checkstyle_g

[Engine-patches] Change in ovirt-engine[master]: gluster: Added app_mode field to roles table

2013-08-28 Thread emesika
Eli Mesika has posted comments on this change. Change subject: gluster: Added app_mode field to roles table .. Patch Set 6: Code-Review-1 (6 comments) File packaging/dbscrip

[Engine-patches] Change in ovirt-engine[master]: engine: Fix NPE when network qos is partially provided

2013-08-28 Thread masayag
Moti Asayag has posted comments on this change. Change subject: engine: Fix NPE when network qos is partially provided .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/18676 To unsubscribe, visit http://ger

[Engine-patches] Change in ovirt-engine[master]: restapi: Allow untagging a network with vlan-id

2013-08-28 Thread masayag
Moti Asayag has posted comments on this change. Change subject: restapi: Allow untagging a network with vlan-id .. Patch Set 5: Verified+1 -- To view, visit http://gerrit.ovirt.org/18489 To unsubscribe, visit http://gerrit.ovi

[Engine-patches] Change in ovirt-engine[master]: engine: NetworkQoS should be sent to vdsm on nic hotplug

2013-08-28 Thread masayag
Moti Asayag has posted comments on this change. Change subject: engine: NetworkQoS should be sent to vdsm on nic hotplug .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/18675 To unsubscribe, visit http://g

[Engine-patches] Change in ovirt-engine[master]: engine: NetworkQoS should be sent to vdsm on nic hotplug

2013-08-28 Thread masayag
Moti Asayag has uploaded a new change for review. Change subject: engine: NetworkQoS should be sent to vdsm on nic hotplug .. engine: NetworkQoS should be sent to vdsm on nic hotplug The patch assures the network QoS parameters

[Engine-patches] Change in ovirt-engine[master]: engine: Fix NPE when network qos is partially provided

2013-08-28 Thread masayag
Moti Asayag has uploaded a new change for review. Change subject: engine: Fix NPE when network qos is partially provided .. engine: Fix NPE when network qos is partially provided The patch fixes NPE caused by autoboxing of a non

[Engine-patches] Change in ovirt-engine[master]: webadmin: GuideMe cluster does not pass OverrideFirewall

2013-08-28 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: webadmin: GuideMe cluster does not pass OverrideFirewall .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_ch

[Engine-patches] Change in ovirt-engine[master]: webadmin: GuideMe cluster does not pass OverrideFirewall

2013-08-28 Thread awels
Alexander Wels has posted comments on this change. Change subject: webadmin: GuideMe cluster does not pass OverrideFirewall .. Patch Set 1: Verified+1 Verified the the guide me dialog now properly sets the override firewall fla

[Engine-patches] Change in ovirt-engine[master]: webadmin: GuideMe cluster does not pass OverrideFirewall

2013-08-28 Thread awels
Alexander Wels has uploaded a new change for review. Change subject: webadmin: GuideMe cluster does not pass OverrideFirewall .. webadmin: GuideMe cluster does not pass OverrideFirewall - Fixed class cast exception in onAddHost(

[Engine-patches] Change in ovirt-engine[master]: packaging: setup: append lines once to hb_hba.conf

2013-08-28 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: append lines once to hb_hba.conf .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/18673 To unsubscribe, visit http://gerrit

[Engine-patches] Change in ovirt-engine[master]: packaging: setup: append lines once to hb_hba.conf

2013-08-28 Thread Alon Bar-Lev
Alon Bar-Lev has uploaded a new change for review. Change subject: packaging: setup: append lines once to hb_hba.conf .. packaging: setup: append lines once to hb_hba.conf Change-Id: I74d80fe6eed1f0eca431d83ba7128950862f8dc6 Sig

[Engine-patches] [oVirt Jenkins] ovirt_engine_gwt_admin - Build # 5062 - Fixed!

2013-08-28 Thread Jenkins ci oVirt Server
Project: http://jenkins.ovirt.org/job/ovirt_engine_gwt_admin/ Build: http://jenkins.ovirt.org/job/ovirt_engine_gwt_admin/5062/ Build Number: 5062 Build Status: Fixed Triggered By: Started by upstream project "ovirt_engine_gwt_user" build number 4,893 - Change

[Engine-patches] [oVirt Jenkins] ovirt_engine_update_db_multiple_os - Build # 1949 - Fixed!

2013-08-28 Thread Jenkins ci oVirt Server
Project: http://jenkins.ovirt.org/job/ovirt_engine_update_db_multiple_os/ Build: http://jenkins.ovirt.org/job/ovirt_engine_update_db_multiple_os/1949/ Build Number: 1949 Build Status: Fixed Triggered By: Started by an SCM change - Changes Since Last Success: -

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: remove unnecessary DocsURL config

2013-08-28 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: userportal, webadmin: remove unnecessary DocsURL config .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_che

[Engine-patches] Change in ovirt-engine[master]: packaging: setup: saving memcheck parameter to answer file

2013-08-28 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: saving memcheck parameter to answer file .. Patch Set 2: (2 comments) File packaging/setup

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: remove unnecessary DocsURL config

2013-08-28 Thread ecohen
Einav Cohen has submitted this change and it was merged. Change subject: userportal, webadmin: remove unnecessary DocsURL config .. userportal, webadmin: remove unnecessary DocsURL config Removed the DocsURL config parameter an

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: remove unnecessary DocsURL config

2013-08-28 Thread ecohen
Einav Cohen has posted comments on this change. Change subject: userportal, webadmin: remove unnecessary DocsURL config .. Patch Set 4: Verified+1 Code-Review+2 -- To view, visit http://gerrit.ovirt.org/18152 To unsubscribe, v

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: brand 404 error pages.

2013-08-28 Thread gshereme
Greg Sheremeta has posted comments on this change. Change subject: userportal,webadmin: brand 404 error pages. .. Patch Set 6: -Verified Code-Review+1 -- To view, visit http://gerrit.ovirt.org/18196 To unsubscribe, visit http:

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: brand 404 error pages.

2013-08-28 Thread gshereme
Greg Sheremeta has posted comments on this change. Change subject: userportal,webadmin: brand 404 error pages. .. Patch Set 6: Verified+1 (2 comments) File backend/manager/

[Engine-patches] Change in ovirt-engine[master]: packaging: setup: saving memcheck parameter to answer file

2013-08-28 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: saving memcheck parameter to answer file .. Patch Set 2: The answer file is partial list of queries we ask user. There is no problem to add any

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: remove unnecessary DocsURL config

2013-08-28 Thread emesika
Eli Mesika has posted comments on this change. Change subject: userportal, webadmin: remove unnecessary DocsURL config .. Patch Set 3: Code-Review+1 DB OK -- To view, visit http://gerrit.ovirt.org/18152 To unsubscribe, visit

[Engine-patches] [oVirt Jenkins] ovirt_engine_update_db_multiple_os » fedora18 - Build # 1948 - Fixed!

2013-08-28 Thread Jenkins ci oVirt Server
Project: http://jenkins.ovirt.org/job/ovirt_engine_update_db_multiple_os/./label=fedora18/ Build: http://jenkins.ovirt.org/job/ovirt_engine_update_db_multiple_os/./label=fedora18/1948/ Build Number: 1948 Build Status: Fixed Triggered By: Started by upstream project "ovirt_engine_update_db_mult

[Engine-patches] [oVirt Jenkins] ovirt-engine_create_rpms_quick - Build # 412 - Failure!

2013-08-28 Thread Jenkins ci oVirt Server
Project: http://jenkins.ovirt.org/job/ovirt-engine_create_rpms_quick/ Build: http://jenkins.ovirt.org/job/ovirt-engine_create_rpms_quick/412/ Build Number: 412 Build Status: Failure Triggered By: Started by an SCM change - Changes Since Last Success: -

[Engine-patches] Change in ovirt-engine[master]: packaging: setup: saving memcheck parameter to answer file

2013-08-28 Thread alourie
Alex Lourie has posted comments on this change. Change subject: packaging: setup: saving memcheck parameter to answer file .. Patch Set 2: Verified+1 Ran with patch, the parameter was saved in the answerfile. Ran with that answ

[Engine-patches] Change in ovirt-engine[master]: core: cleanup in MoveOrCopyDiskCommand

2013-08-28 Thread sgotliv
Sergey Gotliv has posted comments on this change. Change subject: core: cleanup in MoveOrCopyDiskCommand .. Patch Set 4: Code-Review+1 Arik, why "cache" prefix is better than it was before. According to that, we need call each

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: frontend refactor phase 2

2013-08-28 Thread awels
Alexander Wels has posted comments on this change. Change subject: userportal,webadmin: frontend refactor phase 2 .. Patch Set 6: Verified+1 -- To view, visit http://gerrit.ovirt.org/17356 To unsubscribe, visit http://gerrit.o

[Engine-patches] Change in ovirt-engine[master]: webadmin: Handler cleanup in ModelListTreeViewModel

2013-08-28 Thread awels
Alexander Wels has posted comments on this change. Change subject: webadmin: Handler cleanup in ModelListTreeViewModel .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/18667 To unsubscribe, visit http://

[Engine-patches] Change in ovirt-engine[master]: webadmin: avoid disconnect server on attach domain

2013-08-28 Thread sgotliv
Sergey Gotliv has posted comments on this change. Change subject: webadmin: avoid disconnect server on attach domain .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/18649 To unsubscribe, visit http://ge

[Engine-patches] Change in ovirt-engine[master]: webadmin: allow nested tags more than 2 levels deep

2013-08-28 Thread awels
Alexander Wels has posted comments on this change. Change subject: webadmin: allow nested tags more than 2 levels deep .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/18610 To unsubscribe, visit http://

[Engine-patches] Change in ovirt-engine[master]: core: add failCanDoAction method with variable replacements

2013-08-28 Thread sgotliv
Sergey Gotliv has posted comments on this change. Change subject: core: add failCanDoAction method with variable replacements .. Patch Set 5: Do we still need original failCanDo... method? -- To view, visit http://gerrit.ovir

[Engine-patches] [oVirt Jenkins] ovirt_engine_gwt_user - Build # 4892 - Failure!

2013-08-28 Thread Jenkins ci oVirt Server
Project: http://jenkins.ovirt.org/job/ovirt_engine_gwt_user/ Build: http://jenkins.ovirt.org/job/ovirt_engine_gwt_user/4892/ Build Number: 4892 Build Status: Failure Triggered By: Started by an SCM change, Started by an SCM change - Changes Since Last Success:

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: remove unnecessary DocsURL config

2013-08-28 Thread gshereme
Greg Sheremeta has posted comments on this change. Change subject: userportal, webadmin: remove unnecessary DocsURL config .. Patch Set 2: (1 comment) File packaging/dbscrip

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: remove unnecessary DocsURL config

2013-08-28 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: userportal, webadmin: remove unnecessary DocsURL config .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_che

[Engine-patches] Change in ovirt-engine[master]: engine: [DRAFT] created FaviconServlet for branding

2013-08-28 Thread gshereme
Greg Sheremeta has abandoned this change. Change subject: engine: [DRAFT] created FaviconServlet for branding .. Abandoned this was a draft -- To view, visit http://gerrit.ovirt.org/18200 To unsubscribe, visit http://gerrit.o

[Engine-patches] [oVirt Jenkins] ovirt_engine_gwt_admin - Build # 5061 - Failure!

2013-08-28 Thread Jenkins ci oVirt Server
Project: http://jenkins.ovirt.org/job/ovirt_engine_gwt_admin/ Build: http://jenkins.ovirt.org/job/ovirt_engine_gwt_admin/5061/ Build Number: 5061 Build Status: Failure Triggered By: Started by upstream project "ovirt_engine_gwt_user" build number 4,891 - Chan

[Engine-patches] Change in ovirt-engine[master]: userportal, webadmin: remove unnecessary DocsURL config

2013-08-28 Thread gshereme
Greg Sheremeta has posted comments on this change. Change subject: userportal, webadmin: remove unnecessary DocsURL config .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.ovirt.org/18152 To unsubscribe, visit http:/

[Engine-patches] Change in ovirt-engine[master]: webadmin: move-copy disk - update quota availability

2013-08-28 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: webadmin: move-copy disk - update quota availability .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/ovirt_engine_sanity_compile_checks

  1   2   3   4   5   6   >