Allon Mureinik has posted comments on this change. Change subject: core: failCanDoAction method with variable replacements ......................................................................
Patch Set 6: Code-Review+1 (2 comments) .................................................... Commit Message Line 5: CommitDate: 2013-08-29 02:43:34 -0400 Line 6: Line 7: core: failCanDoAction method with variable replacements Line 8: Line 9: CommandBase#failCanDoAction can now get additional variable replacements. That way we don't need to call AddCanDoActionMessage only to set the variable replacements. please keep your lines under 72 characters. you should have a \n after "variable" Line 10: Line 11: Change-Id: I57dc350f507db43db2ddd47e835eca67ea96b4ed .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java Line 1922: getReturnValue().getCanDoActionMessages().add(message.name()); Line 1923: } Line 1924: Line 1925: /** Line 1926: * Add validation message plus variable replacements and return false. consider using "with" instead of "plus" Line 1927: * Line 1928: * @param message the message to add Line 1929: * @param variableReplacements variable replacements Line 1930: * @return false always -- To view, visit http://gerrit.ovirt.org/18006 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I57dc350f507db43db2ddd47e835eca67ea96b4ed Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgot...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
