Allon Mureinik has posted comments on this change.
Change subject: core,restapi: attach detach storage connections
......................................................................
Patch Set 21: Code-Review+2
(1 comment)
Backend looks ok.
Giving +2 to the entire patch based on Michael's +1 on the REST part.
Daniel - please fix the comment and verify so this can be merged.
....................................................
Commit Message
Line 10: for storage domains.
Line 11:
Line 12: Core - new commands:
Line 13: * AttachStorageConnectionToStorageDomainCommand
Line 14: (support existing/floating connections)
missing a space here, to align "(" under "A"
Line 15: * DetachStorageConnectionFromStorageDomainCommand
Line 16:
Line 17: REST:
Line 18: * Attach:
--
To view, visit http://gerrit.ovirt.org/17864
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I319bc9f51c81e2df0c7ed3b3338fcd7b4783fe84
Gerrit-PatchSet: 21
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Alissa Bonas <abo...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Cheryn Tan <cheryn...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
