Alexander Wels has uploaded a new change for review.

Change subject: webadmin: GuideMe cluster does not pass OverrideFirewall
......................................................................

webadmin: GuideMe cluster does not pass OverrideFirewall

- Fixed class cast exception in onAddHost()
- Added passing OverrideFirewall in onAddHost()

Change-Id: I8b9c2c57ffc2be7fa5a7e57675b4c82d5c789ae6
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=998938
Signed-off-by: Alexander Wels <aw...@redhat.com>
---
M 
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterGuideModel.java
1 file changed, 4 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/74/18674/1

diff --git 
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterGuideModel.java
 
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterGuideModel.java
index e3f1741..91192f4 100644
--- 
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterGuideModel.java
+++ 
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterGuideModel.java
@@ -281,8 +281,9 @@
                         dataCenter = (StoragePool) returnValue;
 
                         boolean isMultiHostDC = dataCenter.getStorageType() == 
StorageType.LOCALFS;
-                        if (isMultiHostDC)
+                        if (isMultiHostDC) {
                             model.setMultiSelection(false);
+                        }
 
                         setWindow(model);
                         model.getCluster().setItems(clusters);
@@ -467,7 +468,7 @@
         host.setVdsName((String) model.getName().getEntity());
         host.setHostName((String) model.getHost().getEntity());
         host.setPort((Integer) model.getPort().getEntity());
-        host.setSshPort((Integer) model.getAuthSshPort().getEntity());
+        host.setSshPort(Integer.valueOf((String) 
model.getAuthSshPort().getEntity()));
         host.setSshUsername(model.getUserName().getEntity().toString());
         
host.setSshKeyFingerprint(model.getFetchSshFingerprint().getEntity().toString());
         host.setVdsGroupId(((VDSGroup) 
model.getCluster().getSelectedItem()).getId());
@@ -486,7 +487,6 @@
         host.setPmSecondaryPassword((String) 
model.getPmSecondaryPassword().getEntity());
         host.setPmSecondaryType((String) 
model.getPmSecondaryType().getSelectedItem());
         host.setPmSecondaryOptionsMap(model.getPmSecondaryOptionsMap());
-
         // Save other PM parameters.
         host.setpm_enabled((Boolean) model.getIsPm().getEntity());
         host.setPmSecondaryConcurrent((Boolean) 
model.getPmSecondaryConcurrent().getEntity());
@@ -498,6 +498,7 @@
         if (model.getUserPassword().getEntity() != null) {
             vdsActionParams.setPassword((String) 
model.getUserPassword().getEntity());
         }
+        vdsActionParams.setOverrideFirewall((Boolean) 
model.getOverrideIpTables().getEntity());
         vdsActionParams.setRebootAfterInstallation(((VDSGroup) 
model.getCluster().getSelectedItem()).supportsVirtService());
 
         model.startProgress(null);


-- 
To view, visit http://gerrit.ovirt.org/18674
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8b9c2c57ffc2be7fa5a7e57675b4c82d5c789ae6
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <aw...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to