Greg Sheremeta has posted comments on this change.
Change subject: userportal,webadmin: brand 404 error pages.
......................................................................
Patch Set 6: Verified+1
(2 comments)
....................................................
File
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/servlet/BrandingFilter.java
Line 55: }
Line 56: List<BrandingTheme> brandingThemes =
brandingManager.getBrandingThemes();
Line 57: request.setAttribute(THEMES_KEY, brandingThemes);
Line 58: // Load the appropriate resource bundle with the right locale.
Line 59: ResourceBundle bundle =
ResourceBundle.getBundle("BrandingBundle", userLocale,
should "BrandingBundle" be a constant?
Line 60: BrandingResourceBundle.getBrandingControl(BLANK));
Line 61: // Pass the loaded resource bundle to the jsp.
Line 62: Config.set(request, Config.FMT_LOCALIZATION_CONTEXT, new
LocalizationContext(bundle, userLocale));
Line 63: chain.doFilter(request, response);
....................................................
File packaging/branding/ovirt.brand/messages.properties
Line 55:
Line 56: #404 error page
Line 57: obrand.pagenotfound.header.main=
Line 58: obrand.pagenotfound.page_not_found=Page not found.
Line 59: obrand.pagenotfound.link=Press here to continue.
Click?
--
To view, visit http://gerrit.ovirt.org/18196
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3b0406ab6dea4a2cacebd4ad6e62c8bb7a0d44c0
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <aw...@redhat.com>
Gerrit-Reviewer: Alexander Wels <aw...@redhat.com>
Gerrit-Reviewer: Einav Cohen <eco...@redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
