Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: saving memcheck parameter to answer file ......................................................................
Patch Set 3: (2 comments) .................................................... File packaging/setup/ovirt_engine_setup/constants.py Line 768: Line 769: @osetupattrs( Line 770: answerfile=True, Line 771: ) Line 772: def LOW_MEMORY_INSTALL(self): So what is _INSTALL? Maybe IGNORE_LOW_MEMORY_CHECK? Line 773: return 'OVESETUP_SYSTEM/lowMemoryInstall' Line 774: MEMCHECK_MINIMUM_MB = 'OVESETUP_SYSTEM/memCheckMinimumMB' Line 775: MEMCHECK_RECOMMENDED_MB = 'OVESETUP_SYSTEM/memCheckRecommendedMB' Line 776: .................................................... File packaging/setup/plugins/ovirt-engine-setup/system/memcheck.py Line 132: satisfied and Line 133: self.environment[ Line 134: osetupcons.SystemEnv.LOW_MEMORY_INSTALL Line 135: ] Line 136: ): What confusing is the naming you chose. if not ignore_check and not satisfied ? Line 137: self.environment[ Line 138: osetupcons.SystemEnv.LOW_MEMORY_INSTALL Line 139: ] = dialog.queryBoolean( Line 140: dialog=self.dialog, -- To view, visit http://gerrit.ovirt.org/18669 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I351b129c396d34fb1def8a8ddd1180e21aeeab14 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alou...@redhat.com> Gerrit-Reviewer: Alex Lourie <alou...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
