Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: saving memcheck parameter to answer file ......................................................................
Patch Set 2: (2 comments) .................................................... File packaging/setup/plugins/ovirt-engine-setup/system/memcheck.py Line 94 Line 95 Line 96 Line 97 Line 98 So it is quite confusing specifying None here... the default should be True, and remove the interactive logic? Line 130 Line 131 Line 132 Line 133 Line 134 should be: self.environment[osetupcons.SystemEnv.MEMCHECK_ENABLED] = dialog.query... -- To view, visit http://gerrit.ovirt.org/18669 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I351b129c396d34fb1def8a8ddd1180e21aeeab14 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alou...@redhat.com> Gerrit-Reviewer: Alex Lourie <alou...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
