Yedidyah Bar David has posted comments on this change. Change subject: packaging: setup: Added default firewall rules for postgres ......................................................................
Patch Set 4: Alex, this seems to me to add the port twice when iptables is chosen. Once in the template itself and once from adding the selected port in ovirt-engine-setup/network/firewall_manager.py: _process_templates -> _createIptablesConfig -> _parseFirewalld. Am I wrong? If not, I think it should be removed from the template. -- To view, visit http://gerrit.ovirt.org/16800 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie05911e70ac6a93416182116ae04daec95f59ee7 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alou...@redhat.com> Gerrit-Reviewer: Alex Lourie <alou...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Moran Goldboim <mgold...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
