Alon Bar-Lev has posted comments on this change.
Change subject: config: avoid to change existing configuration files
..
Patch Set 3: (1 inline comment)
File src/__main__.py
Arik Hadas has posted comments on this change.
Change subject: core: add get*Type to template DAO
..
Patch Set 10: (1 inline comment)
File
backend/manager/modules/dal/src/ma
Frank Kobzik has posted comments on this change.
Change subject: novnc: log file is actually trace file
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/15383
To unsubscr
Sandro Bonazzola has posted comments on this change.
Change subject: config: avoid to change existing configuration files
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/15366
To unsubscribe, visit http://ger
Sandro Bonazzola has posted comments on this change.
Change subject: config: avoid to change existing configuration files
..
Patch Set 2: (1 inline comment)
File src/__main__
Arik Hadas has posted comments on this change.
Change subject: core: Add Image and Instance type interfaces
..
Patch Set 12: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/12279
To uns
Arik Hadas has posted comments on this change.
Change subject: core: add support for instance type
..
Patch Set 11: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/12278
To unsubscribe,
Elad Ben Aharon has posted comments on this change.
Change subject: core: move image group command
..
Patch Set 9: Verified; Looks good to me, but someone else must approve
checked:
- that parameters are being sent like should
Elad Ben Aharon has posted comments on this change.
Change subject: core: move image group command
..
Patch Set 9: No score; No score
testing more scenarios
--
To view, visit http://gerrit.ovirt.org/13042
To unsubscribe, visit
Tomas Jelinek has posted comments on this change.
Change subject: webadmin: Disable select quota on edit vm-pool
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/15320
To unsubscribe, visit h
Oved Ourfali has posted comments on this change.
Change subject: WIP Support foreman SSL provider
..
Patch Set 6:
Yair - I documented it in the code.
Not sure we should open any BZ, as not sure there is a real issue.
Documenta
Shubhendu Tripathi has posted comments on this change.
Change subject: gluster: Added queries for service list
..
Patch Set 16:
Marked the constructors as public
--
To view, visit http://gerrit.ovirt.org/15122
To unsubscribe,
Yair Zaslavsky has posted comments on this change.
Change subject: WIP Support foreman SSL provider
..
Patch Set 6:
Regarding previous comments,
I suggest that if due to "tech preview" and time limitations you cannot address
Project: http://jenkins.ovirt.org/job/ovirt-engine_create_rpms/
Build: http://jenkins.ovirt.org/job/ovirt-engine_create_rpms/1010/
Build Number: 1010
Build Status: Still Failing
Triggered By: Started by timer
-
Changes Since Last Success:
-
Project: http://jenkins.ovirt.org/job/ovirt-engine_create_rpms/
Build: http://jenkins.ovirt.org/job/ovirt-engine_create_rpms/1009/
Build Number: 1009
Build Status: Still Failing
Triggered By: Started by timer
-
Changes Since Last Success:
-
Giuseppe Vallarelli has posted comments on this change.
Change subject: Added the hook dispatcher
..
Patch Set 2: I would prefer that you didn't submit this
(7 inline comments)
Except for the few trivial comments above, looks
Federico Simoncelli has posted comments on this change.
Change subject: engine: Add keystone support in Openstack Network
..
Patch Set 1: (1 inline comment)
File
backend/man
Eli Mesika has posted comments on this change.
Change subject: core: Introducing Batch updates to DAOs
..
Patch Set 9: (1 inline comment)
File
backend/manager/modules/dal/sr
Alexander Wels has uploaded a new change for review.
Change subject: userportal,webadmin: Frontend refactor[WIP]
..
userportal,webadmin: Frontend refactor[WIP]
- Minor refactor to allow unit testing.
Change-Id: I3dae5a455ad1666
Einav Cohen has posted comments on this change.
Change subject: findbugs: Constants: dont use class name as the same as the
class you implement
..
Patch Set 4:
> Constants_.properties files should be renamed as well (for I18N)
Daniel Erez has posted comments on this change.
Change subject: findbugs: remove unread public or protected fields
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/15391
Daniel Erez has posted comments on this change.
Change subject: findbugs: Messages: dont use class name as the same as the
class you implement
..
Patch Set 3:
* Messages_.properties files should be renamed as well (for I18N).
Daniel Erez has posted comments on this change.
Change subject: findbugs: Constants: dont use class name as the same as the
class you implement
..
Patch Set 4:
* Constants_.properties files should be renamed as well (for I18N)
Daniel Erez has posted comments on this change.
Change subject: findbugs: remove unread fields
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/15390
To unsubscribe, visi
Daniel Erez has posted comments on this change.
Change subject: restapi: a potential NPE when a user invokes actions
..
Patch Set 1: No score
--
To view, visit http://gerrit.ovirt.org/15394
To unsubscribe, visit http://gerrit.o
Daniel Erez has posted comments on this change.
Change subject: restapi: a potential NPE when a user invokes actions
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/15394
To unsubscribe, visit http://gerrit.o
Project: http://jenkins.ovirt.org/job/ovirt-engine_create_rpms/
Build: http://jenkins.ovirt.org/job/ovirt-engine_create_rpms/1008/
Build Number: 1008
Build Status: Still Failing
Triggered By: Started by user Kiril Nesenko
-
Changes Since Last Success:
Aravinda VK has posted comments on this change.
Change subject: packaging: Second time setup without cleanup is made
configurable
..
Patch Set 2:
Alon,
Sorry for incomplete information.
Since you mentioned engine-setup2 is
Oved Ourfali has posted comments on this change.
Change subject: WIP Support foreman SSL provider
..
Patch Set 4:
Yair - please review the backend code here as well.
Still expect UI changes, but backend code is pretty much done
Oved Ourfali has posted comments on this change.
Change subject: WIP Support foreman SSL provider
..
Patch Set 3: (4 inline comments)
File
backend/manager/modules/bll/src/ma
Alon Bar-Lev has posted comments on this change.
Change subject: WIP Support foreman SSL provider
..
Patch Set 3: (4 inline comments)
File
backend/manager/modules/bll/src/ma
Oved Ourfali has posted comments on this change.
Change subject: WIP Support foreman SSL provider
..
Patch Set 3: (7 inline comments)
File
backend/manager/modules/bll/src/ma
Yair Zaslavsky has posted comments on this change.
Change subject: core: Fix findbugs to conform to mvn 3.0
..
Patch Set 10: Verified; Looks good to me, but someone else must approve
Verified using a jenkins job.
--
To view, v
Martin Beták has posted comments on this change.
Change subject: fontend: Correct host list on New Storage Domain creation
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/15397
To unsubscribe, visit http://ge
Project: http://jenkins.ovirt.org/job/ovirt-engine_create_rpms_quick/
Build: http://jenkins.ovirt.org/job/ovirt-engine_create_rpms_quick/35/
Build Number: 35
Build Status: Still Failing
Triggered By: Started by an SCM change, Started by an SCM change
-
Changes
Martin Beták has uploaded a new change for review.
Change subject: fontend: Correct host list on New Storage Domain creation
..
fontend: Correct host list on New Storage Domain creation
Only show hosts from cluster with virt-ser
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: Second time setup without cleanup is made
configurable
..
Patch Set 2:
Not sure what 'That' is... but please revisit this soon when we finish the
upg
Yair Zaslavsky has posted comments on this change.
Change subject: core: Fix findbugs to conform to mvn 3.0
..
Patch Set 9:
Correct, looks like i checked only backened. will fix that in next patch.
--
To view, visit http://ger
Juan Hernandez has posted comments on this change.
Change subject: core: Fix findbugs to conform to mvn 3.0
..
Patch Set 9:
Not sure if it is relevant, but there are several places where we are still
referencing the exclude-fi
Aravinda VK has posted comments on this change.
Change subject: packaging: Second time setup without cleanup is made
configurable
..
Patch Set 2:
Thanks Sandro and Alon.
That solves the issue then, when it(engine-setup2) wil
Omer Frenkel has posted comments on this change.
Change subject: gluster: Bll command to refresh gluster hooks in engine
..
Patch Set 1: (3 inline comments)
File
backend/man
Omer Frenkel has posted comments on this change.
Change subject: core: cleanup CreateVmVDSCommand
..
Patch Set 12: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/15118
To unsubscribe,
Omer Frenkel has posted comments on this change.
Change subject: core: restore memory from snapshot on run vm
..
Patch Set 15: (1 inline comment)
File
backend/manager/module
Daniel Erez has uploaded a new change for review.
Change subject: restapi: a potential NPE when a user invokes actions
..
restapi: a potential NPE when a user invokes actions
When a user invokes an action without sending filter=
Omer Frenkel has posted comments on this change.
Change subject: core: memory state handling on preview/commit/undo
..
Patch Set 15: (1 inline comment)
looks ok
File
backen
Maor Lipchuk has posted comments on this change.
Change subject: core: save memory state on live snapshot with memory
..
Patch Set 17: (2 inline comments)
File
backend/manag
Maor Lipchuk has posted comments on this change.
Change subject: core : update of bootable disk
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/15218
To unsubscribe, visit http://gerrit.ovir
Maor Lipchuk has posted comments on this change.
Change subject: core : update of bootable disk
..
Patch Set 1: (1 inline comment)
Commit Message
Line 7: core : update of boo
Shahar Havivi has uploaded a new change for review.
Change subject: findbugs: ignore: Unread public-protected fields
..
findbugs: ignore: Unread public-protected fields
We add to ignore list fields that we do use in reflection o
Shahar Havivi has uploaded a new change for review.
Change subject: findbugs: remove unread public or protected fields
..
findbugs: remove unread public or protected fields
findbugs reason:
UrF: Unread public/protected field (UR
Yaniv Bronhaim has posted comments on this change.
Change subject: findbugs: remove unread fields
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/15390
To unsubscribe, v
Omer Frenkel has posted comments on this change.
Change subject: core: remove memory image on remove snapshot
..
Patch Set 16: (1 inline comment)
File
backend/manager/module
Ravi Nori has posted comments on this change.
Change subject: engine: User who has manipulate_permissions can't see other
users
..
Patch Set 6: Verified
--
To view, visit http://gerrit.ovirt.org/14346
To unsubscribe, visit htt
Shahar Havivi has uploaded a new change for review.
Change subject: findbugs: remove unread fields
..
findbugs: remove unread fields
findbugs reason:
UrF: Unread field (URF_UNREAD_FIELD)
Change-Id: Ied4990cd90e58e566679851b3e2c
Omer Frenkel has posted comments on this change.
Change subject: core: save memory state on live snapshot with memory
..
Patch Set 17: (1 inline comment)
File
backend/manage
Omer Frenkel has posted comments on this change.
Change subject: core: add get*Type to template DAO
..
Patch Set 11:
changes from previous version:
added commit message
fixed DAO test, now it pass..
--
To view, visit http://
Omer Frenkel has posted comments on this change.
Change subject: core: Add Image and Instance type interfaces
..
Patch Set 12:
changes from previous version:
added commit message
interfaces now extend Nameable
added doc to I
Omer Frenkel has posted comments on this change.
Change subject: core: add support for instance type
..
Patch Set 11:
changes from previous version:
added commit message
fixed DAO-test failurs: update and delete template does n
David Caro has uploaded a new change for review.
Change subject: Added the common libraries for the hooks to use
..
Added the common libraries for the hooks to use
- bz.sh: functions to query bugzilla
- conf.sh: configuration
Omer Frenkel has posted comments on this change.
Change subject: core: add get*Type to template DAO
..
Patch Set 10: (1 inline comment)
File
backend/manager/modules/dal/src/
Omer Frenkel has posted comments on this change.
Change subject: add Image and Instance type interfaces
..
Patch Set 11: (2 inline comments)
File
backend/manager/modules/com
Doron Fediuck has posted comments on this change.
Change subject: engine: rest cleanup [wip]
..
Patch Set 1: Looks good to me, but someone else must approve
Good catch!
--
To view, visit http://gerrit.ovirt.org/15363
To unsubs
Sandro Bonazzola has posted comments on this change.
Change subject: packaging: Second time setup without cleanup is made
configurable
..
Patch Set 2:
> I don't think the current engine-setup is designed to be re-entrant.
> S
Project: http://jenkins.ovirt.org/job/ovirt-engine_create_rpms_quick/
Build: http://jenkins.ovirt.org/job/ovirt-engine_create_rpms_quick/34/
Build Number: 34
Build Status: Failure
Triggered By: Started by an SCM change
-
Changes Since Last Success:
---
Project: http://jenkins.ovirt.org/job/ovirt_engine_update_db_multiple_os/
Build: http://jenkins.ovirt.org/job/ovirt_engine_update_db_multiple_os/1108/
Build Number: 1108
Build Status: Failure
Triggered By: Started by an SCM change
-
Changes Since Last Success:
Alissa Bonas has posted comments on this change.
Change subject: core: add validation to AddStorageServerConnection
..
Patch Set 2: Fails
works but needs more unitests
--
To view, visit http://gerrit.ovirt.org/15388
To unsubsc
Alissa Bonas has uploaded a new change for review.
Change subject: core: add validation to AddStorageServerConnection
..
core: add validation to AddStorageServerConnection
Work in progress...
Prevent addition of a new connection
Maor Lipchuk has posted comments on this change.
Change subject: core: Fix typo
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/15357
To unsubscribe, visit http://gerrit.ovirt.org/
Frank Kobzik has posted comments on this change.
Change subject: novnc: use service debug instead of configuration
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/15387
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: Fix typo
..
core: Fix typo
change Compatilibily to Compatibility in getCompatilibilyVersion at
ClusterUtils class.
Change-Id: I4a1e956d453d35b4cd5
Alon Bar-Lev has posted comments on this change.
Change subject: novnc: use service debug instead of configuration
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/15387
To unsubscribe, visit http://gerrit.ovi
Alon Bar-Lev has uploaded a new change for review.
Change subject: novnc: use service debug instead of configuration
..
novnc: use service debug instead of configuration
Change-Id: I8cf66fcbd19a72bd3ffebb82984124dc9e51d83c
Signe
David Caro has uploaded a new change for review.
Change subject: Added the hok dispatcher
..
Added the hok dispatcher
This script is in charge of selecting which hooks will run and managing
the execution flow
Change-Id: Iada3d1
Keith Robertson has posted comments on this change.
Change subject: config: avoid to change existing configuration files
..
Patch Set 2: (1 inline comment)
File src/__main__.
Laszlo Hornyak has posted comments on this change.
Change subject: core: remove vdsSelector CheckDestinationFirst
..
Patch Set 5: Looks good to me, but someone else must approve
looks good from firefox, will check it over just
Alon Bar-Lev has posted comments on this change.
Change subject: novnc: log file is actually trace file
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/15383
To unsubscribe, visit http://gerrit.ovirt.org/sett
Alon Bar-Lev has posted comments on this change.
Change subject: novnc: log file is actually trace file
..
Patch Set 2:
> Just a question - what happened to LOG_VERBOSE?
Sorry... you are right.
Although this verbose will not
Alona Kaplan has posted comments on this change.
Change subject: core: Adds custom properties to VmNetworkInterface
..
Patch Set 22: No score
--
To view, visit http://gerrit.ovirt.org/14815
To unsubscribe, visit http://gerrit.o
Sahina Bose has posted comments on this change.
Change subject: tools: expose GlusterRefreshRateHooks in engine-config
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/15251
To unsubscribe, visit http://gerrit
Alona Kaplan has posted comments on this change.
Change subject: core: Adds custom properties to VmNetworkInterface
..
Patch Set 22: Verified
--
To view, visit http://gerrit.ovirt.org/14815
To unsubscribe, visit http://gerrit.o
Alona Kaplan has posted comments on this change.
Change subject: webadmin: adding custom properties to vnic dialog
..
Patch Set 18: Verified
--
To view, visit http://gerrit.ovirt.org/15020
To unsubscribe, visit http://gerrit.ov
Yair Zaslavsky has posted comments on this change.
Change subject: tools: expose GlusterRefreshRateHooks in engine-config
..
Patch Set 2: Looks good to me, approved
Sahina, please verify and mark as verified.
--
To view, visit
Alona Kaplan has posted comments on this change.
Change subject: restapi: Cannot remove custom properties from a vm
..
Patch Set 10: Verified
--
To view, visit http://gerrit.ovirt.org/15137
To unsubscribe, visit http://gerrit.
Yair Zaslavsky has posted comments on this change.
Change subject: tools: expose GlusterRefreshRateHooks in engine-config
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/15251
To unsubscribe
Alona Kaplan has posted comments on this change.
Change subject: restapi: adding custom properties to vm interface
..
Patch Set 13: Verified
--
To view, visit http://gerrit.ovirt.org/15101
To unsubscribe, visit http://gerrit.ov
Shahar Havivi has uploaded a new change for review.
Change subject: findbugs: Consider making the field static
..
findbugs: Consider making the field static
This class contains an instance final field that is initialized to a
co
Sahina Bose has posted comments on this change.
Change subject: gluster: bll command to start/stop/restart service
..
Patch Set 4: (5 inline comments)
File
backend/manager/m
Yair Zaslavsky has posted comments on this change.
Change subject: gluster: bll command to start/stop/restart service
..
Patch Set 4: (3 inline comments)
File
backend/manage
Yair Zaslavsky has posted comments on this change.
Change subject: gluster: bll command to start/stop/restart service
..
Patch Set 4: (1 inline comment)
You're introducing here a change to SP (you add two new functions) - why n
Eli Mesika has submitted this change and it was merged.
Change subject: core: fix upgrade of vm_devices for 3.1
..
core: fix upgrade of vm_devices for 3.1
on patch Ic83725ad the execution of script 03_01_0440 was commented out,
Eli Mesika has posted comments on this change.
Change subject: core: fix upgrade of vm_devices for 3.1
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/15379
To unsubscribe, visit h
Yair Zaslavsky has posted comments on this change.
Change subject: gluster: VDS comand for start/stop of services
..
Patch Set 8: (1 inline comment)
File
backend/manager/mod
Yair Zaslavsky has posted comments on this change.
Change subject: gluster: Added query for gluster cluster service
..
Patch Set 5: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/15241
Yair Zaslavsky has posted comments on this change.
Change subject: gluster: Added queries for service list
..
Patch Set 14: (2 inline comments)
File
backend/manager/modules/
Frank Kobzik has posted comments on this change.
Change subject: novnc: override get_target instead of new_client
..
Patch Set 1:
I'll do that.
--
To view, visit http://gerrit.ovirt.org/15384
To unsubscribe, visit http://gerri
Frank Kobzik has posted comments on this change.
Change subject: novnc: log file is actually trace file
..
Patch Set 1:
Just a question - what happened to LOG_VERBOSE?
--
To view, visit http://gerrit.ovirt.org/15383
To unsubsc
Yair Zaslavsky has posted comments on this change.
Change subject: engine: updating GlusterService entities and enum
..
Patch Set 4: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/1536
Eli Mesika has posted comments on this change.
Change subject: gluster: Added queries for service list
..
Patch Set 14: Looks good to me, but someone else must approve
(1 inline comment)
Minor comment : please remove TABs
...
Frank Kobzik has posted comments on this change.
Change subject: novnc: cleanup defaults file
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/15382
To unsubscribe, visit
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: Second time setup without cleanup is made
configurable
..
Patch Set 2:
engine-setup-2 is at same place of engine-setup, it is a complete re-write,
wi
1 - 100 of 177 matches
Mail list logo
