Yair Zaslavsky has posted comments on this change.
Change subject: gluster: Added queries for service list
......................................................................
Patch Set 14: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterServerServicesByClusterIdQuery.java
Line 20: } else {
Line 21: serviceList =
getGlusterServerServiceDao().getByClusterIdAndServiceType(getParameters().getId(),
getParameters().getServiceType());
Line 22: }
Line 23:
Line 24: if(serviceList != null && serviceList.size() > 0) {
Question (matter of choise) - don't you prefer to set it anyway?
if serverList is null or empty,
setReurnValue will contain a null or empty list -what's the problem with that?
Line 25: getQueryReturnValue().setReturnValue(serviceList);
Line 26: }
Line 27: }
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterServerServicesByServerIdQuery.java
Line 20: } else {
Line 21: serviceList =
getGlusterServerServiceDao().getByServerIdAndServiceType(getParameters().getId(),
getParameters().getServiceType());
Line 22: }
Line 23:
Line 24: if(serviceList != null && serviceList.size() > 0) {
Same as before.
Line 25: getQueryReturnValue().setReturnValue(serviceList);
Line 26: }
Line 27: }
--
To view, visit http://gerrit.ovirt.org/15122
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e027a49a5a5a49ff37ef78433a96b81add3f8d4
Gerrit-PatchSet: 14
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shubhendu Tripathi <shtri...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
