Keith Robertson has posted comments on this change.
Change subject: config: avoid to change existing configuration files
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File src/__main__.py
Line 328: _(
Line 329: 'The deprecated configuration key rhevm has
been '
Line 330: 'found in configuration files.\n'
Line 331: 'Please update your configuration changing
rhevm '
Line 332: 'to engine'
A few grammar errors fixed and the path to the file supplied. Try to provide
the actual file in error, half the time people have no idea which file is the
source of the problem. So be explicit:
'A deprecated configuration key has been found. Please remove the deprecated
key, \'rhevm\', from %s' % (conf_file_here)
Line 333: )
Line 334: )
Line 335: cp.remove_option('LogCollector', 'rhevm')
Line 336:
--
To view, visit http://gerrit.ovirt.org/15366
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I55c707424524826235f1faba52c0fafd72a27300
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-log-collector
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Alex Lourie <alou...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Keith Robertson <krobe...@redhat.com>
Gerrit-Reviewer: Kiril Nesenko <knese...@redhat.com>
Gerrit-Reviewer: Moran Goldboim <mgold...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
