Arik Hadas has posted comments on this change.
Change subject: core: add get*Type to template DAO
......................................................................
Patch Set 10: (1 inline comment)
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmTemplateDAODbFacadeImpl.java
Line 46: if (result != null && result.getTemplateType() !=
TemplateType.IMAGE_TYPE) {
Line 47: result = null;
Line 48: }
Line 49: return result;
Line 50: }
yeah different DAO seems like an overkill
I suggested something like:
public ImageType extends .... TemplateType { ... }
public InstanceType extends .... TemplateType { ... }
public <T extends TemplateType> T get(Class<T>, Guid id) {
VmTemplate result = get(id);
if (result != null && result.getTemplateType() != T) {
result = null;
}
return result;
}
Line 51:
Line 52: @Override
Line 53: public VmTemplate get(Guid id, Guid userID, boolean isFiltered) {
Line 54: return getCallsHandler().executeRead("GetVmTemplateByVmtGuid",
--
To view, visit http://gerrit.ovirt.org/12280
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic9f0eef1e61b51cc941b8dd9403f5733a69f9dfc
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Arik Hadas <aha...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
