Shahar Havivi has uploaded a new change for review.
Change subject: findbugs: remove unread public or protected fields
......................................................................
findbugs: remove unread public or protected fields
findbugs reason:
UrF: Unread public/protected field (URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD)
Change-Id: Ib320ef93c723bdee810fd27ebfd306c890b1d11e
Signed-off-by: Shahar Havivi <shav...@redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveSnapshotTaskHandler.java
M
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendSnapshotElementsResource.java
M
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsStatsAndStatusXmlRpc.java
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/tree/AbstractSubTabActionTree.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/AddDataCenterRM.java
6 files changed, 0 insertions(+), 15 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/91/15391/1
diff --git
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java
index 37b52a2..c885649 100644
---
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java
+++
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java
@@ -80,7 +80,6 @@
protected HashMap<Guid, DiskImage> diskInfoDestinationMap;
protected Map<Guid, StorageDomain> destStorages = new HashMap<Guid,
StorageDomain>();
protected Map<Guid, List<DiskImage>> storageToDisksMap;
- protected String newMac = "";
/**
* A list of the new disk images which were saved for the VM.
diff --git
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveSnapshotTaskHandler.java
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveSnapshotTaskHandler.java
index bdd1c08..dc4d0f3 100644
---
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveSnapshotTaskHandler.java
+++
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveSnapshotTaskHandler.java
@@ -18,13 +18,10 @@
import org.ovirt.engine.core.common.businessentities.ImageStatus;
import org.ovirt.engine.core.common.businessentities.Snapshot.SnapshotType;
import org.ovirt.engine.core.dal.dbbroker.DbFacade;
-import org.ovirt.engine.core.utils.log.Log;
-import org.ovirt.engine.core.utils.log.LogFactory;
public class LiveSnapshotTaskHandler implements SPMAsyncTaskHandler {
private final TaskHandlerCommand<? extends LiveMigrateVmDisksParameters>
enclosingCommand;
- protected Log log = LogFactory.getLog(getClass());
public LiveSnapshotTaskHandler(TaskHandlerCommand<? extends
LiveMigrateVmDisksParameters> enclosingCommand) {
this.enclosingCommand = enclosingCommand;
diff --git
a/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendSnapshotElementsResource.java
b/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendSnapshotElementsResource.java
index 03df99e..102a212 100644
---
a/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendSnapshotElementsResource.java
+++
b/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendSnapshotElementsResource.java
@@ -3,11 +3,9 @@
public abstract class BackendSnapshotElementsResource{
protected BackendSnapshotResource parent;
- protected String vmId;
public BackendSnapshotElementsResource(BackendSnapshotResource parent,
String vmId) {
super();
this.parent = parent;
- this.vmId = vmId;
}
}
diff --git
a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsStatsAndStatusXmlRpc.java
b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsStatsAndStatusXmlRpc.java
index 1b7ef51..af7f671 100644
---
a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsStatsAndStatusXmlRpc.java
+++
b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsStatsAndStatusXmlRpc.java
@@ -4,15 +4,10 @@
public final class IrsStatsAndStatusXmlRpc extends StatusReturnForXmlRpc {
private static final String STATS = "stats";
- // We are ignoring missing fields after the status, because on failure it
is
- // not sent.
- // [XmlRpcMissingMapping(MappingAction.Ignore), XmlRpcMember("stats")]
- public Map<String, Object> stats;
@SuppressWarnings("unchecked")
public IrsStatsAndStatusXmlRpc(Map<String, Object> innerMap) {
super(innerMap);
- stats = (Map<String, Object>) innerMap.get(STATS);
}
}
diff --git
a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/tree/AbstractSubTabActionTree.java
b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/tree/AbstractSubTabActionTree.java
index 06a3241..b819a6d 100644
---
a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/tree/AbstractSubTabActionTree.java
+++
b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/tree/AbstractSubTabActionTree.java
@@ -49,7 +49,6 @@
protected AbstractSubTabTree<M, R, N> tree;
protected final EventBus eventBus;
- protected SearchableDetailModelProvider<?, ?, M> modelProvider;
protected final CommonApplicationResources resources;
protected final CommonApplicationConstants constants;
@@ -60,7 +59,6 @@
super(modelProvider, eventBus);
this.eventBus = eventBus;
- this.modelProvider = modelProvider;
this.resources = resources;
this.constants = constants;
diff --git
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/AddDataCenterRM.java
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/AddDataCenterRM.java
index fe4129c..1f9cefa 100644
---
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/AddDataCenterRM.java
+++
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/AddDataCenterRM.java
@@ -271,7 +271,6 @@
VdcReturnValueBase returnValue =
result.getReturnValue();
- context.removeVDSGroupReturnValue =
returnValue;
rollback5();
}
});
@@ -403,6 +402,5 @@
public VDS hostFoundById;
public VdcReturnValueBase addDataCenterReturnValue;
public VdcReturnValueBase changeVDSClusterReturnValue;
- public VdcReturnValueBase removeVDSGroupReturnValue;
}
}
--
To view, visit http://gerrit.ovirt.org/15391
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib320ef93c723bdee810fd27ebfd306c890b1d11e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shav...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
