Einav Cohen has posted comments on this change. Change subject: findbugs: Constants: dont use class name as the same as the class you implement ......................................................................
Patch Set 4: > Constants_<lang>.properties files should be renamed as well (for I18N). right. @Shahar - can you please add to this patch the renaming of all "Constants_<lang>.properties" to "UIConstants_<lang>.properties"? > @Einav - translation process should probably be modified... right again; Once this patch is merged, need to make sure that the "new" UIConstants file is pushed/pulled to/from Zanata, rather than the "old" Constants file. I will take care of that. Many thanks, Derez, for noticing and notifying! -- To view, visit http://gerrit.ovirt.org/15309 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icacd4a7a57dd174e650e9bba8674241cc2847199 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
