Maor Lipchuk has posted comments on this change.
Change subject: core: save memory state on live snapshot with memory
......................................................................
Patch Set 17: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java
Line 118:
Line 119: MemoryImageBuilder memoryImageBuilder =
createMemoryImageBuilder();
Line 120: addSnapshotToDB(createdSnapshotId, memoryImageBuilder);
Line 121: createSnapshotsForDisks(newActiveSnapshotId);
Line 122: memoryImageBuilder.build();
stand corrected
Line 123:
Line 124: if (getTaskIdList().isEmpty()) {
Line 125: getParameters().setTaskGroupSuccess(true);
Line 126: incrementVmGeneration();
Line 524: VDSReturnValue retVal =
Line 525: Backend
Line 526: .getInstance()
Line 527: .getResourceManager()
Line 528: .RunVdsCommand(
I think Liron has a point, why not moving those files already now (in this
patch)?
besides that, when handling tasks, you will need to use the commandBase#execute
for polling the tasks (See CommandBase#execute line 1188), so you should be
able to use runVdsCommand here.
Line 529: VDSCommandType.CreateImage,
Line 530: new
CreateImageVDSCommandParameters(getVm().getStoragePoolId(),
Line 531: getStorageDomainId()
Line 532: .getValue(),
--
To view, visit http://gerrit.ovirt.org/14291
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifbb28efda1b63e506233a88399488a256e6ab1c8
Gerrit-PatchSet: 17
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <aha...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Arik Hadas <aha...@redhat.com>
Gerrit-Reviewer: Liron Ar <lara...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
