Liron Aravot has posted comments on this change.
Change subject: core: prevent master version update on storage pool update
..
Patch Set 2:
Not used? i see that StoragePoolDAODbFacadeImpl.update is called from more than
10 pla
Tomas Jelinek has posted comments on this change.
Change subject: userportal: no boot from hard disk for diskless VM
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11735
To unsubscribe, vis
Alona Kaplan has posted comments on this change.
Change subject: engine: slave interfaces are being overridden
..
Patch Set 3: Looks good to me, but someone else must approve
+1 for frontend
--
To view, visit http://gerrit.ovi
Michael Kublin has posted comments on this change.
Change subject: core: prevent master version update on storage pool update
..
Patch Set 2: Do not submit
I suppose that you don't know that that query is not used anywehere
--
Michael Kublin has posted comments on this change.
Change subject: engine: Added infrastructure for providing a canDoactions in
case of locks
..
Patch Set 1: (1 inline comment)
.
Yair Zaslavsky has posted comments on this change.
Change subject: host-deploy: use tar instead of python tarfile
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11776
To unsubscribe, visit
Alon Bar-Lev has posted comments on this change.
Change subject: host-deploy: use tar instead of python tarfile
..
Patch Set 1: Verified; No score
--
To view, visit http://gerrit.ovirt.org/11776
To unsubscribe, visit http://ger
Project: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/
Build: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/3444/
Build Number: 3444
Build Status: Fixed
Triggered By: Started by upstream project "ovirt_engine" build number 4,209
-
Changes Since La
Shireesh Anjal has posted comments on this change.
Change subject: core: Add capability check for Gluster FS.
..
Patch Set 10: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/8964
To un
Shireesh Anjal has posted comments on this change.
Change subject: core: Introduce AddGlusterFsStorageDomainCommand.
..
Patch Set 9: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/8837
Shireesh Anjal has posted comments on this change.
Change subject: core: Add GlusterFS support to AsyncDataProvider
..
Patch Set 9: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/8962
Dave Chen has posted comments on this change.
Change subject: Trusted Compute Pools - Open Attestation integration with oVirt
engine proposal
..
Patch Set 2: (39 inline comments)
...
Shireesh Anjal has posted comments on this change.
Change subject: core: StorageHelper class for GlusterFS.
..
Patch Set 9: (1 inline comment)
File
backend/manager/modules/b
Alex Lourie has posted comments on this change.
Change subject: packaging: Add yum installation indication for upgrade
..
Patch Set 8: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/94
Mike Kolesnik has submitted this change and it was merged.
Change subject: core: Findbug fix of isPluggable method
..
core: Findbug fix of isPluggable method
This fixes an equals issue at isPluggable method
Change-Id: I4360ac7
Mike Kolesnik has posted comments on this change.
Change subject: core: Findbug fix of isPluggable method
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/11784
To unsubscribe, visit http://gerrit.ovirt.org/se
Mike Kolesnik has posted comments on this change.
Change subject: core: Findbug fix of isPluggable method
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11784
To unsubscribe, visit http://g
Mike Kolesnik has posted comments on this change.
Change subject: engine: Empty SetupNetworksCommand isn't sent to VDSM
..
Patch Set 1: (1 inline comment)
File
backend/manag
Yair Zaslavsky has posted comments on this change.
Change subject: core: Add capability check for Gluster FS.
..
Patch Set 10: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/8964
To un
Vered Volansky has posted comments on this change.
Change subject: core: Change vm_pools entity to VmPool
..
Patch Set 1:
In reply to Maor's suggestion, I think VmPools for an entity is a misleading
abomination. If I encounter
Yair Zaslavsky has posted comments on this change.
Change subject: engine: Added infrastructure for providing a canDoactions in
case of locks
..
Patch Set 1: (1 inline comment)
.
Yair Zaslavsky has uploaded a new change for review.
Change subject: core: Findbug fix of isPluggable method
..
core: Findbug fix of isPluggable method
This fixes an equals issue at isPluggable method
Change-Id: I4360ac7b3ccc02
Yair Zaslavsky has posted comments on this change.
Change subject: core: StorageHelper class for GlusterFS.
..
Patch Set 9: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/8834
To unsub
Chris Morrissey has abandoned this change.
Change subject: core: Added "scan" to disks resource to import clones
..
Patch Set 3: Abandoned
I've rewritten this fix and it is not in the change
http://gerrit.ovirt.org/11783
--
T
Chris Morrissey has uploaded a new change for review.
Change subject: core: Added RegisterDiskCommand and GetUnregisteredDisksQuery
..
core: Added RegisterDiskCommand and GetUnregisteredDisksQuery
I am working on a plugin for Ne
Alon Bar-Lev has submitted this change and it was merged.
Change subject: core: aggregate correctly multi-value 'after'
..
core: aggregate correctly multi-value 'after'
Change-Id: I281b22f7cf128cb2dcc2350c725f3d649fa0f7bc
Signe
Alon Bar-Lev has posted comments on this change.
Change subject: core: aggregate correctly multi-value 'after'
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11781
To unsubscribe,
Alon Bar-Lev has uploaded a new change for review.
Change subject: core: aggregate correctly multi-value 'after'
..
core: aggregate correctly multi-value 'after'
Change-Id: I281b22f7cf128cb2dcc2350c725f3d649fa0f7bc
Signed-off-by
Alon Bar-Lev has posted comments on this change.
Change subject: core: use before/after feature
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11780
To unsubscribe, visit http://g
Alon Bar-Lev has submitted this change and it was merged.
Change subject: core: use before/after feature
..
core: use before/after feature
Change-Id: I3ba635aa28c7c9c5047ea400de111dae2683fda8
Signed-off-by: Alon Bar-Lev
---
M
Alon Bar-Lev has uploaded a new change for review.
Change subject: core: use before/after feature
..
core: use before/after feature
Change-Id: I3ba635aa28c7c9c5047ea400de111dae2683fda8
Signed-off-by: Alon Bar-Lev
---
M src/plug
Alon Bar-Lev has submitted this change and it was merged.
Change subject: core: use before/after feature
..
core: use before/after feature
Change-Id: I8f377d454b2d1f3fed1bd4df6d98955258a8c64d
Signed-off-by: Alon Bar-Lev
---
M
Alon Bar-Lev has posted comments on this change.
Change subject: core: use before/after feature
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11779
To unsubscribe, visit http://g
Alon Bar-Lev has submitted this change and it was merged.
Change subject: core: context: support 'before', 'after' in sequence
..
core: context: support 'before', 'after' in sequence
Change-Id: Id560d4aac9052379442c43672d87153b
Alon Bar-Lev has posted comments on this change.
Change subject: core: context: support 'before', 'after' in sequence
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11778
To unsub
Alon Bar-Lev has posted comments on this change.
Change subject: core: context: cleanup buildSequence
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11777
To unsubscribe, visit ht
Alon Bar-Lev has submitted this change and it was merged.
Change subject: core: context: cleanup buildSequence
..
core: context: cleanup buildSequence
Change-Id: I31f95bc1331bc066e25b777a73b10c0ef84734b2
Signed-off-by: Alon Bar
Alon Bar-Lev has uploaded a new change for review.
Change subject: core: context: support 'before', 'after' in sequence
..
core: context: support 'before', 'after' in sequence
Change-Id: Id560d4aac9052379442c43672d87153b2cb4aefa
Alon Bar-Lev has uploaded a new change for review.
Change subject: core: use before/after feature
..
core: use before/after feature
Change-Id: I8f377d454b2d1f3fed1bd4df6d98955258a8c64d
Signed-off-by: Alon Bar-Lev
---
M src/otop
Alon Bar-Lev has uploaded a new change for review.
Change subject: core: context: cleanup buildSequence
..
core: context: cleanup buildSequence
Change-Id: I31f95bc1331bc066e25b777a73b10c0ef84734b2
Signed-off-by: Alon Bar-Lev
--
Alon Bar-Lev has posted comments on this change.
Change subject: host-deploy: use tar instead of python tarfile
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/11776
To
Alon Bar-Lev has uploaded a new change for review.
Change subject: host-deploy: use tar instead of python tarfile
..
host-deploy: use tar instead of python tarfile
python usage was introduced when fedora-18 alpha lacked tar
util
Maor Lipchuk has posted comments on this change.
Change subject: core: Change vm_pools entity to VmPool
..
Patch Set 1:
I'm not sure I follow your example,
vm_static -> VmStatic is the standard way of how that we reflect table
Alon Bar-Lev has posted comments on this change.
Change subject: tools: Consolidate all tools to single project
..
Patch Set 1:
Yair, please merge.
--
To view, visit http://gerrit.ovirt.org/11558
To unsubscribe, visit http://g
Alon Bar-Lev has posted comments on this change.
Change subject: engineencryptutils: cleanup
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/11532
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerri
Alon Bar-Lev has posted comments on this change.
Change subject: engineencryptutils: test: add encrypt/decrypt test
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/11533
To unsubscribe, visit http://gerrit.ov
Maor Lipchuk has posted comments on this change.
Change subject: core: Remove VdcActionParameterBase.httpSessionId
..
Patch Set 1: (1 inline comment)
File
backend/manager/mo
Alon Bar-Lev has uploaded a new change for review.
Change subject: packging: fix source URL
..
packging: fix source URL
Change-Id: I98af825eeb267ad7fa8e096a2bacac1f9f3b9c55
Signed-off-by: Alon Bar-Lev
---
M ovirt-iso-uploader.s
Alon Bar-Lev has uploaded a new change for review.
Change subject: packging: fix source URL
..
packging: fix source URL
Change-Id: I85135c0d1e4f54f789d1e424d8301985771dc4ff
Signed-off-by: Alon Bar-Lev
---
M ovirt-image-uploader
Alon Bar-Lev has uploaded a new change for review.
Change subject: packging: fix source URL
..
packging: fix source URL
Change-Id: Ie22b84bac980bdbc383b15ba19018480422848c6
Signed-off-by: Alon Bar-Lev
---
M ovirt-log-collector.
Alon Bar-Lev has posted comments on this change.
Change subject: core: Non-plugin automatic invocation of console session
..
Patch Set 1: (2 inline comments)
File
backend/ma
Alex Lourie has posted comments on this change.
Change subject: packaging: allow importing existing ISO domain on setup
..
Patch Set 3: Looks good to me, but someone else must approve
I agree with Alon, let's see how do we fix
Alex Lourie has posted comments on this change.
Change subject: packaging: allow interactive NFS exports cleanup with
engine-cleanup
..
Patch Set 6: Looks good to me, but someone else must approve
--
To view, visit http://gerr
Alex Lourie has posted comments on this change.
Change subject: packaging: modified validation of fqdn input during setup
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org
Tal Nisan has posted comments on this change.
Change subject: core: Remove VdcActionParameterBase.httpSessionId
..
Patch Set 1: (1 inline comment)
File
backend/manager/modul
Tal Nisan has posted comments on this change.
Change subject: core: Change vm_pools entity to VmPool
..
Patch Set 1:
Alissa - Thanks for the verification
Maor - I disagree, first of all you can notice that other entities has t
Einav Cohen has posted comments on this change.
Change subject: userportal: Add example of standalone configuration
..
Patch Set 1:
maybe prefix commit-comment subject with "engine"/"packaging"?
--
To view, visit http://gerrit
Einav Cohen has posted comments on this change.
Change subject: userportal: Serve static content with web server
..
Patch Set 1: (1 inline comment)
Commit Message
Line 3: Aut
Einav Cohen has posted comments on this change.
Change subject: userportal: Deploy to a separate directory
..
Patch Set 1: (1 inline comment)
Commit Message
Line 3: AuthorDat
Keith Robertson has submitted this change and it was merged.
Change subject: build: ovirt-log-collector-3.2.0_beta
..
build: ovirt-log-collector-3.2.0_beta
Change-Id: Ic62ba0e8ee17f65ca024066ee305dd72839c6c02
Signed-off-by: Kir
Keith Robertson has posted comments on this change.
Change subject: build: ovirt-log-collector-3.2.0_beta
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11769
To unsubscribe, visi
Keith Robertson has submitted this change and it was merged.
Change subject: build: post ovirt-log-collector-3.2.0_beta
..
build: post ovirt-log-collector-3.2.0_beta
Change-Id: Icc92bc6360c9f7cb7d140791e001c5bf70ea93b3
Signed-o
Keith Robertson has submitted this change and it was merged.
Change subject: build: post ovirt-image-uploader-3.2.0_beta
..
build: post ovirt-image-uploader-3.2.0_beta
Change-Id: I8533cf66261703c78d3bde209d8df6475a9e6d46
Signed
Keith Robertson has posted comments on this change.
Change subject: build: post ovirt-image-uploader-3.2.0_beta
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11768
To unsubscribe
Keith Robertson has posted comments on this change.
Change subject: build: post ovirt-log-collector-3.2.0_beta
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11770
To unsubscribe,
Keith Robertson has submitted this change and it was merged.
Change subject: build: ovirt-image-uploader-3.2.0_beta
..
build: ovirt-image-uploader-3.2.0_beta
Change-Id: I73083b7a8755fa500ddd18c01556f74a0196ca49
Signed-off-by: K
Keith Robertson has posted comments on this change.
Change subject: build: ovirt-image-uploader-3.2.0_beta
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11767
To unsubscribe, vis
Alon Bar-Lev has posted comments on this change.
Change subject: build: ovirt-image-uploader-3.2.0_beta
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/11767
To unsubscr
Moti Asayag has posted comments on this change.
Change subject: engine: Empty SetupNetworksCommand isn't sent to VDSM
..
Patch Set 1: (1 inline comment)
File
backend/manager
Alon Bar-Lev has posted comments on this change.
Change subject: build: post ovirt-log-collector-3.2.0_beta
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/11770
To unsu
Alon Bar-Lev has posted comments on this change.
Change subject: build: ovirt-log-collector-3.2.0_beta
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/11769
To unsubscri
Kiril Nesenko has uploaded a new change for review.
Change subject: build: post ovirt-log-collector-3.2.0_beta
..
build: post ovirt-log-collector-3.2.0_beta
Change-Id: Icc92bc6360c9f7cb7d140791e001c5bf70ea93b3
Signed-off-by: Kir
Kiril Nesenko has uploaded a new change for review.
Change subject: build: ovirt-log-collector-3.2.0_beta
..
build: ovirt-log-collector-3.2.0_beta
Change-Id: Ic62ba0e8ee17f65ca024066ee305dd72839c6c02
Signed-off-by: Kiril Nesenko
Keith Robertson has posted comments on this change.
Change subject: build: post ovirt-iso-uploader-3.2.0_beta
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11766
To unsubscribe,
Keith Robertson has submitted this change and it was merged.
Change subject: build: post ovirt-iso-uploader-3.2.0_beta
..
build: post ovirt-iso-uploader-3.2.0_beta
Change-Id: I78897f375e4e8e206bf06d611ac49b01f0517265
Signed-off
Alon Bar-Lev has posted comments on this change.
Change subject: build: post ovirt-image-uploader-3.2.0_beta
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/11768
To uns
Kiril Nesenko has uploaded a new change for review.
Change subject: build: post ovirt-image-uploader-3.2.0_beta
..
build: post ovirt-image-uploader-3.2.0_beta
Change-Id: I8533cf66261703c78d3bde209d8df6475a9e6d46
Signed-off-by: K
Kiril Nesenko has uploaded a new change for review.
Change subject: build: ovirt-image-uploader-3.2.0_beta
..
build: ovirt-image-uploader-3.2.0_beta
Change-Id: I73083b7a8755fa500ddd18c01556f74a0196ca49
Signed-off-by: Kiril Nesen
Keith Robertson has submitted this change and it was merged.
Change subject: build: ovirt-iso-uploader-3.2.0_beta
..
build: ovirt-iso-uploader-3.2.0_beta
Change-Id: I81bbd58156279c38cc445736f656c523e0e375b8
Signed-off-by: Kiril
Keith Robertson has posted comments on this change.
Change subject: build: ovirt-iso-uploader-3.2.0_beta
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11765
To unsubscribe, visit
Alon Bar-Lev has posted comments on this change.
Change subject: build: post ovirt-iso-uploader-3.2.0_beta
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/11766
To unsub
Kiril Nesenko has uploaded a new change for review.
Change subject: build: post ovirt-iso-uploader-3.2.0_beta
..
build: post ovirt-iso-uploader-3.2.0_beta
Change-Id: I78897f375e4e8e206bf06d611ac49b01f0517265
Signed-off-by: Kiril
Alon Bar-Lev has posted comments on this change.
Change subject: build: ovirt-iso-uploader-3.2.0_beta
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/11765
To unsubscrib
Kiril Nesenko has uploaded a new change for review.
Change subject: build: ovirt-iso-uploader-3.2.0_beta
..
build: ovirt-iso-uploader-3.2.0_beta
Change-Id: I81bbd58156279c38cc445736f656c523e0e375b8
Signed-off-by: Kiril Nesenko
Alon Bar-Lev has posted comments on this change.
Change subject: core: Create artifact for PostgreSQL module
..
Patch Set 1:
OK, I must say I lost you, but go head.
--
To view, visit http://gerrit.ovirt.org/11685
To unsubscrib
Project: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/
Build: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/3443/
Build Number: 3443
Build Status: Still Unstable
Triggered By: Started by upstream project "ovirt_engine" build number 4,208
-
Changes
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: Move dependencies to a JBoss module
..
Patch Set 1:
But I thought you wrote to me once that we do not need these modules, we only
used them because we
Project: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/
Build: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/3442/
Build Number: 3442
Build Status: Still Unstable
Triggered By: Started by upstream project "ovirt_engine" build number 4,207
-
Changes
Juan Hernandez has uploaded a new change for review.
Change subject: userportal: Deploy to a separate directory
..
userportal: Deploy to a separate directory
Currently we package the user portal as a subdirectory inside the .ear
Juan Hernandez has uploaded a new change for review.
Change subject: userportal: Add example of standalone configuration
..
userportal: Add example of standalone configuration
This patch adds an example of the Apache configurati
Juan Hernandez has uploaded a new change for review.
Change subject: userportal: Serve static content with web server
..
userportal: Serve static content with web server
Currently all the content of the user portal is served by
Alissa Bonas has posted comments on this change.
Change subject: core: Change vm_pools entity to VmPool
..
Patch Set 1: Verified
compiled with enable-dao-tests
--
To view, visit http://gerrit.ovirt.org/11714
To unsubscribe, vi
Maor Lipchuk has posted comments on this change.
Change subject: core: Remove VdcActionParameterBase.httpSessionId
..
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
Maor Lipchuk has posted comments on this change.
Change subject: core: Change VmPool method names to fit the standard
..
Patch Set 1: (1 inline comment)
File
backend/manager
Maor Lipchuk has posted comments on this change.
Change subject: core: Change vm_pools entity to VmPool
..
Patch Set 1:
I think this change could be a bit misleading.
The table name in the DB still reflects plural name: vm_pool
Ravi Nori has posted comments on this change.
Change subject: restapi : malformated guid's cause http 500 (#902073)
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/11758
To unsubscribe, visit http://gerrit.ov
Ravi Nori has uploaded a new change for review.
Change subject: restapi : malformated guid's cause http 500 (#902073)
..
restapi : malformated guid's cause http 500 (#902073)
When malformed Guids are passed in post data for acti
Tal Nisan has submitted this change and it was merged.
Change subject: core: Removed classes DateTimeStyles, CultureInfo,
TimeFormatValidation
..
core: Removed classes DateTimeStyles, CultureInfo, TimeFormatValidation
Removed
Tal Nisan has posted comments on this change.
Change subject: core: Removed classes DateTimeStyles, CultureInfo,
TimeFormatValidation
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.o
Tal Nisan has posted comments on this change.
Change subject: core: Removed classes DateTimeStyles, CultureInfo,
TimeFormatValidation
..
Patch Set 2: Verified; Looks good to me, approved
Rebased
--
To view, visit http://gerri
1 - 100 of 260 matches
Mail list logo