Shireesh Anjal has posted comments on this change. Change subject: core: StorageHelper class for GlusterFS. ......................................................................
Patch Set 9: (1 inline comment) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GlusterFsStorageHelper.java Line 7: * Storage helper for Posix FS connections Line 8: */ Line 9: public class GlusterFsStorageHelper extends BaseFsStorageHelper { Line 10: Line 11: protected Log getLog() { I don't see this being used. If it is really required, it should be added to the parent class where the "log" variable is defined. Line 12: return log; Line 13: } Line 14: Line 15: -- To view, visit http://gerrit.ovirt.org/8834 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5360ac7b3ccc02a3ec70e217bc7a1c3aa7d24600 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sharad Mishra <snmis...@linux.vnet.ibm.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Deepak C Shetty <deepa...@linux.vnet.ibm.com> Gerrit-Reviewer: Itamar Heim <ih...@redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhorn...@redhat.com> Gerrit-Reviewer: Sharad Mishra <snmis...@linux.vnet.ibm.com> Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com> Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches