Yair Zaslavsky has posted comments on this change.
Change subject: engine: Added infrastructure for providing a canDoactions in
case of locks
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lock/InMemoryLockManager.java
Line 73: }
Line 74: }
Line 75:
Line 76: @Override
Line 77: public Pair<Boolean, Set<String>> acquireLock(EngineLock lock) {
Why are we interested in a Set of Strings here? Is it because you think that
for same same entity several threads may provide different messages? It's not
reflected from the current patch (from what I see there is a
LockMessagesMatchUtil which matches a single message per entity type.
Do you see a scenario in which more than one message will be required?
Line 78: log.debugFormat("Before acquiring lock {0}", lock);
Line 79: globalLock.lock();
Line 80: try {
Line 81: return acquireLockInternal(lock);
--
To view, visit http://gerrit.ovirt.org/11738
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I87698da36ddb6e7556e98612d299da68f2eb53dc
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Kublin <mkub...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Arik Hadas <aha...@redhat.com>
Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
