Tal Nisan has posted comments on this change. Change subject: core: Change vm_pools entity to VmPool ......................................................................
Patch Set 1: Alissa - Thanks for the verification Maor - I disagree, first of all you can notice that other entities has the same minor issue such as VmStatic that is mapped to the table vm_static, there is a strong logical connection between the vm_pools table and the VmPool entity, if it would have called in a name which isn't similar in any way that would have been a different story Besides that, while the VmPool entity is mapped by the mapper to the result set returned in the queries and the change cross platform is relatively easy, changing the database table name will be a pain in the neck and will involve changing all the stored procedures, indexes, views and so on, too much of a hassle and many potential points of failure, this should be done at the point where we will make a thorough schema refactoring -- To view, visit http://gerrit.ovirt.org/11714 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I41147ad4479ed6f31bb25b3f0e86c5f258efe027 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Alissa Bonas <abo...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Sharad Mishra <snmis...@linux.vnet.ibm.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
