Yair Zaslavsky has uploaded a new change for review.
Change subject: core: Findbug fix of isPluggable method
......................................................................
core: Findbug fix of isPluggable method
This fixes an equals issue at isPluggable method
Change-Id: I4360ac7b3ccc02a3ec70e217bc7a1c3aa7d24301
Signed-off-by: Yair Zaslavsky <yzasl...@redhat.com>
---
M
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/84/11784/1
diff --git
a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java
b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java
index 07b20ec..e0272ab 100644
---
a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java
+++
b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java
@@ -1151,7 +1151,7 @@
}
private boolean devicePluggable(VmDevice device) {
- return (VmDeviceType.DISK.getName().equals(device.getDevice()) &&
VmDeviceType.DISK.getName().equals(device))
+ return (VmDeviceType.DISK.getName().equals(device.getDevice()) &&
VmDeviceType.DISK.getName().equals(device.getType()))
|| (VmDeviceType.BRIDGE.getName().equals(device.getDevice())
&& VmDeviceType.INTERFACE.getName().equals(device.getType()));
}
--
To view, visit http://gerrit.ovirt.org/11784
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4360ac7b3ccc02a3ec70e217bc7a1c3aa7d24301
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
