Vered Volansky has posted comments on this change. Change subject: core: Change vm_pools entity to VmPool ......................................................................
Patch Set 1: In reply to Maor's suggestion, I think VmPools for an entity is a misleading abomination. If I encounter an entity with this kind of name I expect it to actually contain several pools. I would also waste my time looking for a container, until I get to the conclusion that this is just bad naming (generally speaking, not ovirt-specific - which says it all). I think VmPool is a good start, and the link to the vm_pools is still obvious enough. TBD on the vm_pool change is good enough for now, IMHO. -- To view, visit http://gerrit.ovirt.org/11714 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I41147ad4479ed6f31bb25b3f0e86c5f258efe027 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Alissa Bonas <abo...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Sharad Mishra <snmis...@linux.vnet.ibm.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
