Mike Kolesnik has posted comments on this change.
Change subject: engine: Empty SetupNetworksCommand isn't sent to VDSM
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/SetupNetworksCommand.java
Line 123: log.debugFormat("Setup networks command timed out for {0}
seconds", timeout);
Line 124: }
Line 125: }
Line 126:
Line 127: private boolean isEmptyCommand() {
In addition, please notice that method names starting with is/set/get should be
used mostly for class fields (per javabeans standard) and/or delegation to
methods.
Line 128: return getNetworks().isEmpty() &&
getRemovedNetworks().isEmpty()
Line 129: && getBonds().isEmpty() &&
getRemovedBonds().isEmpty();
Line 130: }
Line 131:
--
To view, visit http://gerrit.ovirt.org/11750
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib68eeb1e7e75aea7b0730ee4650675fd2b9d37cd
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lver...@redhat.com>
Gerrit-Reviewer: Lior Vernia <lver...@redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
