Alon Bar-Lev has posted comments on this change.
Change subject: core: Non-plugin automatic invocation of console session
......................................................................
Patch Set 1: (2 inline comments)
....................................................
File
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/console/ConsoleConfigServlet.java
Line 17: public class ConsoleConfigServlet extends IniServlet {
Line 18:
Line 19: private static final long serialVersionUID = 8496520437603585173L;
Line 20:
Line 21: private static final String CONFIG_FILE_HEADER = "[virt-viewer]";
I must admit I don't like the dependency of specific project, aka virt-viewer,
but it is a good start.
I would like to see this pluggable so we can extend it to any host side user
may have.
Line 22: private static final String HEADER_CONTENT_TYPE = "x-virt-viewer";
Line 23: private static final String HEADER_CONTENT_FILENAME = "console.vv";
Line 24:
Line 25: @Override
....................................................
File
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/IniServlet.java
Line 22: private static final long serialVersionUID = 119752080913341323L;
Line 23: private static final Logger log =
Logger.getLogger(IniServlet.class);
Line 24:
Line 25: @Override
Line 26: protected void doGet(HttpServletRequest request,
HttpServletResponse response) throws ServletException, IOException {
This will be limited to ~1024 and we may have issues with firewalls.
I suggest using post.
Line 27: try {
Line 28: writeIniToStream(response.getOutputStream(),
request.getParameterMap());
Line 29: } catch (IOException e) {
Line 30: log.error("Error when writing to response stream " +
e.getMessage());
--
To view, visit http://gerrit.ovirt.org/11702
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I18b9d2efad15f5e9bb98a8176112b721c810205f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Frank Kobzik <fkob...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Frank Kobzik <fkob...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
