Liron Aravot has posted comments on this change.
Change subject: core: Remove global lock on SPM calls from engine side
..
Patch Set 5:
please note: after the event queue was merged, seems like a change should be
done here to
Project: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/
Build: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/3033/
Build Number: 3033
Build Status: Still Unstable
Triggered By: Started by upstream project "ovirt_engine" build number 3,817
-
Chang
Omer Frenkel has posted comments on this change.
Change subject: engine: template support for cpu host
..
Patch Set 8:
looks ok, but still, what about import and export for this field?
--
To view, visit http://gerrit.ovirt.org
ofri masad has posted comments on this change.
Change subject: engine: template support for cpu host
..
Patch Set 7: (1 inline comment)
File
backend/manager/modules/common/s
Project: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/
Build: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/3032/
Build Number: 3032
Build Status: Unstable
Triggered By: Started by upstream project "ovirt_engine" build number 3,816
-
Changes Sin
ofri masad has posted comments on this change.
Change subject: userportal: Add refresh button to Resources tab
..
Patch Set 4: Verified
--
To view, visit http://gerrit.ovirt.org/10540
To unsubscribe, visit http://gerrit.ovirt.o
Liron Aravot has posted comments on this change.
Change subject: core: automatic reconstruct shouldn't abort user initiated
recovery
..
Patch Set 1:
Yair, as i described in this patch (see comments)
http://gerrit.ovirt.org/#/c
Shireesh Anjal has posted comments on this change.
Change subject: engine: Fix SHD service not displaying issue (#885592)
..
Patch Set 3: (1 inline comment)
File backend/mana
Shireesh Anjal has submitted this change and it was merged.
Change subject: engine: gluster action version check added
..
engine: gluster action version check added
- Minimum Gluster supported version for an action is virtual
Selvasundaram has posted comments on this change.
Change subject: engine: gluster action version check added
..
Patch Set 7: Verified
Rebased
--
To view, visit http://gerrit.ovirt.org/9670
To unsubscribe, visit http://gerrit.o
Shireesh Anjal has posted comments on this change.
Change subject: engine: gluster action version check added
..
Patch Set 7: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9670
To unsubscribe, visit http:
Shireesh Anjal has posted comments on this change.
Change subject: engine: gluster action version check added
..
Patch Set 6: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9670
To unsubscribe, visit http:
Yair Zaslavsky has posted comments on this change.
Change subject: core: automatic reconstruct shouldn't abort user initiated
recovery
..
Patch Set 1:
Infra-wise - the patch looks fine.
I am not sure I understand the logic beh
Selvasundaram has posted comments on this change.
Change subject: engine: gluster action version check added
..
Patch Set 6: Verified
Rebased
--
To view, visit http://gerrit.ovirt.org/9670
To unsubscribe, visit http://gerrit.o
Shireesh Anjal has submitted this change and it was merged.
Change subject: webadmin: Disabling Add Bricks if empty Cluster selected
..
webadmin: Disabling Add Bricks if empty Cluster selected
In Create Volume dialog, the Add B
Shireesh Anjal has posted comments on this change.
Change subject: webadmin: Disabling Add Bricks if empty Cluster selected
..
Patch Set 5: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10513
To unsubscri
Shireesh Anjal has submitted this change and it was merged.
Change subject: webadmin: Fix Add brick popup issue
..
webadmin: Fix Add brick popup issue
While creating a new gluster volume, the Add Brick
popup will be opened auto
Shireesh Anjal has posted comments on this change.
Change subject: webadmin: Fix Add brick popup issue
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10499
To unsubscribe, visit http://gerr
Shireesh Anjal has submitted this change and it was merged.
Change subject: webadmin: Added missing import cluster error message
..
webadmin: Added missing import cluster error message
Added the missing import cluster error mes
Shireesh Anjal has posted comments on this change.
Change subject: webadmin: Added missing import cluster error message
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10421
To unsubscribe,
Shireesh Anjal has submitted this change and it was merged.
Change subject: webadmin: Added translation for import cluster errors
..
webadmin: Added translation for import cluster errors
If there are any errors while fetching t
Shireesh Anjal has posted comments on this change.
Change subject: webadmin: Added translation for import cluster errors
..
Patch Set 6: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10409
To unsubscribe,
Shireesh Anjal has submitted this change and it was merged.
Change subject: webadmin: Adding warning messages to remove bricks
..
webadmin: Adding warning messages to remove bricks
A warning message will be shown in the confirm
Shireesh Anjal has posted comments on this change.
Change subject: webadmin: Adding warning messages to remove bricks
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10408
To unsubscribe, vi
Vered Volansky has posted comments on this change.
Change subject: core: add toString method to VM and VDS
..
Patch Set 5: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/7640
To unsubs
Vered Volansky has posted comments on this change.
Change subject: core: avoid NPE on UpdateVM template command
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/10545
To
Kanagaraj M has posted comments on this change.
Change subject: webadmin: Disabling Add Bricks if empty Cluster selected
..
Patch Set 5: Verified
Rebased and Verified.
--
To view, visit http://gerrit.ovirt.org/10513
To unsubsc
Kanagaraj M has posted comments on this change.
Change subject: webadmin: Fix Add brick popup issue
..
Patch Set 3: Verified
Rebased and Verified.
--
To view, visit http://gerrit.ovirt.org/10499
To unsubscribe, visit http://ge
Kanagaraj M has posted comments on this change.
Change subject: webadmin: Added missing import cluster error message
..
Patch Set 3: Verified
Rebased and Verified.
--
To view, visit http://gerrit.ovirt.org/10421
To unsubscribe
Kanagaraj M has posted comments on this change.
Change subject: webadmin: Added translation for import cluster errors
..
Patch Set 6: Verified
Rebased and Verified.
--
To view, visit http://gerrit.ovirt.org/10409
To unsubscrib
Kanagaraj M has posted comments on this change.
Change subject: webadmin: Adding warning messages to remove bricks
..
Patch Set 3: Verified
Rebased and Verified.
--
To view, visit http://gerrit.ovirt.org/10408
To unsubscribe,
Project: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/
Build: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/3124/
Build Number: 3124
Build Status: Fixed
Triggered By: Started by upstream project "ovirt_engine" build number 3,813
-
Changes Since La
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: packaging: Introduce make.py
..
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
Project: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/
Build: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/3123/
Build Number: 3123
Build Status: Failure
Triggered By: Started by upstream project "ovirt_engine" build number 3,812
-
Changes Since
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: packaging: Introduce make.py
..
Patch Set 1:
Have you considered using Waf (https://code.google.com/p/waf/)? I agree with
Alon you should use as mu
Gilad Chaplik has posted comments on this change.
Change subject: core: Comment typo fix
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10551
To unsubscribe, visit http://gerrit.ovirt.org/s
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: Updated all utilities to use backup.sh instead of
pg_dump
..
Patch Set 1: (1 inline comment)
File
Alex Lourie has posted comments on this change.
Change subject: packaging: Updated all utilities to use backup.sh instead of
pg_dump
..
Patch Set 1: (3 inline comments)
File
Maor Lipchuk has uploaded a new change for review.
Change subject: core: comment type fix
..
core: comment type fix
Signed-off-by: Maor Lipchuk
Change-Id: I911824c492f9dc1886f94850d6e4816be93cbe6d
---
M backend/manager/dbscript
Alex Lourie has posted comments on this change.
Change subject: packaging: Updated all utilities to use backup.sh instead of
pg_dump
..
Patch Set 1:
Verified on both F17 and F18
--
To view, visit http://gerrit.ovirt.org/10548
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: Updated all utilities to use backup.sh instead of
pg_dump
..
Patch Set 1: (3 inline comments)
Fil
Liron Aravot has uploaded a new change for review.
Change subject: core: automatic reconstruct shouldn't abort user initiated
recovery
..
core: automatic reconstruct shouldn't abort user initiated recovery
Automatic engine time
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: initial repo creation
..
Patch Set 5: (11 inline comments)
File kickstart/ovirt.ks
Line 3: # mailt
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: initial repo creation
..
Patch Set 5:
images should be at /images directory.
--
To view, visit http://gerrit.ovirt.org/9733
To unsubscribe, visit http
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: initial repo creation
..
Patch Set 5:
I don't think there is a need for commit template in every project.
--
To view, visit http://gerrit.ovirt.org/97
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: initial repo creation
..
Patch Set 5:
Please put patches in patches directory, per product if needed.
patches/ovirt-engine/
patches/xxx/
--
To view,
Alex Lourie has posted comments on this change.
Change subject: packaging: Updated all utilities to use backup.sh instead of
pg_dump
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/10548
To unsubscribe, visi
Liron Aravot has abandoned this change.
Change subject: core : WIP : Preview snapshot - NPE after engine crash
..
Patch Set 7: Abandoned
from the bug thread:
"right now compensation will run on server startup regardless whether
Alex Lourie has uploaded a new change for review.
Change subject: packaging: Updated all utilities to use backup.sh instead of
pg_dump
..
packaging: Updated all utilities to use backup.sh instead of pg_dump
* Previously, the se
Alissa Bonas has posted comments on this change.
Change subject: core: avoid NPE on UpdateVM template command
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/10545
To un
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: add cpu name information to main cluster view
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10546
To unsubscribe
Gilad Chaplik has posted comments on this change.
Change subject: userportal: Add refresh button to Resources tab
..
Patch Set 4: Looks good to me, approved
I won't take ofri the credit to check the verify flag :-)
--
To view,
Doron Fediuck has posted comments on this change.
Change subject: userportal: Add refresh button to Resources tab
..
Patch Set 4:
If you did, please set the relevant flag.
--
To view, visit http://gerrit.ovirt.org/10540
To uns
Gilad Chaplik has posted comments on this change.
Change subject: userportal: Add refresh button to Resources tab
..
Patch Set 4:
I saw it working
--
To view, visit http://gerrit.ovirt.org/10540
To unsubscribe, visit http://ge
Noam Slomianko has posted comments on this change.
Change subject: webadmin: add cpu name information to main cluster view
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/10546
To unsubscribe, visit http://ge
Noam Slomianko has uploaded a new change for review.
Change subject: webadmin: add cpu name information to main cluster view
..
webadmin: add cpu name information to main cluster view
Add to MainTabClusterView a new column for t
Noam Slomianko has posted comments on this change.
Change subject: engine: Add validation to cpu pinning
..
Patch Set 7: Verified
--
To view, visit http://gerrit.ovirt.org/10364
To unsubscribe, visit http://gerrit.ovirt.org/set
Doron Fediuck has posted comments on this change.
Change subject: engine: Add validation to cpu pinning
..
Patch Set 7: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/10364
To unsubscr
Tal Nisan has posted comments on this change.
Change subject: core: avoid unneeded db calls on update of BlankTemplate
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10544
To unsubscribe, v
Tal Nisan has posted comments on this change.
Change subject: core: avoid NPE on UpdateVM template command
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10545
To unsubscribe, visit http://
Doron Fediuck has posted comments on this change.
Change subject: userportal: Add refresh button to Resources tab
..
Patch Set 4: Looks good to me, but someone else must approve
Was this verified?
--
To view, visit http://gerr
Liron Aravot has uploaded a new change for review.
Change subject: core: avoid unneeded db calls on update of BlankTemplate
..
core: avoid unneeded db calls on update of BlankTemplate
When trying to edit a blank template, there'
Liron Aravot has uploaded a new change for review.
Change subject: core: avoid NPE on UpdateVM template command
..
core: avoid NPE on UpdateVM template command
When trying to update a template which was deleted, an NPE can occur
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: Upgrade will update image statuses to OK.
..
core: Upgrade will update image statuses to OK.
As part of the upgrade process, engine cancel the task
Maor Lipchuk has posted comments on this change.
Change subject: core: Upgrade will update image statuses to OK.
..
Patch Set 4: Verified; Looks good to me, approved
Acked by emesika
--
To view, visit http://gerrit.ovirt.org/1
Maor Lipchuk has posted comments on this change.
Change subject: core: Upgrade will update image statuses to OK.
..
Patch Set 3: Verified; Looks good to me, approved
Acked by emesika
--
To view, visit http://gerrit.ovirt.org/1
Maor Lipchuk has posted comments on this change.
Change subject: core: Upgrade will update image statuses to OK.
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/10492
To unsubscribe, visit http://gerrit.ovirt
Gilad Chaplik has submitted this change and it was merged.
Change subject: webadmin: Add no-quota notification and quota buttons
..
webadmin: Add no-quota notification and quota buttons
Sub-tab quota under the main-tab Data Cen
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: Add no-quota notification and quota buttons
..
Patch Set 5: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10520
To uns
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: Add no-quota notification and quota buttons
..
Patch Set 4: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10520
To unsubscribe,
ofri masad has posted comments on this change.
Change subject: webadmin: Add no-quota notification and quota buttons
..
Patch Set 4: Verified
--
To view, visit http://gerrit.ovirt.org/10520
To unsubscribe, visit http://gerrit.o
Muli Salem has uploaded a new change for review.
Change subject: engine: Network Command Validation
..
engine: Network Command Validation
This patch extracts repetitive code to the
NetworkCommon class, and cleans up canDoActions
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: Add no-quota notification and quota buttons
..
Patch Set 3: (2 inline comments)
File
frontend/web
Alex Lourie has posted comments on this change.
Change subject: packaging: Updated cleanup to clean postgresql 9.2 connections
..
Patch Set 1: Verified
Verified on both Fedora 17 (psql 9.1) and on Fedora 19 (psql 9.2)
--
To v
Gilad Chaplik has posted comments on this change.
Change subject: userportal: Add refresh button to Resources tab
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/10540
T
Doron Fediuck has posted comments on this change.
Change subject: userportal: Add refresh button to Resources tab
..
Patch Set 2: (1 inline comment)
File
frontend/webadmin/m
Alissa Bonas has posted comments on this change.
Change subject: core: BackendVmDisksResource cleanup
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/10350
To unsubscrib
Alissa Bonas has posted comments on this change.
Change subject: core:StorageHelper cleanup, use one log declaration.
..
Patch Set 4: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/101
Gilad Chaplik has posted comments on this change.
Change subject: userportal: Added caching to user portal page webadmin: Added
caching to webadmin page
..
Patch Set 1: (11 inline comments)
Kiril Nesenko has posted comments on this change.
Change subject: packaging: initial repo creation
..
Patch Set 3: I would prefer that you didn't submit this
(19 inline comments)
...
Arik Hadas has posted comments on this change.
Change subject: core: fix run once starts with wrong display type
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/10537
To unsubscribe, visit http://gerrit.ovirt
Arik Hadas has posted comments on this change.
Change subject: core: fix run once starts with wrong display type
..
Patch Set 2: (1 inline comment)
File
backend/manager/modu
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: Introduce make.py
..
Patch Set 1: (2 inline comments)
I don't really like the move into fully scripted script and drop the Make.
It makes maintenance
ofri masad has uploaded a new change for review.
Change subject: userportal: Add refresh button to Resources tab
..
userportal: Add refresh button to Resources tab
Added standard refresh button (with interval chooser) to
SideTab
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: Allow normal users to run the service
..
Patch Set 1:
So why do we actually need the service user name? we do nothing with it... had
we chuid() to it,
Daniel Erez has posted comments on this change.
Change subject: core: cleanup AttachDettachVmDiskParameters c'tor
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10349
To unsubscribe, visit
Daniel Erez has posted comments on this change.
Change subject: userportal,webadmin: fix focus traversal in add disk dialog
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10534
To unsubscri
Juan Hernandez has uploaded a new change for review.
Change subject: packaging: Allow normal users to run the service
..
packaging: Allow normal users to run the service
Currently we have a restriction in the service script to o
Noam Slomianko has posted comments on this change.
Change subject: engine: Add validation to cpu pinning
..
Patch Set 6: Verified
All concerns should now be addressed
--
To view, visit http://gerrit.ovirt.org/10364
To unsubscr
Roy Golan has posted comments on this change.
Change subject: core: fix run once starts with wrong display type
..
Patch Set 2: (1 inline comment)
File
backend/manager/modul
Arik Hadas has posted comments on this change.
Change subject: core: fixed video device setting on import vm/template
..
Patch Set 4: Verified
--
To view, visit http://gerrit.ovirt.org/10525
To unsubscribe, visit http://gerrit.
Arik Hadas has posted comments on this change.
Change subject: core: fixed video device setting on import vm/template
..
Patch Set 3: (1 inline comment)
File
backend/manager
Project: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/
Build: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/3119/
Build Number: 3119
Build Status: Fixed
Triggered By: Started by upstream project "ovirt_engine" build number 3,808
-
Changes Since La
Project: http://jenkins.ovirt.org/job/ovirt_engine_gwt_admin/
Build: http://jenkins.ovirt.org/job/ovirt_engine_gwt_admin/3071/
Build Number: 3071
Build Status: Fixed
Triggered By: Started by upstream project "ovirt_engine" build number 3,807
-
Changes Since La
Doron Fediuck has posted comments on this change.
Change subject: webadmin: Add no-quota notification and quota buttons
..
Patch Set 3: Looks good to me, but someone else must approve
Ofri,
Generally speaking it looks good eno
Arik Hadas has posted comments on this change.
Change subject: core: fix run once starts with wrong display type
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/10537
To unsubscribe, visit http://gerrit.ovirt
Arik Hadas has uploaded a new change for review.
Change subject: core: fix run once starts with wrong display type
..
core: fix run once starts with wrong display type
This patch fix the following bug: trying to run once a VM wh
Project: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/
Build: http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/3024/
Build Number: 3024
Build Status: Fixed
Triggered By: Started by upstream project "ovirt_engine" build number 3,807
-
Changes Since
Arik Hadas has posted comments on this change.
Change subject: core: fixed video device setting on import vm/template
..
Patch Set 3: (1 inline comment)
File
backend/manager
Alona Kaplan has submitted this change and it was merged.
Change subject: engine,webadmin: Networks sort should be done on engine side
..
engine,webadmin: Networks sort should be done on engine side
Networks main tab should be
1 - 100 of 109 matches
Mail list logo
