Alex Lourie has posted comments on this change.
Change subject: packaging: Updated all utilities to use backup.sh instead of
pg_dump
......................................................................
Patch Set 1: (3 inline comments)
....................................................
File packaging/fedora/setup/common_utils.py
Line 813: logging.debug("%s DB Backup started", db)
Line 814:
Line 815: # Run backup
Line 816: db_backup = os.path.join(basedefs.DIR_DB_SCRIPTS,
Line 817: basedefs.FILE_DB_BACKUP_SCRIPT)
True, but the full path looks better in logs and much more easier for finding
bugs. The log doesn't say that the path is changed during the command run, so I
still think full path is beneficial here.
Line 818: cmd = [
Line 819: db_backup,
Line 820: "-u", user,
Line 821: "-s", host,
....................................................
File packaging/fedora/setup/engine-cleanup.py
Line 275: os.remove(self.sqlfile)
Line 276:
Line 277: def backup(self):
Line 278: """
Line 279: Backup db using backup.sh
Will do.
Line 280: """
Line 281: # backup.sh -u postgres -f $file -d dbname -s server -p port
Line 282: utils.backupDB(
Line 283: db=basedefs.DB_NAME,
....................................................
File packaging/fedora/setup/engine-upgrade.py
Line 349
Line 350
Line 351
Line 352
Line 353
I agree that it would be better to call up functions directly. But in this case
I'd say:
1. To stay consistent with other DB functions (such as restore and update)
2. To more easily use self.sqlfile value
--
To view, visit http://gerrit.ovirt.org/10548
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I011bc64d989cfba602977fd3f9522ea2c329aedc
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alex Lourie <alou...@redhat.com>
Gerrit-Reviewer: Alex Lourie <alou...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Kiril Nesenko <knese...@redhat.com>
Gerrit-Reviewer: Moran Goldboim <mgold...@redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
