Alon Bar-Lev has posted comments on this change. Change subject: packaging: initial repo creation ......................................................................
Patch Set 5: (11 inline comments) .................................................... File kickstart/ovirt.ks Line 3: # mailto:desk...@lists.fedoraproject.org Line 4: Line 5: %include ovirt-live-base.ks Line 6: Line 7: part / --size 16000 space Line 8: rootpw --iscrypted $1$Idf9Mf5B$lmQBHtDcnO4Xd53vqFWqT. Line 9: authconfig --enableshadow --passalgo=sha512 --enablefingerprint Line 10: timezone --utc Asia/Jerusalem Line 11: Line 4: Line 5: %include ovirt-live-base.ks Line 6: Line 7: part / --size 16000 Line 8: rootpw --iscrypted $1$Idf9Mf5B$lmQBHtDcnO4Xd53vqFWqT. space Line 9: authconfig --enableshadow --passalgo=sha512 --enablefingerprint Line 10: timezone --utc Asia/Jerusalem Line 11: Line 12: %packages Line 71: mkdir /root/oVirtLiveFiles/ Line 72: echo "making autostart dir" Line 73: mkdir -p ~oVirtuser/.config/autostart Line 74: Line 75: cat >> /etc/rc.d/init.d/livesys << EOF Can we split tihs into separate scripts? Line 76: # disable screensaver locking Line 77: cat >> /usr/share/glib-2.0/schemas/org.gnome.desktop.screensaver.gschema.override << FOE Line 78: [org.gnome.desktop.screensaver] Line 79: lock-enabled=false .................................................... File kickstart/ovirt-live-base.ks Line 57: %end Line 58: Line 59: %post Line 60: # FIXME: it'd be better to get this installed from a package Line 61: cat > /etc/rc.d/init.d/livesys << EOF Can we split this into separate script? Line 62: #!/bin/bash Line 63: # Line 64: # live: Init script for live image Line 65: # .................................................... File oVirtLiveFiles/configure-network.sh Line 1: #!/bin/bash Line 2: ifup ovirtmgmt Line 3: ifconfig dummy0 10.0.0.1 netmask 255.255.255.0 Line 4: brctl addbr ovirtmgmt Line 5: brctl addif ovirtmgmt dummy0 why do we need this? .................................................... File oVirtLiveFiles/engine-setup.patch Line 1: diff --git a/engine-setup.py b/../new/engine-setup.py format-patch Line 2: index f347e78..681e04b 100755 Line 3: --- a/engine-setup.py Line 4: +++ b/../new/engine-setup.py Line 5: @@ -675,6 +675,7 @@ def _backupOldHttpdConfig(): Line 13: @@ -1024,7 +1025,7 @@ def _upgradeDB(): Line 14: currentDbName = basedefs.DB_NAME Line 15: Line 16: # Update rpm version in vdc options Line 17: - utils.updateVDCOption("ProductRPMVersion", utils.getRpmVersion(basedefs.ENGINE_RPM_NAME)) This can be remain empty, or just return something. So you can avoid this patch. Line 18: + #utils.updateVDCOption("ProductRPMVersion", utils.getRpmVersion(basedefs.ENGINE_RPM_NAME)) Line 19: except: Line 20: # Upgrade failed! we need to restore the old db .................................................... File oVirtLiveFiles/engine-setup-yad.sh Line 1: #! /bin/bash what is yad? Line 2: # TODO Line 3: Line 4: sudo ifconfig dummy0 10.0.0.1 netmask 255.255.255.0 Line 5: sudo ifup ovirtmgmt Line 1: #! /bin/bash Line 2: # TODO space Line 3: Line 4: sudo ifconfig dummy0 10.0.0.1 netmask 255.255.255.0 Line 5: sudo ifup ovirtmgmt Line 6: sudo brctl addbr ovirtmgmt Line 31: Line 32: case $action in Line 33: automatic*) cmd="sudo /usr/bin/engine-setup --answer-file=/home/oVirtuser/oVirtLiveFiles/ovirt-answer" ;; Line 34: interactive*) cmd="gnome-terminal --command=\"sudo /usr/bin/engine-setup\";sleep 20" ;; Line 35: *) exit 1 ;; space Line 36: esac Line 37: Line 38: echo "excecuting $cmd" Line 39: $cmd .................................................... File oVirtLiveFiles/nfsutils.patch Line 3: @@ -33,6 +33,7 @@ Line 4: exportFile.close() Line 5: Line 6: def setSELinuxContextForDir(path, contextName): Line 7: + return Why do we need this? Line 8: logging.debug("setting selinux context for %s" % path) Line 9: if path.endswith("/"): -- To view, visit http://gerrit.ovirt.org/9733 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I66cca8f5d5abaa710f054c59043ff6363b68256f Gerrit-PatchSet: 5 Gerrit-Project: ovirt-live Gerrit-Branch: master Gerrit-Owner: Moran Goldboim <mgold...@redhat.com> Gerrit-Reviewer: Alex Lourie <alou...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Eyal Edri <ee...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Kiril Nesenko <knese...@redhat.com> Gerrit-Reviewer: Moran Goldboim <mgold...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> Gerrit-Reviewer: Ohad Basan <oba...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
