Liron Aravot has abandoned this change. Change subject: core : WIP : Preview snapshot - NPE after engine crash ......................................................................
Patch Set 7: Abandoned from the bug thread: "right now compensation will run on server startup regardless whether the tasks were initiated on vdsm, so endSuccesfully/endWithFailure can be called after compensation ran when all needed entities might have been deleted which will cause to NPE. If we want to solve those bugs until all the tasks related issues that we discussed on the tasks meeting are cleared, the only mechanism that we have now for doing so is to check during end methods whether added entity was deleted during compensation to prevent NPE - which is the implemented solution. basically we should decide in which way we want to go - if we want to solve those bugs, that's the solution . if we do not to solve in this way, all of those bugs should be dependent on the tasks related bugs and wait for the solution of 'missing tasks' and 'compensation with tasks'." as we prefer to wait for tasks issues to be solved, abandoning. -- To view, visit http://gerrit.ovirt.org/9073 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Ia4ddecc990fbca23fb98e8ab42cb1eb039e1fb59 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com> Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
