Liron Aravot has uploaded a new change for review.
Change subject: core: avoid unneeded db calls on update of BlankTemplate
......................................................................
core: avoid unneeded db calls on update of BlankTemplate
When trying to edit a blank template, there's no need to load the
template from the DB before failing the operation.
Change-Id: Ia66a00303c19d9fe77fbd57021227f08ad5d160b
Signed-off-by: Liron Aravot <lara...@redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmTemplateCommand.java
1 file changed, 4 insertions(+), 3 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/44/10544/1
diff --git
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmTemplateCommand.java
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmTemplateCommand.java
index 5ddc1ed..e0ba2bd 100644
---
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmTemplateCommand.java
+++
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmTemplateCommand.java
@@ -35,12 +35,13 @@
@Override
protected boolean canDoAction() {
boolean returnValue = false;
+ if
(VmTemplateHandler.BlankVmTemplateId.equals(getVmTemplate().getId())) {
+ return
failCanDoAction(VdcBllMessages.VMT_CANNOT_EDIT_BLANK_TEMPLATE);
+ }
mOldTemplate =
DbFacade.getInstance().getVmTemplateDao().get(getVmTemplate().getId());
VmTemplateHandler.UpdateDisksFromDb(mOldTemplate);
if (mOldTemplate != null) {
- if
(VmTemplateHandler.BlankVmTemplateId.equals(mOldTemplate.getId())) {
-
addCanDoActionMessage(VdcBllMessages.VMT_CANNOT_EDIT_BLANK_TEMPLATE.toString());
- } else if (!StringUtils.equals(mOldTemplate.getname(),
getVmTemplate().getname())
+ if (!StringUtils.equals(mOldTemplate.getname(),
getVmTemplate().getname())
&& isVmTemlateWithSameNameExist(getVmTemplateName())) {
addCanDoActionMessage(VdcBllMessages.VMT_CANNOT_CREATE_DUPLICATE_NAME);
} else {
--
To view, visit http://gerrit.ovirt.org/10544
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia66a00303c19d9fe77fbd57021227f08ad5d160b
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <lara...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
