Shireesh Anjal has posted comments on this change.
Change subject: engine: Fix SHD service not displaying issue (#885592)
......................................................................
Patch Set 3: (1 inline comment)
....................................................
File backend/manager/dbscripts/gluster_volumes_sp.sql
Line 109: BEGIN
Line 110: RETURN QUERY SELECT *
Line 111: FROM gluster_volumes
Line 112: WHERE cluster_id = v_cluster_id AND status = v_status
Line 113: AND vol_type IN (v_vol_types)
No, it doesn't work!
I just tested fn_db_delete_config_for_version()
It works only when you pass a single value.
If it is multiple values comma separated,
it needs to be split into different values using fnSplitter.
engine1=# delete from vdc_options where version in ('3.1,3.2');
DELETE 0
engine1=# delete from vdc_options where version in (select ID from
fnSplitter('3.1,3.2'));
DELETE 62
engine1=#
Line 114: AND id IN (SELECT volume_id FROM gluster_volume_options
Line 115: WHERE option_key=v_option_key AND option_val=v_option_val);
Line 116: END; $procedure$
Line 117: LANGUAGE plpgsql;
--
To view, visit http://gerrit.ovirt.org/10336
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id11725f44ab3fdd36f76fe569d7610a411518ee1
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Dhandapani Gopal <dgo...@redhat.com>
Gerrit-Reviewer: Dhandapani Gopal <dgo...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
