Sharad Mishra has posted comments on this change.
Change subject: core: Renamed event_map.java to EventMap.java
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/10053
To unsubscribe, visit http://gerrit.ovirt.
Sharad Mishra has uploaded a new change for review.
Change subject: core: Renamed event_map.java to EventMap.java
..
core: Renamed event_map.java to EventMap.java
Change-Id: If79d19988555eefd7c94e5f8989a01910b3a41e9
Signed-off-b
Sharad Mishra has posted comments on this change.
Change subject: core: Renamed event_map_id.java EventMapId.java
..
Patch Set 1: Verified; No score
--
To view, visit http://gerrit.ovirt.org/10052
To unsubscribe, visit http://g
Sharad Mishra has posted comments on this change.
Change subject: core: Renamed event_map_id.java EventMapId.java
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/10052
T
Sharad Mishra has uploaded a new change for review.
Change subject: core: Renamed event_map_id.java EventMapId.java
..
core: Renamed event_map_id.java EventMapId.java
Change-Id: Iebc18b2929225f02f2497cd0fd4b9a08533bf232
Signed-o
Alon Bar-Lev has posted comments on this change.
Change subject: core: Renamed event_audit_log_subscriber.java to
EventAuditLogSubscriber.java
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit h
Sharad Mishra has posted comments on this change.
Change subject: core: Renamed event_audit_log_subscriber.java to
EventAuditLogSubscriber.java
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/10051
To unsubs
Sharad Mishra has uploaded a new change for review.
Change subject: core: Renamed event_audit_log_subscriber.java to
EventAuditLogSubscriber.java
..
core: Renamed event_audit_log_subscriber.java to EventAuditLogSubscriber.java
Alon Bar-Lev has posted comments on this change.
Change subject: core: Renamed bookmarks.java to Bookmarks.java
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/10049
To
Sharad Mishra has posted comments on this change.
Change subject: core: Renamed bookmarks.java to Bookmarks.java
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/10049
To unsubscribe, visit http://gerrit.ovirt
Sharad Mishra has uploaded a new change for review.
Change subject: core: Renamed bookmarks.java to Bookmarks.java
..
core: Renamed bookmarks.java to Bookmarks.java
Change-Id: I745cfd1a4e6184da098ee202a6134759fc62c52e
Signed-off
Vojtech Szocs has posted comments on this change.
Change subject: webadmin: adding loginUserId and loginUserName provider
functions
..
Patch Set 3: Verified; Looks good to me, but someone else must approve
--
To view, visit ht
Sharad Mishra has posted comments on this change.
Change subject: core: Rename async_tasks to AsyncTasks
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/10046
To unsubscribe, visit http://gerrit.ovirt.org/set
Allon Mureinik has posted comments on this change.
Change subject: core: ImportVm test cleanup: Don't mock DAOs
..
Patch Set 10: (1 inline comment)
File
backend/manager/modu
Allon Mureinik has posted comments on this change.
Change subject: core: ImportVm cleanup: CDA_afterCloneVm signature
..
Patch Set 1: (1 inline comment)
Commit Message
Line 6
Allon Mureinik has posted comments on this change.
Change subject: core: ImportVm test cleanup: Use StringUtil.repeat
..
Patch Set 7: (2 inline comments)
File
backend/manage
Sharad Mishra has posted comments on this change.
Change subject: core: Rename async_tasks to AsyncTasks
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/10046
To unsubscribe, visit http://gerrit.ovirt.org/set
Sharad Mishra has uploaded a new change for review.
Change subject: core: Rename async_tasks to AsyncTasks
..
core: Rename async_tasks to AsyncTasks
Change-Id: I66fefcb9f7996d59253e0feb603570e6d8fa389e
Signed-off-by: Sharad Mish
Allon Mureinik has posted comments on this change.
Change subject: core: Upgrade maven-checkstyle-plugin to 2.9.1
..
Patch Set 3:
we are still working on making sure we have this dependency on our internal
build system.
Please
Sharad Mishra has uploaded a new change for review.
Change subject: core: Rename class AdRefStatus to LdapRefStatus
..
core: Rename class AdRefStatus to LdapRefStatus
Since it is a generic LDAP class and not just limited to Acti
Sharad Mishra has posted comments on this change.
Change subject: core: Rename class AdRefStatus to LdapRefStatus
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/10045
To unsubscribe, visit http://gerrit.ovir
Liron Aravot has posted comments on this change.
Change subject: perform connectStorageServer to hosts after during
reconstruct/recovery(#880180)
..
Patch Set 6:
the further patch is taken down by me at the moment, will be res
Liron Aravot has posted comments on this change.
Change subject: core: ReconstructMasterDomain -connect/disconnect hosts
simultaneously
..
Patch Set 3:
will be changed to countdownlatch to avoid races, wanted to end the recons
Allon Mureinik has posted comments on this change.
Change subject: core: use java 1.7 in compat
..
Patch Set 1: I would prefer that you didn't submit this
Compat is used by GWT - which currently does not support java 7 syntax.
Liron Aravot has abandoned this change.
Change subject: core: ReconstructMasterDomain -connect/disconnect hosts
simultaneously
..
Patch Set 3: Abandoned
need to check whether it should be implemented with countdownlatch rather
Alon Bar-Lev has submitted this change and it was merged.
Change subject: vdsm: pki: install spice duplicate certificates
..
vdsm: pki: install spice duplicate certificates
Change-Id: I1fbe29b53cded96aff786a8ec81db992e028b6a9
S
Alon Bar-Lev has posted comments on this change.
Change subject: vdsm: pki: install spice duplicate certificates
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10044
To unsubscrib
Alon Bar-Lev has submitted this change and it was merged.
Change subject: vdsm: pki: enroll pending certificate in separate file
..
vdsm: pki: enroll pending certificate in separate file
This will enable existing key to be used
Alon Bar-Lev has posted comments on this change.
Change subject: vdsm: pki: enroll pending certificate in separate file
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10043
To uns
Vojtech Szocs has posted comments on this change.
Change subject: webadmin: adding loginUserId and loginUserName provider
functions
..
Patch Set 2:
Oved, I did some minor improvements to the patch, let me know what you think:
Alon Bar-Lev has uploaded a new change for review.
Change subject: vdsm: pki: install spice duplicate certificates
..
vdsm: pki: install spice duplicate certificates
Change-Id: I1fbe29b53cded96aff786a8ec81db992e028b6a9
Signed-of
Alon Bar-Lev has uploaded a new change for review.
Change subject: vdsm: pki: enroll pending certificate in separate file
..
vdsm: pki: enroll pending certificate in separate file
This will enable existing key to be used until w
Sharad Mishra has posted comments on this change.
Change subject: core: Change class name from action_version_map to
ActionVersionMap.
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/10042
To unsubscribe, vi
Sharad Mishra has uploaded a new change for review.
Change subject: core: Change class name from action_version_map to
ActionVersionMap.
..
core: Change class name from action_version_map to ActionVersionMap.
Change-Id: I453502
Liron Aravot has posted comments on this change.
Change subject: perform connectStorageServer to hosts after during
reconstruct/recovery(#880180)
..
Patch Set 6:
mkublin, i agree - submitted in a further patch.
http://gerrit.
Liron Aravot has uploaded a new change for review.
Change subject: core: ReconstructMasterDomain -connect/disconnect hosts
simultaneously
..
core: ReconstructMasterDomain -connect/disconnect hosts simultaneously
When running Re
Michael Pasternak has uploaded a new change for review.
Change subject: cli: missing acknowledgement for remove commands #886941
..
cli: missing acknowledgement for remove commands #886941
https://bugzilla.redhat.com/show_bug.cg
Yaniv Bronhaim has posted comments on this change.
Change subject: Adding system information to getCapabilities from host
..
Patch Set 6:
I know that.. it will be modified when the patch will be closed, and till then
I guess t
Michael Pasternak has uploaded a new change for review.
Change subject: cli: update prompt status upon "Connection failure" #880559
..
cli: update prompt status upon "Connection failure" #880559
https://bugzilla.redhat.com/show_
Yair Zaslavsky has posted comments on this change.
Change subject: Adding system information to getCapabilities from host
..
Patch Set 6: I would prefer that you didn't submit this
Pay attention - we are at 3.2 - upgrade script
Yaniv Bronhaim has posted comments on this change.
Change subject: Adding system information to getCapabilities from host
..
Patch Set 6: Verified
(1 inline comment)
works.. but i need your reviews. still my first change in ui
Moti Asayag has posted comments on this change.
Change subject: restapi: Add permissions sub collections to Networks
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/10033
To unsubscribe, visit http://gerrit.o
Moti Asayag has uploaded a new change for review.
Change subject: restapi: Add permissions sub collections to Networks
..
restapi: Add permissions sub collections to Networks
The patch adds the permissions sub collections to Net
Juan Hernandez has posted comments on this change.
Change subject: engine: Improve permissions queries
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/9825
To unsubscrib
Sharad Mishra has posted comments on this change.
Change subject: core: add cpu pinning error message only once
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/5707
To u
Project: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/
Build: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/2993/
Build Number: 2993
Build Status: Fixed
Triggered By: Started by upstream project "ovirt_engine" build number 3,628
-
Changes Since La
Oved Ourfali has posted comments on this change.
Change subject: engine: Improve permissions queries
..
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
..
Juan Hernandez has posted comments on this change.
Change subject: packaging: Remove overriden JBoss modules
..
Patch Set 2:
May be, will check.
--
To view, visit http://gerrit.ovirt.org/9402
To unsubscribe, visit http://gerri
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: Remove overriden JBoss modules
..
Patch Set 2:
build - ok.
shouldn't this also remove some of the dependencies?
--
To view, visit http://gerrit.ovirt
Alexander Wels has posted comments on this change.
Change subject: webadmin: Added the ability to define a 'no items' message.
..
Patch Set 5: Verified; Looks good to me, but someone else must approve
--
To view, visit http://g
Arik Hadas has posted comments on this change.
Change subject: userportal: allow connection to guest with non resp agent
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/10030
To unsubscribe, visit http://gerr
Sharad Mishra has posted comments on this change.
Change subject: core: Rename ad_groups class to LdapGroup
..
Patch Set 4: Verified
(2 inline comments)
File
backend/manage
Arik Hadas has uploaded a new change for review.
Change subject: userportal: allow connection to guest with non resp agent
..
userportal: allow connection to guest with non resp agent
Change the way we treat non responding agent
Project: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/
Build: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/2992/
Build Number: 2992
Build Status: Failure
Triggered By: Started by upstream project "ovirt_engine" build number 3,625,
Started by upstream project "ovirt_engine" build nu
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: Remove overriden JBoss modules
..
Patch Set 2:
OK.
--
To view, visit http://gerrit.ovirt.org/9402
To unsubscribe, visit http://gerrit.ovirt.org/settin
Juan Hernandez has posted comments on this change.
Change subject: packaging: Remove overriden JBoss modules
..
Patch Set 2:
Of course you can, you can build and test it yourself, that would be very
helpful.
--
To view, visit
Omer Frenkel has posted comments on this change.
Change subject: core: call Failed to runVms on different thread
..
Patch Set 1: Looks good to me, approved
just look at Arik's comment
--
To view, visit http://gerrit.ovirt.org/
Omer Frenkel has posted comments on this change.
Change subject: engine: Changed "Host" to "Server"
..
Patch Set 3: (1 inline comment)
File
backend/manager/modules/common/sr
Omer Frenkel has posted comments on this change.
Change subject: gluster: Introduced locking on gluster clusters
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/9782
To
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: Remove overriden JBoss modules
..
Patch Set 2:
Hmm... if it builds I am good... :) but I cannot provide any more useful
input...
--
To view, visit ht
Juan Hernandez has posted comments on this change.
Change subject: packaging: Remove overriden JBoss modules
..
Patch Set 2:
The jboss-as-7.1.1-9.3 package has been released:
https://admin.fedoraproject.org/updates/FEDORA-2012
Maor Lipchuk has posted comments on this change.
Change subject: core: introducing OvfAutoUpdate
..
Patch Set 19: (3 inline comments)
please fix TWS
File backend/manager/dbs
Chris Morrissey has posted comments on this change.
Change subject: core: Added "scan" to disks resource to import clones
..
Patch Set 2: (1 inline comment)
File
backend/man
Tomas Jelinek has submitted this change and it was merged.
Change subject: webadmin: fix layout of multiple lines conf msgs
..
webadmin: fix layout of multiple lines conf msgs
Fix the layout of messages in some confirmations di
Tomas Jelinek has posted comments on this change.
Change subject: webadmin: fix layout of multiple lines conf msgs
..
Patch Set 4: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9989
To unsubscri
Tomas Jelinek has posted comments on this change.
Change subject: webadmin: fix layout of multiple lines conf msgs
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9989
To unsubscribe, visit
Ravi Nori has uploaded a new change for review.
Change subject: restapi : list files with --max issue
..
restapi : list files with --max issue
List files wth --max parameter retrieves extra results
if the ISO domain has both .is
Michael Pasternak has posted comments on this change.
Change subject: engine: cpu host feature
..
Patch Set 12: I would prefer that you didn't submit this
Lazlo,
In api you need to implement internal enum (not via schema)
and
Doron Fediuck has posted comments on this change.
Change subject: engine: cpu host feature
..
Patch Set 12:
Maor,
Omer was not talking about fixtures, but on templates.
We're now looking into Omer's comment, to see if we wish
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: Move systemd install to its own target
..
Patch Set 1:
Hi,
I think simpler is to move the systemd install to the spec file...
Also I remember a previ
Juan Hernandez has uploaded a new change for review.
Change subject: packaging: Move systemd install to its own target
..
packaging: Move systemd install to its own target
Currently we install systemd related files as part of th
Moti Asayag has submitted this change and it was merged.
Change subject: webadmin: Print network description on Remove dialog
..
webadmin: Print network description on Remove dialog
The patch modifies the 'null' value printed f
Moti Asayag has posted comments on this change.
Change subject: webadmin: Print network description on Remove dialog
..
Patch Set 6: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9791
To unsubsc
Moti Asayag has submitted this change and it was merged.
Change subject: engine,webadmin: Remove getNetwork from NetworkView
..
engine,webadmin: Remove getNetwork from NetworkView
Since NetworkView extends Network, there is no
Moti Asayag has posted comments on this change.
Change subject: engine,webadmin: Remove getNetwork from NetworkView
..
Patch Set 5: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9790
To unsubscr
Dhandapani Gopal has posted comments on this change.
Change subject: engine: Brick status shows 'UP' even after brick process is
killed
..
Patch Set 1: (1 inline comment)
Incorporated review comment.
Also, in other places in
Doron Fediuck has posted comments on this change.
Change subject: webamin: hide cpuPin section according to config values
..
Patch Set 1: I would prefer that you didn't submit this
(2 inline comments)
See inline- some cleanups
Alona Kaplan has posted comments on this change.
Change subject: webadmin: Print network description on Remove dialog
..
Patch Set 5: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9791
To unsubscribe, vis
Alona Kaplan has posted comments on this change.
Change subject: engine,webadmin: Remove getNetwork from NetworkView
..
Patch Set 4: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9790
To unsubscribe, visi
Doron Fediuck has posted comments on this change.
Change subject: webadmin: missing translation in Quota ($VmName)
..
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
Gilad, I want to verify something
Shireesh Anjal has posted comments on this change.
Change subject: gluster: Introduced locking on gluster clusters
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/9782
To unsubscribe, visit http://gerrit.ovir
Dhandapani Gopal has posted comments on this change.
Change subject: engine: Changed "Host" to "Server"
..
Patch Set 3: (1 inline comment)
Response to comment in-line.
File
Shireesh Anjal has posted comments on this change.
Change subject: gluster: Introduced locking on gluster clusters
..
Patch Set 2: (2 inline comments)
Answered Michael's comment in-line. New patch-set to follow, incorporating
Juan Hernandez has posted comments on this change.
Change subject: core: copy engine.conf.defaults using the setup profile
..
Patch Set 1:
This assumes that the /usr/share/ovirt-engine/conf directory exists in
development envi
Shireesh Anjal has posted comments on this change.
Change subject: engine: Brick status shows 'UP' even after brick process is
killed
..
Patch Set 1: (1 inline comment)
File
Moti Asayag has posted comments on this change.
Change subject: core: copy engine.conf.defaults using the setup profile
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/1
Moti Asayag has submitted this change and it was merged.
Change subject: restapi: Add search capabilities to Network
..
restapi: Add search capabilities to Network
The patch adds the search capabilities to networks under
uri: a
Moti Asayag has posted comments on this change.
Change subject: restapi: Add search capabilities to Network
..
Patch Set 7: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9732
To unsubscribe, visit http://
Moti Asayag has submitted this change and it was merged.
Change subject: restapi: Organize imports
..
restapi: Organize imports
The patch organizes the import declarations of several classes
which will be modified by the follow
Moti Asayag has posted comments on this change.
Change subject: restapi: Organize imports
..
Patch Set 7: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9731
To unsubscribe, visit http://gerrit.ovirt.org/s
Michael Pasternak has uploaded a new change for review.
Change subject: cli: support fetching new sdk proxy
..
cli: support fetching new sdk proxy
Change-Id: I9dd0e827fd1347be5a2299abae8eeadb930c1a48
Signed-off-by: Michael Paste
Michael Kublin has posted comments on this change.
Change subject: core: Remove global lock on SPM calls from engine side
..
Patch Set 5: (1 inline comment)
File
backend/man
Arik Hadas has posted comments on this change.
Change subject: webadmin: fix layout of multiple lines conf msgs
..
Patch Set 2: (1 inline comment)
File
frontend/webadmin/mod
Liron Aravot has posted comments on this change.
Change subject: core: Remove global lock on SPM calls from engine side
..
Patch Set 5: (1 inline comment)
File
backend/manag
Omer Frenkel has posted comments on this change.
Change subject: engine: Changed "Host" to "Server"
..
Patch Set 3: (1 inline comment)
File
backend/manager/modules/common/sr
Liron Aravot has posted comments on this change.
Change subject: core: Remove global lock on SPM calls from engine side
..
Patch Set 5: (1 inline comment)
File
backend/manag
Arik Hadas has posted comments on this change.
Change subject: webadmin: fix layout of multiple lines conf msgs
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/9989
To unsubscribe, visit http://gerrit.ovirt.o
Roy Golan has posted comments on this change.
Change subject: core: copy engine.conf.defaults using the setup profile
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/10026
To unsubscribe, visit http://gerrit.
Roy Golan has uploaded a new change for review.
Change subject: core: copy engine.conf.defaults using the setup profile
..
core: copy engine.conf.defaults using the setup profile
make maven setup profile under ear copy the engin
Moti Asayag has posted comments on this change.
Change subject: restapi: Add search capabilities to Network
..
Patch Set 7: Verified
--
To view, visit http://gerrit.ovirt.org/9732
To unsubscribe, visit http://gerrit.ovirt.org/s
1 - 100 of 154 matches
Mail list logo
