Oved Ourfali has posted comments on this change. Change subject: engine: Improve permissions queries ......................................................................
Patch Set 1: Looks good to me, but someone else must approve (1 inline comment) .................................................... Commit Message Line 8: Line 9: The following patch contains two improvements: Line 10: 1. I removed unneeded call to some functions at permission_view, and called it small_permission_view. Line 11: The following functions were perform some calculations which is not needed. Line 12: 2. I introduced a new splitter function and I using it with out join and IN expression s/with out/without. Line 13: Line 14: With multiple paragraphs if necessary. Line 15: Line 16: Change-Id: I62fa797fbf286513183f0a3c4409ce79bec35342 -- To view, visit http://gerrit.ovirt.org/9825 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I62fa797fbf286513183f0a3c4409ce79bec35342 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkub...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
