Michael Pasternak has uploaded a new change for review. Change subject: cli: missing acknowledgement for remove commands #886941 ......................................................................
cli: missing acknowledgement for remove commands #886941 https://bugzilla.redhat.com/show_bug.cgi?id=886941 Change-Id: Ib612a6bb69fb9319131cddc02a84c715a4786286 Signed-off-by: Michael Pasternak <mpast...@redhat.com> --- M src/cli/messages.py M src/ovirtcli/command/remove.py 2 files changed, 6 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine-cli refs/changes/39/10039/1 diff --git a/src/cli/messages.py b/src/cli/messages.py index 53f13e7..78eddac 100644 --- a/src/cli/messages.py +++ b/src/cli/messages.py @@ -46,7 +46,7 @@ INVALID_COLLECTION_BASED_OPTION_SYNTAX = 'invalid syntax at "--%s", see help on collection based arguments for more details.' INVALID_ARGUMENT_SEGMENT = '"%s" is invalid argument segment.' INVALID_OPTION_SEGMENT = '"%s" is invalid segment at option "--%s".' - MISSING_CONFIGURATION_VARIABLE = 'missing configuration variable: %s' + MISSING_CONFIGURATION_VARIABLE = 'missing configuration variable: %s.' class Warning(): CANNOT_FETCH_HOST_CERT_SUBJECT = 'could not fetch host certificate info.' CANNOT_FETCH_HOST_CERT_SUBJECT_LEGACY_SDK = 'could not fetch host certificate info cause used backend/sdk does not support it.' @@ -66,3 +66,4 @@ BACKEND_ENTRY_POINT = 'entry point : %s' PYTHON_VERSION = 'python version : %s' PLATFORM = 'platform : %s' + ACCEPTED = '\naccepted.\n' diff --git a/src/ovirtcli/command/remove.py b/src/ovirtcli/command/remove.py index 1f18c58..7c01c78 100644 --- a/src/ovirtcli/command/remove.py +++ b/src/ovirtcli/command/remove.py @@ -151,7 +151,10 @@ else: self.error(Messages.Error.OBJECT_IS_IMMUTABLE % (args[0], args[1])) - self.context.formatter.format(self.context, result) + if not result: + self.write(Messages.Info.ACCEPTED) + else: + self.context.formatter.format(self.context, result) def show_help(self): """Show help for "remove".""" -- To view, visit http://gerrit.ovirt.org/10039 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ib612a6bb69fb9319131cddc02a84c715a4786286 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpast...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
