Yaniv Bronhaim has posted comments on this change. Change subject: Adding system information to getCapabilities from host ......................................................................
Patch Set 6: Verified (1 inline comment) works.. but i need your reviews. still my first change in ui and db .................................................... File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/GetCapabilitiesVDSCommand.java Line 21: ProceedProxyReturnValue(); Line 22: VdsBrokerObjectsBuilder.updateVDSData(getVds(), infoReturn.mInfo); Line 23: Line 24: // TODO: ybronhei: remove- static data not supposed to be updated each getCapabilities run Line 25: DbFacade.getInstance().getVdsStaticDao().update(getVds().getStaticData()); I need to find the current location for this update.. still haven't figured where because until now all static parameters were available after hostDeploy. now we grab this info by running getCaps command... to avoid it every time i execute getCapabilities command I need to get the capabilities during addVdsCommand. I would like to hear your opinion about where it fits better.. thanks. Line 26: } -- To view, visit http://gerrit.ovirt.org/9337 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I142198d2059cf109be3859f255621e6ceca8582b Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
