Sharad Mishra has uploaded a new change for review. Change subject: core: Rename async_tasks to AsyncTasks ......................................................................
core: Rename async_tasks to AsyncTasks Change-Id: I66fefcb9f7996d59253e0feb603570e6d8fa389e Signed-off-by: Sharad Mishra <snmis...@linux.vnet.ibm.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AsyncTaskFactory.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AsyncTaskManager.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/EntityAsyncTask.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/asynctasks/AsyncTaskParameters.java R backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/AsyncTasks.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/AsyncTaskDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/AsyncTaskDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/AsyncTaskDAOTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/BaseDAOTestCase.java 10 files changed, 55 insertions(+), 55 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/46/10046/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AsyncTaskFactory.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AsyncTaskFactory.java index 0564cad..0af39e4 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AsyncTaskFactory.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AsyncTaskFactory.java @@ -7,7 +7,7 @@ import org.ovirt.engine.core.common.asynctasks.AsyncTaskType; import org.ovirt.engine.core.common.businessentities.AsyncTaskResultEnum; import org.ovirt.engine.core.common.businessentities.AsyncTaskStatusEnum; -import org.ovirt.engine.core.common.businessentities.async_tasks; +import org.ovirt.engine.core.common.businessentities.AsyncTasks; import org.ovirt.engine.core.compat.Guid; import org.ovirt.engine.core.dal.dbbroker.DbFacade; import org.ovirt.engine.core.utils.log.Log; @@ -28,9 +28,9 @@ * @return */ public static SPMAsyncTask Construct(AsyncTaskCreationInfo creationInfo) { - async_tasks asyncTask = DbFacade.getInstance().getAsyncTaskDao().get(creationInfo.getTaskID()); + AsyncTasks asyncTask = DbFacade.getInstance().getAsyncTaskDao().get(creationInfo.getTaskID()); if (asyncTask == null || asyncTask.getaction_parameters() == null) { - asyncTask = new async_tasks(VdcActionType.Unknown, AsyncTaskResultEnum.success, + asyncTask = new AsyncTasks(VdcActionType.Unknown, AsyncTaskResultEnum.success, AsyncTaskStatusEnum.running, creationInfo.getTaskID(), new VdcActionParametersBase(), diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AsyncTaskManager.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AsyncTaskManager.java index 9d1feba..877f60f 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AsyncTaskManager.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AsyncTaskManager.java @@ -24,7 +24,7 @@ import org.ovirt.engine.core.common.businessentities.NonOperationalReason; import org.ovirt.engine.core.common.businessentities.VDS; import org.ovirt.engine.core.common.businessentities.VDSStatus; -import org.ovirt.engine.core.common.businessentities.async_tasks; +import org.ovirt.engine.core.common.businessentities.AsyncTasks; import org.ovirt.engine.core.common.businessentities.storage_pool; import org.ovirt.engine.core.common.config.Config; import org.ovirt.engine.core.common.config.ConfigValues; @@ -458,7 +458,7 @@ public synchronized void UpdateTaskWithActionParameters(Guid taskID, VdcActionParametersBase actionParameters) { if (_tasks.containsKey(taskID)) { - async_tasks currentDbAsyncTask = _tasks.get(taskID).getParameters().getDbAsyncTask(); + AsyncTasks currentDbAsyncTask = _tasks.get(taskID).getParameters().getDbAsyncTask(); currentDbAsyncTask.setaction_parameters(actionParameters); AsyncTaskUtils.updateAsyncTaskInDB(_tasks.get(taskID)); } diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java index 2951761..b304ebf 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java @@ -50,7 +50,7 @@ import org.ovirt.engine.core.common.businessentities.BusinessEntitySnapshot.SnapshotType; import org.ovirt.engine.core.common.businessentities.QuotaEnforcementTypeEnum; import org.ovirt.engine.core.common.businessentities.action_version_map; -import org.ovirt.engine.core.common.businessentities.async_tasks; +import org.ovirt.engine.core.common.businessentities.AsyncTasks; import org.ovirt.engine.core.common.businessentities.storage_pool; import org.ovirt.engine.core.common.businessentities.tags; import org.ovirt.engine.core.common.errors.VdcBLLException; @@ -1274,7 +1274,7 @@ VdcActionParametersBase parametersForTask = getParametersForTask(parentCommand, getParameters()); AsyncTaskParameters p = - new AsyncTaskParameters(asyncTaskCreationInfo, new async_tasks(parentCommand, + new AsyncTaskParameters(asyncTaskCreationInfo, new AsyncTasks(parentCommand, AsyncTaskResultEnum.success, AsyncTaskStatusEnum.running, asyncTaskCreationInfo.getTaskID(), diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/EntityAsyncTask.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/EntityAsyncTask.java index 8bdce7b..fb4715c 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/EntityAsyncTask.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/EntityAsyncTask.java @@ -11,7 +11,7 @@ import org.ovirt.engine.core.common.asynctasks.AsyncTaskParameters; import org.ovirt.engine.core.common.asynctasks.EndedTaskInfo; import org.ovirt.engine.core.common.asynctasks.SetTaskGroupStatusVisitor; -import org.ovirt.engine.core.common.businessentities.async_tasks; +import org.ovirt.engine.core.common.businessentities.AsyncTasks; import org.ovirt.engine.core.compat.NGuid; import org.ovirt.engine.core.utils.log.Log; import org.ovirt.engine.core.utils.log.LogFactory; @@ -114,7 +114,7 @@ VdcReturnValueBase vdcReturnValue = null; ExecutionContext context = null; - async_tasks dbAsyncTask = getParameters().getDbAsyncTask(); + AsyncTasks dbAsyncTask = getParameters().getDbAsyncTask(); for (EndedTaskInfo taskInfo : entityInfo.getEndedTasksInfo().getTasksInfo()) { dbAsyncTask.getaction_parameters() .Accept(taskInfo, new SetTaskGroupStatusVisitor()); diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/asynctasks/AsyncTaskParameters.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/asynctasks/AsyncTaskParameters.java index 3bbc564..c0229f5 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/asynctasks/AsyncTaskParameters.java +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/asynctasks/AsyncTaskParameters.java @@ -1,16 +1,16 @@ package org.ovirt.engine.core.common.asynctasks; -import org.ovirt.engine.core.common.businessentities.async_tasks; +import org.ovirt.engine.core.common.businessentities.AsyncTasks; import org.ovirt.engine.core.compat.Guid; public class AsyncTaskParameters { - private async_tasks privateDbAsyncTask; + private AsyncTasks privateDbAsyncTask; - public async_tasks getDbAsyncTask() { + public AsyncTasks getDbAsyncTask() { return privateDbAsyncTask; } - protected void setDbAsyncTask(async_tasks value) { + protected void setDbAsyncTask(AsyncTasks value) { privateDbAsyncTask = value; } @@ -24,7 +24,7 @@ privateCreationInfo = value; } - public AsyncTaskParameters(AsyncTaskCreationInfo info, async_tasks dbAsyncTask) { + public AsyncTaskParameters(AsyncTaskCreationInfo info, AsyncTasks dbAsyncTask) { setCreationInfo(info); setDbAsyncTask(dbAsyncTask); } diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/async_tasks.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/AsyncTasks.java similarity index 96% rename from backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/async_tasks.java rename to backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/AsyncTasks.java index 851e4da..bc8fd91 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/async_tasks.java +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/AsyncTasks.java @@ -23,15 +23,15 @@ @Entity @Table(name = "async_tasks") @TypeDef(name = "guid", typeClass = GuidType.class) -public class async_tasks implements Serializable { +public class AsyncTasks implements Serializable { private static final long serialVersionUID = 5913365704117183118L; - public async_tasks() { + public AsyncTasks() { } - public async_tasks(VdcActionType action_type, AsyncTaskResultEnum result, AsyncTaskStatusEnum status, Guid task_id, + public AsyncTasks(VdcActionType action_type, AsyncTaskResultEnum result, AsyncTaskStatusEnum status, Guid task_id, VdcActionParametersBase action_parameters, NGuid stepId, Guid commandId, Guid storagePoolId, AsyncTaskType taskType) { this.actionType = action_type; this.result = result; @@ -187,7 +187,7 @@ return false; if (getClass() != obj.getClass()) return false; - async_tasks other = (async_tasks) obj; + AsyncTasks other = (AsyncTasks) obj; if (actionParameters == null) { if (other.actionParameters != null) return false; diff --git a/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/AsyncTaskDAO.java b/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/AsyncTaskDAO.java index f024b62..738a147 100644 --- a/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/AsyncTaskDAO.java +++ b/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/AsyncTaskDAO.java @@ -3,11 +3,11 @@ import java.util.List; import org.ovirt.engine.core.common.VdcObjectType; -import org.ovirt.engine.core.common.businessentities.async_tasks; +import org.ovirt.engine.core.common.businessentities.AsyncTasks; import org.ovirt.engine.core.compat.Guid; /** - * <code>AsyncTaskDAO</code> defines a type which performs CRUD operations on instances of {@link async_tasks}. + * <code>AsyncTaskDAO</code> defines a type which performs CRUD operations on instances of {@link AsyncTasks}. * * */ @@ -18,7 +18,7 @@ * @param id the task id * @return the task */ - async_tasks get(Guid id); + AsyncTasks get(Guid id); /** * Gets async task Ids by a given entity Id. @@ -41,7 +41,7 @@ * * @return the list of tasks */ - List<async_tasks> getAll(); + List<AsyncTasks> getAll(); /** * Saves the specified task. @@ -50,7 +50,7 @@ * @param enitytType type of entities to be associated with the task * @param entityIds IDs of entities to be associated with the task */ - void save(async_tasks task, VdcObjectType enitytType, Guid... entityIds); + void save(AsyncTasks task, VdcObjectType enitytType, Guid... entityIds); /** * Saves or updates the specified task and its associated entities @@ -59,14 +59,14 @@ * @param enitytType type of entities to be associated with the task * @param entityIds IDs of entities to be associated with the task */ - void saveOrUpdate(async_tasks task, VdcObjectType entityType, Guid... entityIds); + void saveOrUpdate(AsyncTasks task, VdcObjectType entityType, Guid... entityIds); /** * Updates the specified task. * * @param task the task */ - void update(async_tasks task); + void update(AsyncTasks task); /** * Removes the task with the specified id. @@ -80,12 +80,12 @@ * * @param task the task to save */ - void save(async_tasks newAsyncTask); + void save(AsyncTasks newAsyncTask); /** * Saves or updates the async task * @param asyncTask the task to update or save */ - void saveOrUpdate(async_tasks asyncTask); + void saveOrUpdate(AsyncTasks asyncTask); } diff --git a/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/AsyncTaskDAODbFacadeImpl.java b/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/AsyncTaskDAODbFacadeImpl.java index 0abb31d..ae4c88e 100644 --- a/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/AsyncTaskDAODbFacadeImpl.java +++ b/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/AsyncTaskDAODbFacadeImpl.java @@ -12,7 +12,7 @@ import org.ovirt.engine.core.common.asynctasks.AsyncTaskType; import org.ovirt.engine.core.common.businessentities.AsyncTaskResultEnum; import org.ovirt.engine.core.common.businessentities.AsyncTaskStatusEnum; -import org.ovirt.engine.core.common.businessentities.async_tasks; +import org.ovirt.engine.core.common.businessentities.AsyncTasks; import org.ovirt.engine.core.compat.Guid; import org.ovirt.engine.core.compat.NGuid; import org.ovirt.engine.core.dal.dbbroker.CustomMapSqlParameterSource; @@ -44,12 +44,12 @@ } - private static class AsyncTaskRowMapper implements ParameterizedRowMapper<async_tasks> { + private static class AsyncTaskRowMapper implements ParameterizedRowMapper<AsyncTasks> { public static final AsyncTaskRowMapper instance = new AsyncTaskRowMapper(); @Override - public async_tasks mapRow(ResultSet rs, int rowNum) throws SQLException { - async_tasks entity = new async_tasks(); + public AsyncTasks mapRow(ResultSet rs, int rowNum) throws SQLException { + AsyncTasks entity = new AsyncTasks(); entity.setaction_type(VdcActionType.forValue(rs.getInt("action_type"))); entity.setresult(AsyncTaskResultEnum.forValue(rs.getInt("result"))); entity.setstatus(AsyncTaskStatusEnum.forValue(rs.getInt("status"))); @@ -75,7 +75,7 @@ private static class AsyncTaskParameterSource extends CustomMapSqlParameterSource { - public AsyncTaskParameterSource(DbEngineDialect dialect,async_tasks task) { + public AsyncTaskParameterSource(DbEngineDialect dialect,AsyncTasks task) { super(dialect); addValue("action_type", task.getaction_type()); addValue("result", task.getresult()); @@ -97,7 +97,7 @@ } @Override - public async_tasks get(Guid id) { + public AsyncTasks get(Guid id) { MapSqlParameterSource parameterSource = getCustomMapSqlParameterSource() .addValue("task_id", id); @@ -105,18 +105,18 @@ } @Override - public List<async_tasks> getAll() { + public List<AsyncTasks> getAll() { MapSqlParameterSource parameterSource = getCustomMapSqlParameterSource(); return getCallsHandler().executeReadList("GetAllFromasync_tasks", AsyncTaskRowMapper.instance, parameterSource); } - private AsyncTaskParameterSource getTaskParameterSource(async_tasks task) { + private AsyncTaskParameterSource getTaskParameterSource(AsyncTasks task) { return new AsyncTaskParameterSource(dialect,task); } @Override - public void save(async_tasks task, VdcObjectType entityType, Guid... entityIds) { + public void save(AsyncTasks task, VdcObjectType entityType, Guid... entityIds) { AsyncTaskParameterSource parameterSource = getTaskParameterSource(task); parameterSource.addValue("entity_type", (entityType != null) ? entityType.toString() : null); parameterSource.addValue("started_at", task.getStartTime()); @@ -127,12 +127,12 @@ } @Override - public void saveOrUpdate(async_tasks task) { + public void saveOrUpdate(AsyncTasks task) { saveOrUpdate(task, null, EMPTY_GUIDS_ARRAY); } @Override - public void saveOrUpdate(async_tasks task, VdcObjectType entityType, Guid... entityIds) { + public void saveOrUpdate(AsyncTasks task, VdcObjectType entityType, Guid... entityIds) { AsyncTaskParameterSource parameterSource = getTaskParameterSource(task); parameterSource.addValue("entity_type", (entityType != null) ? entityType.toString() : null); parameterSource.addValue("started_at", task.getStartTime()); @@ -143,20 +143,20 @@ } @Override - public void save(async_tasks task) { + public void save(AsyncTasks task) { save(task, null, EMPTY_GUIDS_ARRAY); } @Override - public void update(async_tasks task) { + public void update(AsyncTasks task) { logNullParameters(task); AsyncTaskParameterSource parameterSource = getTaskParameterSource(task); getCallsHandler().executeModification("Updateasync_tasks", parameterSource); } - private static void logNullParameters(async_tasks task) { + private static void logNullParameters(AsyncTasks task) { if (task.getaction_parameters() == null) { StringBuilder sb = new StringBuilder("Null action_parameters:\n"); StackTraceElement[] st = Thread.currentThread().getStackTrace(); diff --git a/backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/AsyncTaskDAOTest.java b/backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/AsyncTaskDAOTest.java index 75cd581..08dc0e9 100644 --- a/backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/AsyncTaskDAOTest.java +++ b/backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/AsyncTaskDAOTest.java @@ -17,7 +17,7 @@ import org.ovirt.engine.core.common.asynctasks.AsyncTaskType; import org.ovirt.engine.core.common.businessentities.AsyncTaskResultEnum; import org.ovirt.engine.core.common.businessentities.AsyncTaskStatusEnum; -import org.ovirt.engine.core.common.businessentities.async_tasks; +import org.ovirt.engine.core.common.businessentities.AsyncTasks; import org.ovirt.engine.core.compat.Guid; import org.ovirt.engine.core.compat.TransactionScopeOption; @@ -29,8 +29,8 @@ public class AsyncTaskDAOTest extends BaseDAOTestCase { private static final int TASK_COUNT = 2; private AsyncTaskDAO dao; - private async_tasks newAsyncTask; - private async_tasks existingAsyncTask; + private AsyncTasks newAsyncTask; + private AsyncTasks existingAsyncTask; private VdcActionParametersBase params; @@ -45,7 +45,7 @@ params.setTransactionScopeOption(TransactionScopeOption.RequiresNew); // create some test data - newAsyncTask = new async_tasks(); + newAsyncTask = new AsyncTasks(); newAsyncTask.settask_id(Guid.NewGuid()); newAsyncTask.setStartTime(new Date()); newAsyncTask.setaction_type(VdcActionType.AddDisk); @@ -64,7 +64,7 @@ */ @Test public void testGetWithInvalidId() { - async_tasks result = dao.get(Guid.NewGuid()); + AsyncTasks result = dao.get(Guid.NewGuid()); assertNull(result); } @@ -104,7 +104,7 @@ */ @Test public void testGet() { - async_tasks result = dao.get(existingAsyncTask.gettask_id()); + AsyncTasks result = dao.get(existingAsyncTask.gettask_id()); assertNotNull(result); assertEquals(existingAsyncTask, result); @@ -115,7 +115,7 @@ */ @Test public void testGetAll() { - List<async_tasks> result = dao.getAll(); + List<AsyncTasks> result = dao.getAll(); assertEquals(TASK_COUNT, result.size()); } @@ -127,7 +127,7 @@ public void testSave() { dao.save(newAsyncTask); - async_tasks result = dao.get(newAsyncTask.gettask_id()); + AsyncTasks result = dao.get(newAsyncTask.gettask_id()); /* //Setting startTime to null is required as DB auto generates //the value of start time @@ -163,7 +163,7 @@ existingAsyncTask.setaction_parameters(addDiskToVmParams); dao.update(existingAsyncTask); - async_tasks result = dao.get(existingAsyncTask.gettask_id()); + AsyncTasks result = dao.get(existingAsyncTask.gettask_id()); assertEquals(existingAsyncTask, result); } @@ -173,7 +173,7 @@ */ @Test public void testRemove() { - async_tasks result = dao.get(existingAsyncTask.gettask_id()); + AsyncTasks result = dao.get(existingAsyncTask.gettask_id()); assertNotNull(result); assertEquals(dao.remove(existingAsyncTask.gettask_id()), 1); @@ -197,13 +197,13 @@ AddDiskParameters addDiskToVmParams = new AddDiskParameters(); addDiskToVmParams.setSessionId("SESSION_ID"); existingAsyncTask.setaction_parameters(addDiskToVmParams); - List<async_tasks> tasks = dao.getAll(); + List<AsyncTasks> tasks = dao.getAll(); assertNotNull(tasks); int tasksNumber = tasks.size(); dao.saveOrUpdate(existingAsyncTask); tasks = dao.getAll(); assertEquals(tasksNumber, tasks.size()); - async_tasks taskFromDb = dao.get(existingAsyncTask.gettask_id()); + AsyncTasks taskFromDb = dao.get(existingAsyncTask.gettask_id()); assertNotNull(taskFromDb); assertEquals(taskFromDb,existingAsyncTask); dao.saveOrUpdate(newAsyncTask); diff --git a/backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/BaseDAOTestCase.java b/backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/BaseDAOTestCase.java index 7fd81ff..53e22ee 100644 --- a/backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/BaseDAOTestCase.java +++ b/backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/BaseDAOTestCase.java @@ -36,7 +36,7 @@ import org.ovirt.engine.core.common.businessentities.VmTemplate; import org.ovirt.engine.core.common.businessentities.action_version_map; import org.ovirt.engine.core.common.businessentities.ad_groups; -import org.ovirt.engine.core.common.businessentities.async_tasks; +import org.ovirt.engine.core.common.businessentities.AsyncTasks; import org.ovirt.engine.core.common.businessentities.bookmarks; import org.ovirt.engine.core.common.businessentities.event_map; import org.ovirt.engine.core.common.businessentities.event_notification_hist; @@ -197,7 +197,7 @@ new AnnotationConfiguration() .addAnnotatedClass(action_version_map.class) .addAnnotatedClass(ad_groups.class) - .addAnnotatedClass(async_tasks.class) + .addAnnotatedClass(AsyncTasks.class) .addAnnotatedClass(AuditLog.class) .addAnnotatedClass(bookmarks.class) .addAnnotatedClass(DbUser.class) -- To view, visit http://gerrit.ovirt.org/10046 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I66fefcb9f7996d59253e0feb603570e6d8fa389e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sharad Mishra <snmis...@linux.vnet.ibm.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches