Shireesh Anjal has posted comments on this change.
Change subject: engine: Brick status shows 'UP' even after brick process is
killed
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/GlusterVolumeStatusReturnForXmlRpc.java
Line 125: }
Line 126:
Line 127: if (volumeServiceInfo.containsKey(PID)) {
Line 128: serviceInfo.setPid(Integer.valueOf((String)
volumeServiceInfo.get(PID)));
Line 129: }
Since setPort() and setPid() accept the primitive int and not Integer, it is
better to use Integer.parseInt() and not Integer.valueOf() here.
Line 130: } else {
Line 131: serviceInfo.setStatus(GlusterStatus.DOWN);
Line 132: }
Line 133: }
--
To view, visit http://gerrit.ovirt.org/10022
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I323d9c5c30d707619e7403b76bd33cc43bc90499
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Dhandapani Gopal <dgo...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
