Shireesh Anjal has posted comments on this change.

Change subject: gluster: Introduced locking on gluster clusters
......................................................................


Patch Set 2: (2 inline comments)

Answered Michael's comment in-line. New patch-set to follow, incorporating 
Roy's comment.

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterManager.java
Line 149:                 LockingGroup.GLUSTER.name()), null);
Line 150:     }
Line 151: 
Line 152:     private LockManager getLockManager() {
Line 153:         return LockManagerFactory.getLockManager();
Done
Line 154:     }
Line 155: 
Line 156:     /**
Line 157:      * Refreshes details of all volume across all clusters being 
managed in the engine. It can end up doing the


....................................................
File 
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/locks/LockingGroup.java
Line 12:     VM_NAME,
Line 13:     STORAGE,
Line 14:     REGISTER_VDS,
Line 15:     VM_SNAPSHOTS,
Line 16:     GLUSTER,
I've started doing this based on the discussion on engine-devel:
http://lists.ovirt.org/pipermail/engine-devel/2012-April/001315.html
Line 17:     ;
Line 18: 


--
To view, visit http://gerrit.ovirt.org/9782
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I57b3bd0b9e384ff130c4083147ac228a81185a2d
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shireesh Anjal <san...@redhat.com>
Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to