Vojtech Szocs has posted comments on this change. Change subject: webadmin: adding loginUserId and loginUserName provider functions ......................................................................
Patch Set 2: Oved, I did some minor improvements to the patch, let me know what you think: * injecting CurrentUser into PluginManager and using it, instead of using Frontend.getLoggedInUser (this is consistent with UserLogin event taking user data from CurrentUser in PluginEventHandler) * modified CurrentUser to represent userId as String (no need for Guid) * added "if (canDoPluginAction(this.pluginName))" checks for new API functions - this condition should be used for all API functions except core ones (register, ready, configObject), see canDoPluginAction method Javadoc for details I've also verified that on UserLogout event, both API functions return null (user is already signed out). -- To view, visit http://gerrit.ovirt.org/9998 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I932e329668d7fc8d0a3608d2984d2645a98fe053 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
