[Engine-patches] Change in ovirt-engine[master]: [WIP] core: Handling transactivity at ShutdownVmCommand

2012-10-17 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: [WIP] core: Handling transactivity at ShutdownVmCommand .. Patch Set 2: (1 inline comment) File backend/ma

[Engine-patches] Change in ovirt-engine[master]: core: WIP:AddStoragePoolWithStorages-prevent domains from st...

2012-10-17 Thread laravot
Liron Aravot has posted comments on this change. Change subject: core: WIP:AddStoragePoolWithStorages-prevent domains from stay LOCKED .. Patch Set 8: mkublin, i wrote in the commit message the scenario that should be solved b

[Engine-patches] Change in ovirt-engine[master]: core: search for disks on specific domains

2012-10-17 Thread emesika
Eli Mesika has posted comments on this change. Change subject: core: search for disks on specific domains .. Patch Set 2: Verified -- To view, visit http://gerrit.ovirt.org/8385 To unsubscribe, visit http://gerrit.ovirt.org/set

[Engine-patches] Change in ovirt-engine[master]: core: search for disks on specific domains

2012-10-17 Thread emesika
Eli Mesika has submitted this change and it was merged. Change subject: core: search for disks on specific domains .. core: search for disks on specific domains Fix exception due to bad join condition when searching for disks o

[Engine-patches] Change in ovirt-engine[master]: core: search for disks on specific domains

2012-10-17 Thread emesika
Eli Mesika has posted comments on this change. Change subject: core: search for disks on specific domains .. Patch Set 2: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8385 To unsubscribe, visit http://ge

[Engine-patches] Change in ovirt-engine[master]: core: Cleanup AuditLogableBase.

2012-10-17 Thread Sharad Mishra
Sharad Mishra has abandoned this change. Change subject: core: Cleanup AuditLogableBase. .. Patch Set 1: Abandoned -- To view, visit http://gerrit.ovirt.org/8264 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-Me

[Engine-patches] Change in ovirt-engine[master]: core: WIP:AddStoragePoolWithStorages-prevent domains from st...

2012-10-17 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: core: WIP:AddStoragePoolWithStorages-prevent domains from stay LOCKED .. Patch Set 8: I would prefer that you didn't submit this These is exception from log: 2

[Engine-patches] Change in ovirt-engine[master]: core: WIP:AddStoragePoolWithStorages-prevent domains from st...

2012-10-17 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: WIP:AddStoragePoolWithStorages-prevent domains from stay LOCKED .. Patch Set 8: Looks good to me, but someone else must approve -- To view, visit http://

[Engine-patches] Change in ovirt-engine[master]: core: DeactivateStorageDomainCommand cleanup

2012-10-17 Thread Sharad Mishra
Sharad Mishra has posted comments on this change. Change subject: core: DeactivateStorageDomainCommand cleanup .. Patch Set 4: (2 inline comments) File backend/manager/modul

[Engine-patches] Change in ovirt-engine[master]: core: DeactivateStorageDomainCommand cleanup

2012-10-17 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: DeactivateStorageDomainCommand cleanup .. Patch Set 4: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/8513 To u

[Engine-patches] Change in ovirt-engine[master]: core: report VDS if lun does not connect

2012-10-17 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: report VDS if lun does not connect .. Patch Set 3: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/8603 To unsub

[Engine-patches] Change in ovirt-dwh[master]: packaging: Using constant instead of literal DB name.

2012-10-17 Thread ydary
Yaniv Dary has submitted this change and it was merged. Change subject: packaging: Using constant instead of literal DB name. .. packaging: Using constant instead of literal DB name. Change-Id: I922a57ff0d5c99188362a8a0c6a63702

[Engine-patches] Change in ovirt-dwh[master]: packaging: Using constant instead of literal DB name.

2012-10-17 Thread ydary
Yaniv Dary has posted comments on this change. Change subject: packaging: Using constant instead of literal DB name. .. Patch Set 2: Verified; Looks good to me, approved Verified by Alex Lourie. -- To view, visit http://gerrit

[Engine-patches] Change in ovirt-engine[master]: engine: Integrate smartcard support

2012-10-17 Thread tjelinek
Tomas Jelinek has posted comments on this change. Change subject: engine: Integrate smartcard support .. Patch Set 7: (2 inline comments) File backend/manager/modules/utils/

[Engine-patches] Change in ovirt-engine[master]: userportal: VMs are not refreshed after edit

2012-10-17 Thread gchaplik
Gilad Chaplik has posted comments on this change. Change subject: userportal: VMs are not refreshed after edit .. Patch Set 1: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8610 To unsubscribe, visit http

[Engine-patches] Change in ovirt-dwh[master]: packaging: Using constant instead of literal DB name.

2012-10-17 Thread alourie
Alex Lourie has posted comments on this change. Change subject: packaging: Using constant instead of literal DB name. .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/8048 To unsubscribe, visit http://gerrit.o

[Engine-patches] Change in ovirt-engine[master]: restapi: RSDL does not document '?current' query parameter (...

2012-10-17 Thread rnori
Ravi Nori has posted comments on this change. Change subject: restapi: RSDL does not document '?current' query parameter (#864836) .. Patch Set 5: Verified -- To view, visit http://gerrit.ovirt.org/8607 To unsubscribe, visit h

[Engine-patches] Change in ovirt-engine[master]: core: WipeAfterDelete defaults to true in GUI, but false in ...

2012-10-17 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: core: WipeAfterDelete defaults to true in GUI, but false in REST API (#845466) .. Patch Set 5: (1 inline comment) minor comment inside, please also verify all re

[Engine-patches] Change in ovirt-engine[master]: core: WIP:AddStoragePoolWithStorages-prevent domains from st...

2012-10-17 Thread laravot
Liron Aravot has posted comments on this change. Change subject: core: WIP:AddStoragePoolWithStorages-prevent domains from stay LOCKED .. Patch Set 7: (2 inline comments) Fi

[Engine-patches] Change in ovirt-engine[master]: core:WIP: disable compensation in reconstruct/recovery comma...

2012-10-17 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: core:WIP: disable compensation in reconstruct/recovery commands .. Patch Set 4: I would prefer that you didn't submit this I don't understand how the following

[Engine-patches] Change in ovirt-engine[master]: core: WIP:AddStoragePoolWithStorages-prevent domains from st...

2012-10-17 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: core: WIP:AddStoragePoolWithStorages-prevent domains from stay LOCKED .. Patch Set 7: I would prefer that you didn't submit this (2 inline comments) The follo

[Engine-patches] Change in ovirt-engine[master]: core: WIP:AddStoragePoolWithStorages-prevent domains from st...

2012-10-17 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: WIP:AddStoragePoolWithStorages-prevent domains from stay LOCKED .. Patch Set 7: Looks good to me, but someone else must approve I think this should be in

[Engine-patches] Change in ovirt-engine[master]: core: WIP:AddStoragePoolWithStorages-prevent domains from st...

2012-10-17 Thread laravot
Liron Aravot has posted comments on this change. Change subject: core: WIP:AddStoragePoolWithStorages-prevent domains from stay LOCKED .. Patch Set 7: (1 inline comment) Fil

[Engine-patches] Change in ovirt-engine[master]: restapi: RSDL does not document '?current' query parameter (...

2012-10-17 Thread mpastern
Michael Pasternak has posted comments on this change. Change subject: restapi: RSDL does not document '?current' query parameter (#864836) .. Patch Set 5: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/86

[Engine-patches] Change in ovirt-engine[master]: core: WIP:AddStoragePoolWithStorages-prevent domains from st...

2012-10-17 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: WIP:AddStoragePoolWithStorages-prevent domains from stay LOCKED .. Patch Set 7: I would prefer that you didn't submit this -- To view, visit http://gerri

[Engine-patches] Change in ovirt-engine[master]: core: WIP:AddStoragePoolWithStorages-prevent domains from st...

2012-10-17 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: WIP:AddStoragePoolWithStorages-prevent domains from stay LOCKED .. Patch Set 7: Looks good to me, but someone else must approve (1 inline comment) .

[Engine-patches] Change in ovirt-engine[master]: core: WipeAfterDelete defaults to true in GUI, but false in ...

2012-10-17 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: WipeAfterDelete defaults to true in GUI, but false in REST API (#845466) .. Patch Set 5: Looks good to me, but someone else must approve -- To view, visi

[Engine-patches] Change in ovirt-engine[master]: webadmin: UI Plugins PoC, revision 5

2012-10-17 Thread vszocs
Vojtech Szocs has posted comments on this change. Change subject: webadmin: UI Plugins PoC, revision 5 .. Patch Set 1: (8 inline comments) Thanks guys, I've replied to all comments, except for "Public/Private" ones. I'm used t

[Engine-patches] Change in ovirt-engine[master]: core: WipeAfterDelete defaults to true in GUI, but false in ...

2012-10-17 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: WipeAfterDelete defaults to true in GUI, but false in REST API (#845466) .. Patch Set 4: Looks good to me, but someone else must approve -- To view, visi

[Engine-patches] Change in ovirt-engine[master]: core: WIP:AddStoragePoolWithStorages-prevent domains from st...

2012-10-17 Thread laravot
Liron Aravot has posted comments on this change. Change subject: core: WIP:AddStoragePoolWithStorages-prevent domains from stay LOCKED .. Patch Set 6: (1 inline comment) Fil

[Engine-patches] Change in ovirt-engine[master]: core: WIP:AddStoragePoolWithStorages-prevent domains from st...

2012-10-17 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: WIP:AddStoragePoolWithStorages-prevent domains from stay LOCKED .. Patch Set 6: I would prefer that you didn't submit this (1 inline comment) ..

[Engine-patches] Change in ovirt-engine[master]: core: WIP:AddStoragePoolWithStorages-prevent domains from st...

2012-10-17 Thread laravot
Liron Aravot has posted comments on this change. Change subject: core: WIP:AddStoragePoolWithStorages-prevent domains from stay LOCKED .. Patch Set 6: rebased in order to verify -- To view, visit http://gerrit.ovirt.org/8536

[Engine-patches] Change in ovirt-engine[master]: [WIP] core: Handling transactivity at ShutdownVmCommand

2012-10-17 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: [WIP] core: Handling transactivity at ShutdownVmCommand .. Patch Set 2: (1 inline comment) File backend/ma

[Engine-patches] Change in ovirt-engine[master]: core, webadmin: GetConfigurationValuesQuery for UI cache

2012-10-17 Thread vszocs
Vojtech Szocs has posted comments on this change. Change subject: core,webadmin: GetConfigurationValuesQuery for UI cache .. Patch Set 3: Looks good to me, but someone else must approve +1 for the frontend part. @Roy: we can't

[Engine-patches] Change in ovirt-engine[master]: core, webadmin: GetConfigurationValuesQuery for UI cache

2012-10-17 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core,webadmin: GetConfigurationValuesQuery for UI cache .. Patch Set 3: (1 inline comment) File backend/ma

[Engine-patches] Change in ovirt-reports[master]: reports: added localization for reports files

2012-10-17 Thread ydary
Yaniv Dary has posted comments on this change. Change subject: reports: added localization for reports files .. Patch Set 2: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8632 To unsubscribe, vi

[Engine-patches] Change in ovirt-reports[master]: reports: added localization for reports files

2012-10-17 Thread ydary
Yaniv Dary has submitted this change and it was merged. Change subject: reports: added localization for reports files .. reports: added localization for reports files added languages files for: - de - es - fr - ja - pt_BR - zh_

[Engine-patches] Change in ovirt-engine[master]: core: DeactivateStorageDomainCommand cleanup

2012-10-17 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: DeactivateStorageDomainCommand cleanup .. Patch Set 3: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/8513 To u

[Engine-patches] Change in ovirt-engine[master]: core: ConnectAllHostsToLunCommand fixup

2012-10-17 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: ConnectAllHostsToLunCommand fixup .. Patch Set 4: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/8577 To unsubs

[Engine-patches] Change in ovirt-engine[master]: core: report VDS if lun does not connect

2012-10-17 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: report VDS if lun does not connect .. Patch Set 2: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/8603 To unsub

[Engine-patches] Change in ovirt-engine[master]: : WipeAfterDelete defaults to true in GUI, but false i...

2012-10-17 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: : WipeAfterDelete defaults to true in GUI, but false in REST API. .. Patch Set 3: I would prefer that you didn't submit this (2 inline comments) The code look

[Engine-patches] Change in ovirt-engine[master]: : WipeAfterDelete defaults to true in GUI, but false i...

2012-10-17 Thread rnori
Ravi Nori has abandoned this change. Change subject: : WipeAfterDelete defaults to true in GUI, but false in REST API. .. Patch Set 2: Abandoned Uploaded new patch -- To view, visit http://gerrit.ovirt.org/8570 To unsubscribe

[Engine-patches] Change in ovirt-engine[master]: UI: add missing bonding options to bonding type selection

2012-10-17 Thread shavivi
Shahar Havivi has abandoned this change. Change subject: UI: add missing bonding options to bonding type selection .. Patch Set 1: Abandoned -- To view, visit http://gerrit.ovirt.org/6974 To unsubscribe, visit http://gerrit.ovi

[Engine-patches] Change in ovirt-engine[master]: core, webadmin: GetConfigurationValuesQuery for UI cache

2012-10-17 Thread rgolan
Roy Golan has posted comments on this change. Change subject: core,webadmin: GetConfigurationValuesQuery for UI cache .. Patch Set 3: I would prefer that you didn't submit this see previous comment -- To view, visit http://ger

[Engine-patches] Change in ovirt-engine[master]: core, webadmin: GetConfigurationValuesQuery for UI cache

2012-10-17 Thread rgolan
Roy Golan has posted comments on this change. Change subject: core,webadmin: GetConfigurationValuesQuery for UI cache .. Patch Set 3: (1 inline comment) we can't cache values becuase they can be reloaded/refreshed and we don't

[Engine-patches] Change in ovirt-engine[master]: engine: Integrate smartcard support

2012-10-17 Thread rgolan
Roy Golan has posted comments on this change. Change subject: engine: Integrate smartcard support .. Patch Set 7: I would prefer that you didn't submit this (2 inline comments) .

[Engine-patches] Change in ovirt-engine[master]: : WipeAfterDelete defaults to true in GUI, but false i...

2012-10-17 Thread rnori
Ravi Nori has restored this change. Change subject: : WipeAfterDelete defaults to true in GUI, but false in REST API. .. Patch Set 2: Restored Fixed commit message -- To view, visit http://gerrit.ovirt.org/8570 To unsubscribe

[Engine-patches] Change in ovirt-engine[master]: : WipeAfterDelete defaults to true in GUI, but false i...

2012-10-17 Thread rnori
Ravi Nori has abandoned this change. Change subject: : WipeAfterDelete defaults to true in GUI, but false in REST API. .. Patch Set 2: Abandoned Submitted new patch -- To view, visit http://gerrit.ovirt.org/8570 To unsubscrib

[Engine-patches] Change in ovirt-engine[master]: core, webadmin: GetConfigurationValuesQuery for UI cache

2012-10-17 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core,webadmin: GetConfigurationValuesQuery for UI cache .. Patch Set 3: I would prefer that you didn't submit this (8 inline comments)

[Engine-patches] Change in ovirt-engine[master]: core, webadmin: GetConfigurationValuesQuery for UI cache

2012-10-17 Thread alkaplan
Alona Kaplan has posted comments on this change. Change subject: core,webadmin: GetConfigurationValuesQuery for UI cache .. Patch Set 3: Looks good to me, but someone else must approve +1 for frontend -- To view, visit http://

[Engine-patches] Change in ovirt-engine[master]: : WipeAfterDelete defaults to true in GUI, but false i...

2012-10-17 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: : WipeAfterDelete defaults to true in GUI, but false in REST API. .. Patch Set 1: I would prefer that you didn't submit this (1 inline comment) The code looks

[Engine-patches] Change in ovirt-engine[master]: : WipeAfterDelete defaults to true in GUI, but false i...

2012-10-17 Thread rnori
Ravi Nori has uploaded a new change for review. Change subject: : WipeAfterDelete defaults to true in GUI, but false in REST API. .. : WipeAfterDelete defaults to true in GUI, but false in REST API. WipeAfterDelete in gui defau

[Engine-patches] Change in ovirt-engine[master]: [WIP] core: Handling transactivity at ShutdownVmCommand

2012-10-17 Thread emesika
Eli Mesika has posted comments on this change. Change subject: [WIP] core: Handling transactivity at ShutdownVmCommand .. Patch Set 2: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8571 To unsubscribe, vi

[Engine-patches] Change in ovirt-engine[master]: core:Power Management: restart operatio..(#865385)

2012-10-17 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core:Power Management: restart operatio..(#865385) .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/862

[Engine-patches] Change in ovirt-engine[master]: core: avoid having SD active on vdsm and not in engine

2012-10-17 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: avoid having SD active on vdsm and not in engine .. Patch Set 5: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org

[Engine-patches] Change in ovirt-engine[master]: webadmin: Netwrok as Main Tab- (Phase 3) (wip)

2012-10-17 Thread alkaplan
Alona Kaplan has uploaded a new change for review. Change subject: webadmin: Netwrok as Main Tab- (Phase 3) (wip) .. webadmin: Netwrok as Main Tab- (Phase 3) (wip) Add to Network->Host subtab radio button that will show either-

[Engine-patches] Change in ovirt-engine[master]: core:Power Management: restart operatio..(#865385)

2012-10-17 Thread emesika
Eli Mesika has uploaded a new change for review. Change subject: core:Power Management: restart operatio..(#865385) .. core:Power Management: restart operatio..(#865385) core:Power Management: restart operation fails occasionall

[Engine-patches] Change in ovirt-engine[master]: core: Adding NetworkIdParameters (WIP)

2012-10-17 Thread msalem
Muli Salem has posted comments on this change. Change subject: core: Adding NetworkIdParameters (WIP) .. Patch Set 2: (2 inline comments) File backend/manager/modules/common

[Engine-patches] Change in ovirt-engine[master]: core:WIP: disable compensation in reconstruct/recovery comma...

2012-10-17 Thread laravot
Liron Aravot has uploaded a new change for review. Change subject: core:WIP: disable compensation in reconstruct/recovery commands .. core:WIP: disable compensation in reconstruct/recovery commands Related to bug 845838 https://

[Engine-patches] Change in ovirt-engine[master]: Engine: Rhev-H upgrade list show downgraded versions (#84276...

2012-10-17 Thread shavivi
Shahar Havivi has submitted this change and it was merged. Change subject: Engine: Rhev-H upgrade list show downgraded versions (#842767) .. Engine: Rhev-H upgrade list show downgraded versions (#842767) https://bugzilla.redhat

[Engine-patches] Change in ovirt-engine[master]: Engine: Rhev-H upgrade list show downgraded versions (#84276...

2012-10-17 Thread masayag
Moti Asayag has posted comments on this change. Change subject: Engine: Rhev-H upgrade list show downgraded versions (#842767) .. Patch Set 8: Looks good to me, approved (1 inline comment) .

[Engine-patches] Change in ovirt-engine[master]: Engine: Rhev-H upgrade list show downgraded versions (#84276...

2012-10-17 Thread shavivi
Shahar Havivi has posted comments on this change. Change subject: Engine: Rhev-H upgrade list show downgraded versions (#842767) .. Patch Set 8: Verified -- To view, visit http://gerrit.ovirt.org/7430 To unsubscribe, visit http

[Engine-patches] Change in ovirt-engine[master]: Engine: Rhev-H upgrade list show downgraded versions (#84276...

2012-10-17 Thread shavivi
Shahar Havivi has posted comments on this change. Change subject: Engine: Rhev-H upgrade list show downgraded versions (#842767) .. Patch Set 7: (2 inline comments) File bac

[Engine-patches] Change in ovirt-engine[master]: : WipeAfterDelete defaults to true in GUI, but false i...

2012-10-17 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: : WipeAfterDelete defaults to true in GUI, but false in REST API. .. Patch Set 2: I would prefer that you didn't submit this (5 inline comments) .

[Engine-patches] Change in ovirt-engine[master]: Engine: Rhev-H upgrade list show downgraded versions (#84276...

2012-10-17 Thread masayag
Moti Asayag has posted comments on this change. Change subject: Engine: Rhev-H upgrade list show downgraded versions (#842767) .. Patch Set 7: (2 inline comments) File backe