Sharad Mishra has posted comments on this change.
Change subject: core: DeactivateStorageDomainCommand cleanup
......................................................................
Patch Set 4: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainCommand.java
Line 77: if (!(checkStorageDomain() &&
checkStorageDomainStatus(StorageDomainStatus.Active))) {
Line 78: return false;
Line 79: }
Line 80:
Line 81: if(!getParameters().getIsInternal()) {
why no space after 'if'' ?
Line 82: if (getStorageDomain().getstorage_domain_type() ==
StorageDomainType.Master) {
Line 83: List<storage_domains> domains =
Line 84:
getStorageDomainDAO().getAllForStoragePool(getStorageDomain().getstorage_pool_id().getValue());
Line 85:
Line 103: }
Line 104: }
Line 105: if (!getVmDAO()
Line 106:
.getAllActiveForStorageDomain(getStorageDomain().getId())
Line 107: .isEmpty()) {
I would rather have all the above in one single line as -
if
!getVmDAO().getAllActiveForStorageDomain(getStorageDomain().getId()).isEmpty())
{
Line 108:
addCanDoActionMessage(VdcBllMessages.ACTION_TYPE_FAILED_DETECTED_ACTIVE_VMS);
Line 109: return false;
Line 110: }
Line 111: }
--
To view, visit http://gerrit.ovirt.org/8513
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I52d5be0a53876ad8494e1d6068aaff057512d6d8
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <lhorn...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhorn...@redhat.com>
Gerrit-Reviewer: Sharad Mishra <snmis...@linux.vnet.ibm.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
