Allon Mureinik has posted comments on this change.
Change subject: core: WIP:AddStoragePoolWithStorages-prevent domains from stay
LOCKED
......................................................................
Patch Set 7: Looks good to me, but someone else must approve
(1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
Line 235: return DbFacade.getInstance().getBusinessEntitySnapshotDao();
Line 236: }
Line 237:
Line 238: protected StoragePoolIsoMapDAO getStoragePoolIsoMapDAO() {
Line 239: return DbFacade.getInstance().getStoragePoolIsoMapDao();
Is this used in CommandBase?
You should put in the highest place that actually has a use for it,
Line 240: }
Line 241:
Line 242: protected VdsSpmIdMapDAO getVdsSpmIdMapDAO() {
Line 243: return DbFacade.getInstance().getVdsSpmIdMapDao();
--
To view, visit http://gerrit.ovirt.org/8536
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie8b9fc0d324eac2146d4f7d60d48e4dd5eb5d9e0
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <lara...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Liron Aravot <lara...@redhat.com>
Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
