Roy Golan has posted comments on this change.
Change subject: core,webadmin: GetConfigurationValuesQuery for UI cache
......................................................................
Patch Set 3: (1 inline comment)
we can't cache values becuase they can be reloaded/refreshed and we don't have
notification mechanism about invalidation
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetConfigurationValuesQuery.java
Line 29: Map<KeyValuePairCompat<ConfigurationValues, String>, Object>
configValuesMap =
Line 30: new HashMap<KeyValuePairCompat<ConfigurationValues,
String>, Object>();
Line 31:
Line 32: // Cache ConfigValues in String set
Line 33: createConfigValuesSet();
the whole caching idea here should be dropped because configs can get reloaded
and we don't have a notify mechanism to inform about invalidation.
Line 34:
Line 35: for (ConfigurationValues configValue :
ConfigurationValues.values()) {
Line 36: // Ignore an admin configuration value on filtered mode
Line 37: // Ignore a configuration value that doesn't exist in
ConfigValues enum
--
To view, visit http://gerrit.ovirt.org/8563
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id51a9f86bceef07de728335643b16c0554b6876c
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
