Shahar Havivi has posted comments on this change.
Change subject: Engine: Rhev-H upgrade list show downgraded versions (#842767)
......................................................................
Patch Set 7: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetoVirtISOsQuery.java
Line 87: RpmVersion isoVersion =
parseIsoFileVersion(isoFileName, majorVersionStr);
Line 88: boolean shouldAdd = false;
Line 89:
Line 90: if (isoVersion != null &&
isIsoVersionSupported(isoVersion)) {
Line 91: if (isoData.getVdsmCompatibilityVersion()
!= null) {
Done
Line 92: for (String v :
isoData.getVdsmCompatibilityVersion()) {
Line 93: Version isoClusterVersion = new
Version(v);
Line 94: if
(isNewerVersion(isoClusterVersion)) {
Line 95: shouldAdd = true;
....................................................
File
backend/manager/modules/bll/src/test/resources/ovirt-isos/version-7.0-20111010.0.el6.txt
Line 1: 7.0,20111010.0.el6
Line 2: 3.0,3.1
Done
--
To view, visit http://gerrit.ovirt.org/7430
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I042ae5263d565787ea7460f1d5f59beb77acff8b
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shav...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Einav Cohen <eco...@redhat.com>
Gerrit-Reviewer: Itamar Heim <ih...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Shahar Havivi <shav...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
